compile: implement named constant (True, False, None)

Author: ncw

compile/compile.go

@@ -500,7 +500,7 @@ func (c *compiler) Expr(expr ast.Expr) {
 		c.OpArg(vm.LOAD_CONST, c.Const(node.S))
 	case *ast.NameConstant:
 		// Value Singleton
-		panic("FIXME compile: NameConstant not implemented")
+		c.OpArg(vm.LOAD_CONST, c.Const(node.Value))
 	case *ast.Ellipsis:
 		panic("FIXME compile: Ellipsis not implemented")
 	case *ast.Attribute:

compile/compile_data_test.go

@@ -947,4 +947,55 @@ var compileTestData = []struct {
 		Firstlineno:    1,
 		Lnotab:         "",
 	}, "  1           0 LOAD_NAME                0 (a)\n              3 LOAD_NAME                1 (b)\n              6 LOAD_NAME                2 (c)\n              9 LOAD_NAME                3 (d)\n             12 BUILD_LIST               4\n             15 RETURN_VALUE\n"},
+	{"True", "eval", py.Code{
+		Argcount:       0,
+		Kwonlyargcount: 0,
+		Nlocals:        0,
+		Stacksize:      1,
+		Flags:          64,
+		Code:           "\x64\x00\x00\x53",
+		Consts:         []py.Object{py.Int(1)},
+		Names:          []string{},
+		Varnames:       []string{},
+		Freevars:       []string{},
+		Cellvars:       []string{},
+		Filename:       "<string>",
+		Name:           "<module>",
+		Firstlineno:    1,
+		Lnotab:         "",
+	}, "  1           0 LOAD_CONST               0 (True)\n              3 RETURN_VALUE\n"},
+	{"False", "eval", py.Code{
+		Argcount:       0,
+		Kwonlyargcount: 0,
+		Nlocals:        0,
+		Stacksize:      1,
+		Flags:          64,
+		Code:           "\x64\x00\x00\x53",
+		Consts:         []py.Object{py.Int(0)},
+		Names:          []string{},
+		Varnames:       []string{},
+		Freevars:       []string{},
+		Cellvars:       []string{},
+		Filename:       "<string>",
+		Name:           "<module>",
+		Firstlineno:    1,
+		Lnotab:         "",
+	}, "  1           0 LOAD_CONST               0 (False)\n              3 RETURN_VALUE\n"},
+	{"None", "eval", py.Code{
+		Argcount:       0,
+		Kwonlyargcount: 0,
+		Nlocals:        0,
+		Stacksize:      1,
+		Flags:          64,
+		Code:           "\x64\x00\x00\x53",
+		Consts:         []py.Object{py.None},
+		Names:          []string{},
+		Varnames:       []string{},
+		Freevars:       []string{},
+		Cellvars:       []string{},
+		Filename:       "<string>",
+		Name:           "<module>",
+		Firstlineno:    1,
+		Lnotab:         "",
+	}, "  1           0 LOAD_CONST               0 (None)\n              3 RETURN_VALUE\n"},
 }

compile/make_compile_test.py

@@ -76,6 +76,10 @@
     ('''[a]''', "eval"),
     ('''[a,b]''', "eval"),
     ('''[a,b,c,d]''', "eval"),
+    # named constant
+    ('''True''', "eval"),
+    ('''False''', "eval"),
+    ('''None''', "eval"),
 ]
 
 def string(s):