Skip to content

Commit 48b2648

Browse files
committed
py: Fix errors are suppressed in generator comprehensions
Sequence.Iterate does not handle exceptions. Iterate() should return error except StopIteration.
1 parent 0773b68 commit 48b2648

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

py/sequence.go

+5-2
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,13 @@ func Iterate(obj Object, fn func(Object) bool) error {
9393
return err
9494
}
9595
for {
96-
item, finished := Next(iterator)
97-
if finished != nil {
96+
item, err := Next(iterator)
97+
if err != nil && err == StopIteration {
9898
break
9999
}
100+
if err != nil && err != StopIteration {
101+
return err
102+
}
100103
if fn(item) {
101104
break
102105
}

0 commit comments

Comments
 (0)