Skip to content

Fix/deepsource issues #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 13 commits into from
Oct 29, 2019
Merged

Fix/deepsource issues #952

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0685d62
fixed classmethod argument PYL-C0202
imkaka Oct 22, 2019
d52c578
fixed unused variable found PYL-W0612
imkaka Oct 22, 2019
dba01d3
silence PYL-W0401
imkaka Oct 22, 2019
607d8aa
silence PYL-W0614
imkaka Oct 22, 2019
5eb8289
fix Loop variable used outside the loop
imkaka Oct 23, 2019
597fb58
fix File opened without the with statement
imkaka Oct 23, 2019
284f89d
silenced iter returns a non-iterator
imkaka Oct 23, 2019
abb1896
Merge branch 'master' into fix/deepsource-issues
imkaka Oct 23, 2019
1dc46d7
resolved all minor issues arised by last fix patch
imkaka Oct 23, 2019
d4756f4
Merge branch 'fix/deepsource-issues' of github.com:imkaka/GitPython i…
imkaka Oct 23, 2019
4dda3cb
silance Re-defined variable from outer scope
imkaka Oct 24, 2019
225529c
silence PYL-W0621
imkaka Oct 24, 2019
9932e64
removed extra line as per code review
imkaka Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
silence PYL-W0621
  • Loading branch information
@imkaka
imkaka committed Oct 24, 2019
commit 225529c8baaa6ee65b1b23fc1d79b99bf49ebfb1
6 changes: 2 additions & 4 deletions git/refs/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,14 @@ def message(self):
"""Message describing the operation that acted on the reference"""
return self[4]

# skipcq: PYL-W0621
@classmethod
def new(cls, oldhexsha, newhexsha, actor, time, tz_offset, message):
def new(cls, oldhexsha, newhexsha, actor, time, tz_offset, message): # skipcq: PYL-W0621
""":return: New instance of a RefLogEntry"""
if not isinstance(actor, Actor):
raise ValueError("Need actor instance, got %s" % actor)
# END check types
return RefLogEntry((oldhexsha, newhexsha, actor, (time, tz_offset), message))

# skipcq: PYL-W0621
@classmethod
def from_line(cls, line):
""":return: New RefLogEntry instance from the given revlog line.
Expand Down Expand Up @@ -123,7 +121,7 @@ def from_line(cls, line):
# END handle missing end brace

actor = Actor._from_string(info[82:email_end + 1])
time, tz_offset = parse_date(info[email_end + 2:])
time, tz_offset = parse_date(info[email_end + 2:]) # skipcq: PYL-W0621

return RefLogEntry((oldhexsha, newhexsha, actor, (time, tz_offset), msg))

Expand Down