Skip to content

Fix/deepsource issues #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 13 commits into from
Oct 29, 2019
Merged

Fix/deepsource issues #952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0685d62
fixed classmethod argument PYL-C0202
imkaka Oct 22, 2019
d52c578
fixed unused variable found PYL-W0612
imkaka Oct 22, 2019
dba01d3
silence PYL-W0401
imkaka Oct 22, 2019
607d8aa
silence PYL-W0614
imkaka Oct 22, 2019
5eb8289
fix Loop variable used outside the loop
imkaka Oct 23, 2019
597fb58
fix File opened without the with statement
imkaka Oct 23, 2019
284f89d
silenced iter returns a non-iterator
imkaka Oct 23, 2019
abb1896
Merge branch 'master' into fix/deepsource-issues
imkaka Oct 23, 2019
1dc46d7
resolved all minor issues arised by last fix patch
imkaka Oct 23, 2019
d4756f4
Merge branch 'fix/deepsource-issues' of github.com:imkaka/GitPython i…
imkaka Oct 23, 2019
4dda3cb
silance Re-defined variable from outer scope
imkaka Oct 24, 2019
225529c
silence PYL-W0621
imkaka Oct 24, 2019
9932e64
removed extra line as per code review
imkaka Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixed classmethod argument PYL-C0202
  • Loading branch information
@imkaka
imkaka committed Oct 22, 2019
commit 0685d629f86ef27e4b68947f63cb53f2e750d3a7
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ Contributors are:
-Stefan Stancu <stefan.stancu _at_ gmail.com>
-César Izurieta <cesar _at_ caih.org>
-Arthur Milchior <arthur _at_ milchior.fr>
-Anil Khatri <anil.soccer.khatri _at_ gmail.com>

Portions derived from other open source works and are clearly marked.
2 changes: 1 addition & 1 deletion git/refs/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def message(self):
return self[4]

@classmethod
def new(self, oldhexsha, newhexsha, actor, time, tz_offset, message):
def new(cls, oldhexsha, newhexsha, actor, time, tz_offset, message):
""":return: New instance of a RefLogEntry"""
if not isinstance(actor, Actor):
raise ValueError("Need actor instance, got %s" % actor)
Expand Down