Skip to content

Pin mypy==1.18.2 #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 12 commits into from
Nov 29, 2025
+38 −47
Merged

Pin mypy==1.18.2 #2087

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
497ca40
Pin mypy==1.18.2
George-Ogden Nov 28, 2025
50762f1
Fail remote pipeline when mypy fails
George-Ogden Nov 28, 2025
8469a12
Fix or ignore all mypy errors
George-Ogden Nov 28, 2025
a9756bc
Fix typing so that code can run
George-Ogden Nov 28, 2025
0aba3e7
Stop Lit_commit_ish being imported
George-Ogden Nov 28, 2025
019f270
Set __test__ = False in not tested classes
George-Ogden Nov 28, 2025
ca5a2e8
Add missing parentheses around tuple constructor
George-Ogden Nov 28, 2025
c757908
Install mypy for Python >= 3.9
George-Ogden Nov 28, 2025
9decf74
Skip mypy when Python < 3.9
George-Ogden Nov 28, 2025
a1f094c
Use git.types.Literal instead of typing.Literal
George-Ogden Nov 28, 2025
b5c834a
Remve comment about skipping mypy
George-Ogden Nov 29, 2025
eb15123
Use cast to allow silent getattrs
George-Ogden Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stop Lit_commit_ish being imported
  • Loading branch information
@George-Ogden
George-Ogden committed Nov 28, 2025
commit 0aba3e7bdec7544a86b6e6ba4b0ad8e2ac5cd2c7
6 changes: 3 additions & 3 deletions git/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
Sequence as Sequence,
Tuple,
TYPE_CHECKING,
TypeAlias,
TypeVar,
Union,
)
Expand Down Expand Up @@ -117,7 +116,7 @@
object types.
"""

GitObjectTypeString: TypeAlias = Literal["commit", "tag", "blob", "tree"]
GitObjectTypeString = Literal["commit", "tag", "blob", "tree"]
"""Literal strings identifying git object types and the
:class:`~git.objects.base.Object`-based types that represent them.

Expand All @@ -130,7 +129,8 @@
https://git-scm.com/docs/gitglossary#def_object_type
"""

Lit_commit_ish: TypeAlias = Literal["commit", "tag"]
if TYPE_CHECKING:
Lit_commit_ish = Literal["commit", "tag"]
"""Deprecated. Type of literal strings identifying typically-commitish git object types.

Prior to a bugfix, this type had been defined more broadly. Any usage is in practice
Expand Down