Skip to content

Use actual return type in annotation for method submodule_update #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Oct 21, 2025
+1 −1
Merged

Use actual return type in annotation for method submodule_update #2078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use actual return type in annotation for method submodule_update 
Fixes #2077
  • Loading branch information
@mtdcr
mtdcr committed Oct 21, 2025
commit 9dd0081213d57f41919ed37e93656410277bfb0b
2 changes: 1 addition & 1 deletion git/repo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ def iter_submodules(self, *args: Any, **kwargs: Any) -> Iterator[Submodule]:
"""
return RootModule(self).traverse(*args, **kwargs)

def submodule_update(self, *args: Any, **kwargs: Any) -> Iterator[Submodule]:
def submodule_update(self, *args: Any, **kwargs: Any) -> RootModule:
"""Update the submodules, keeping the repository consistent as it will
take the previous state into consideration.

Expand Down
Loading