rev_parse does not handle <tag>^{commit} correctly #1995
Description
git rev-parse <tag>^{commit} resolves to the commit that the tag points to.
repo.rev_parse("<tag>^{commit}") says ValueError: Could not accommodate requested object type 'commit', got tag
It should instead return TagObject.object (at least if that is a commit object).
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
flichtenheld commentedon Jan 9, 2025
Re-verified that is present in the current release (3.1.44)
flichtenheld commentedon Jan 9, 2025
Interestingly it tries to resolve the tag when you specify
^{blob}although it is not clear to me when this would ever work given thatTagObject.objectis usually a commit.flichtenheld commentedon Jan 9, 2025
Found from the test suite that
<tag>^{}works. So this a usable work-around. Will prepare a patch anyway.Repo.rev_parse: Handle <tag>^{commit} correctly
Byron commentedon Jan 10, 2025
Thanks a lot for digging into this!
I may also add that this implementation is definitely not according to 'spec' and probably just superficially resembles
git rev-parsesemantics.Probably it's just good enough for the common cases, which is a reason for issues around it being quite rare overall.