increase mypy strictness (warn unused ignored)

Author: Yobmod

git/cmd.py

@@ -164,7 +164,7 @@ def dict_to_slots_and__excluded_are_none(self: object, d: Mapping[str, Any], exc
 
 ## CREATE_NEW_PROCESS_GROUP is needed to allow killing it afterwards,
 # see https://docs.python.org/3/library/subprocess.html#subprocess.Popen.send_signal
-PROC_CREATIONFLAGS = (CREATE_NO_WINDOW | subprocess.CREATE_NEW_PROCESS_GROUP  # type: ignore[attr-defined]
+PROC_CREATIONFLAGS = (CREATE_NO_WINDOW | subprocess.CREATE_NEW_PROCESS_GROUP
                       if is_win else 0)
 
 

git/config.py

@@ -44,10 +44,10 @@
 
 if sys.version_info[:3] < (3, 7, 2):
     # typing.Ordereddict not added until py 3.7.2
-    from collections import OrderedDict     # type: ignore  # until 3.6 dropped
-    OrderedDict_OMD = OrderedDict           # type: ignore  # until 3.6 dropped
+    from collections import OrderedDict
+    OrderedDict_OMD = OrderedDict
 else:
-    from typing import OrderedDict                   # type: ignore  # until 3.6 dropped
+    from typing import OrderedDict
     OrderedDict_OMD = OrderedDict[str, List[T_OMD_value]]  # type: ignore[assignment, misc]
 
 # -------------------------------------------------------------
@@ -177,7 +177,7 @@ def __exit__(self, exception_type: str, exception_value: str, traceback: str) ->
 class _OMD(OrderedDict_OMD):
     """Ordered multi-dict."""
 
-    def __setitem__(self, key: str, value: _T) -> None:  # type: ignore[override]
+    def __setitem__(self, key: str, value: _T) -> None:
         super(_OMD, self).__setitem__(key, [value])
 
     def add(self, key: str, value: Any) -> None:
@@ -203,8 +203,8 @@ def setlast(self, key: str, value: Any) -> None:
         prior = super(_OMD, self).__getitem__(key)
         prior[-1] = value
 
-    def get(self, key: str, default: Union[_T, None] = None) -> Union[_T, None]:  # type: ignore
-        return super(_OMD, self).get(key, [default])[-1]          # type: ignore
+    def get(self, key: str, default: Union[_T, None] = None) -> Union[_T, None]:
+        return super(_OMD, self).get(key, [default])[-1]
 
     def getall(self, key: str) -> List[_T]:
         return super(_OMD, self).__getitem__(key)
@@ -299,9 +299,9 @@ def __init__(self, file_or_files: Union[None, PathLike, 'BytesIO', Sequence[Unio
         :param repo: Reference to repository to use if [includeIf] sections are found in configuration files.
 
         """
-        cp.RawConfigParser.__init__(self, dict_type=_OMD)  # type: ignore[arg-type]
+        cp.RawConfigParser.__init__(self, dict_type=_OMD)
         self._dict: Callable[..., _OMD]  # type: ignore[assignment]   # mypy/typeshed bug
-        self._defaults: _OMD              # type: ignore[assignment]  # mypy/typeshed bug
+        self._defaults: _OMD
         self._sections: _OMD              # type: ignore[assignment]  # mypy/typeshed bug
 
         # Used in python 3, needs to stay in sync with sections for underlying implementation to work

git/objects/util.py

@@ -346,7 +346,7 @@ def _list_traverse(self, as_edge: bool = False, *args: Any, **kwargs: Any
 
         if not as_edge:
             out: IterableList[Union['Commit', 'Submodule', 'Tree', 'Blob']] = IterableList(id)
-            out.extend(self.traverse(as_edge=as_edge, *args, **kwargs))  # type: ignore
+            out.extend(self.traverse(as_edge=as_edge, *args, **kwargs))
             return out
             # overloads in subclasses (mypy does't allow typing self: subclass)
             # Union[IterableList['Commit'], IterableList['Submodule'], IterableList[Union['Submodule', 'Tree', 'Blob']]]

git/util.py

@@ -403,8 +403,8 @@ def expand_path(p: Union[None, PathLike], expand_vars: bool = True) -> Optional[
     try:
         p = osp.expanduser(p)  # type: ignore
         if expand_vars:
-            p = osp.expandvars(p)    # type: ignore
-        return osp.normpath(osp.abspath(p))    # type: ignore
+            p = osp.expandvars(p)
+        return osp.normpath(osp.abspath(p))
     except Exception:
         return None
 

pyproject.toml

@@ -22,7 +22,8 @@ filterwarnings = 'ignore::DeprecationWarning'
 disallow_untyped_defs = true
 no_implicit_optional = true
 warn_redundant_casts = true
-# warn_unused_ignores = True
+implicit_reexport = true
+warn_unused_ignores = true
 # warn_unreachable = True
 show_error_codes = true