Skip to content

Commit a6ae1f4

Browse files
committed
Add Rubocop to Travis build
Now that the repo has no Rubocop warnings, we can ensure that no more warnings sneak in by running Rubocop in Travis. In the process, we pin the version of Rubocop used to 0.24.1, the latest current version at the time of writing. This will prevent the build from suddenly failing when a new version of the `rubocop` gem is released. Change-Id: I831a5f576fa5b89194fcfd054ab8cebebc26fb3f Reviewed-on: http://gerrit.causes.com/40460 Tested-by: jenkins <jenkins@causes.com> Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
1 parent 453a32c commit a6ae1f4

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.travis.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,6 @@ rvm:
88
before_script:
99
- git config --global user.email "travis@ci.com"
1010
- git config --global user.name "Travis CI"
11-
script: bundle exec rspec
11+
script:
12+
- bundle exec rspec
13+
- bundle exec rubocop

overcommit.gemspec

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
2929
s.add_dependency 'childprocess', '>= 0.5.1'
3030
s.add_dependency 'json', '>= 1.8' # For 1.8.7. support only
3131

32-
s.add_development_dependency 'rspec', '~> 3.0'
3332
s.add_development_dependency 'image_optim', '~> 0.13.0'
33+
s.add_development_dependency 'rspec', '~> 3.0'
34+
s.add_development_dependency 'rubocop', '0.24.1' # Pin for Travis builds
3435
end

0 commit comments

Comments
 (0)