Modify TextWidth error messages to show only one issue

Previously we were showing both ends of the range of widths. This is
usually unnecessary information. Let's show one or the other, based on
which threshold was surpassed.

Author: sds

lib/overcommit/hook/commit_msg/text_width.rb

@@ -21,11 +21,17 @@ def find_errors_in_subject(subject)
       max_subject_width =
         config['max_subject_width'] +
         special_prefix_length(subject)
-      min_subject_width = config['min_subject_width']
-      return unless subject.length > max_subject_width || subject.length < min_subject_width
 
-      @errors << "Please keep the subject <= #{max_subject_width} and >= " \
-                 "#{min_subject_width} characters"
+      if subject.length > max_subject_width
+        @errors << "Commit message subject must be <= #{max_subject_width} characters"
+        return
+      end
+
+      min_subject_width = config['min_subject_width']
+      if subject.length < min_subject_width
+        @errors << "Commit message subject must be >= #{min_subject_width} characters"
+        return
+      end
     end
 
     def find_errors_in_body(lines)

spec/overcommit/hook/commit_msg/text_width_spec.rb

@@ -90,7 +90,7 @@
       A message line that is way too long. A message line that is way too long.
     MSG
 
-    it { should warn /keep.*subject <= 60.*\n.*line 3.*> 72.*/im }
+    it { should warn /subject.*<= 60.*\n.*line 3.*> 72.*/im }
   end
 
   context 'when custom lengths are specified' do
@@ -109,13 +109,13 @@
     context 'when subject is longer than 70 characters' do
       let(:commit_msg) { 'A' * 71 }
 
-      it { should warn /subject/ }
+      it { should warn /subject must be <= 70/ }
     end
 
     context 'when subject is less than 4 characters' do
       let(:commit_msg) { 'A' * 3 }
 
-      it { should warn /subject/ }
+      it { should warn /subject must be >= 4/ }
     end
 
     context 'when subject is 70 characters or fewer' do
@@ -153,7 +153,7 @@
         This line is longer than #{'A' * 80} characters.
       MSG
 
-      it { should warn /keep.*subject <= 70.*\n.*line 3.*> 80.*/im }
+      it { should warn /subject.*<= 70.*\n.*line 3.*> 80/im }
     end
   end
 end