diff --git a/ruby/ql/lib/change-notes/2022-10-26-case-expression-barrier-guard.md b/ruby/ql/lib/change-notes/2022-10-26-case-expression-barrier-guard.md new file mode 100644 index 000000000000..6f3df870eed6 --- /dev/null +++ b/ruby/ql/lib/change-notes/2022-10-26-case-expression-barrier-guard.md @@ -0,0 +1,4 @@ +--- + category: minorAnalysis +--- + * String literals and arrays of string literals in case expression patterns are now recognised as barrier guards. diff --git a/ruby/ql/lib/codeql/ruby/controlflow/CfgNodes.qll b/ruby/ql/lib/codeql/ruby/controlflow/CfgNodes.qll index f7be488d0fde..c8ca8ff12e62 100644 --- a/ruby/ql/lib/codeql/ruby/controlflow/CfgNodes.qll +++ b/ruby/ql/lib/codeql/ruby/controlflow/CfgNodes.qll @@ -234,7 +234,7 @@ module ExprNodes { override predicate relevantChild(AstNode n) { none() } } - /** A control-flow node that wraps an `ArrayLiteral` AST expression. */ + /** A control-flow node that wraps a `Literal` AST expression. */ class LiteralCfgNode extends ExprCfgNode { override string getAPrimaryQlClass() { result = "LiteralCfgNode" } @@ -432,8 +432,36 @@ module ExprNodes { final ExprCfgNode getBody() { e.hasCfgChild(e.getBody(), this, result) } } - private class WhenClauseChildMapping extends NonExprChildMapping, WhenClause { - override predicate relevantChild(AstNode e) { e = [this.getBody(), this.getAPattern()] } + // `when` clauses need special treatment, since they are neither pre-order + // nor post-order + private class WhenClauseChildMapping extends WhenClause { + predicate patternReachesBasicBlock(int i, CfgNode cfnPattern, BasicBlock bb) { + exists(Expr pattern | + pattern = this.getPattern(i) and + cfnPattern.getNode() = pattern and + bb.getANode() = cfnPattern + ) + or + exists(BasicBlock mid | + this.patternReachesBasicBlock(i, cfnPattern, mid) and + bb = mid.getASuccessor() and + not mid.getANode().getNode() = this + ) + } + + predicate bodyReachesBasicBlock(CfgNode cfnBody, BasicBlock bb) { + exists(Stmt body | + body = this.getBody() and + cfnBody.getNode() = body and + bb.getANode() = cfnBody + ) + or + exists(BasicBlock mid | + this.bodyReachesBasicBlock(cfnBody, mid) and + bb = mid.getAPredecessor() and + not mid.getANode().getNode() = this + ) + } } /** A control-flow node that wraps a `WhenClause` AST expression. */ @@ -443,10 +471,16 @@ module ExprNodes { override WhenClauseChildMapping e; /** Gets the body of this `when`-clause. */ - final ExprCfgNode getBody() { e.hasCfgChild(e.getBody(), this, result) } + final ExprCfgNode getBody() { + result.getNode() = desugar(e.getBody()) and + e.bodyReachesBasicBlock(result, this.getBasicBlock()) + } /** Gets the `i`th pattern this `when`-clause. */ - final ExprCfgNode getPattern(int i) { e.hasCfgChild(e.getPattern(i), this, result) } + final ExprCfgNode getPattern(int i) { + result.getNode() = desugar(e.getPattern(i)) and + e.patternReachesBasicBlock(i, result, this.getBasicBlock()) + } } /** A control-flow node that wraps a `CasePattern`. */ @@ -866,6 +900,19 @@ module ExprNodes { final override RelationalOperation getExpr() { result = super.getExpr() } } + private class SplatExprChildMapping extends OperationExprChildMapping, SplatExpr { + override predicate relevantChild(AstNode n) { n = this.getOperand() } + } + + /** A control-flow node that wraps a `SplatExpr` AST expression. */ + class SplatExprCfgNode extends UnaryOperationCfgNode { + override string getAPrimaryQlClass() { result = "SplatExprCfgNode" } + + override SplatExprChildMapping e; + + final override SplatExpr getExpr() { result = super.getExpr() } + } + /** A control-flow node that wraps an `ElementReference` AST expression. */ class ElementReferenceCfgNode extends MethodCallCfgNode { override string getAPrimaryQlClass() { result = "ElementReferenceCfgNode" } diff --git a/ruby/ql/lib/codeql/ruby/controlflow/internal/Completion.qll b/ruby/ql/lib/codeql/ruby/controlflow/internal/Completion.qll index fe4cca24d690..26e62e0c0774 100644 --- a/ruby/ql/lib/codeql/ruby/controlflow/internal/Completion.qll +++ b/ruby/ql/lib/codeql/ruby/controlflow/internal/Completion.qll @@ -211,8 +211,11 @@ private predicate inBooleanContext(AstNode n) { or exists(CaseExpr c, WhenClause w | not exists(c.getValue()) and - c.getABranch() = w and + c.getABranch() = w + | w.getPattern(_) = n + or + w = n ) } @@ -233,8 +236,11 @@ private predicate inMatchingContext(AstNode n) { or exists(CaseExpr c, WhenClause w | exists(c.getValue()) and - c.getABranch() = w and + c.getABranch() = w + | w.getPattern(_) = n + or + w = n ) or n instanceof CasePattern diff --git a/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImpl.qll b/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImpl.qll index bdd67d2a693f..ba77d6beaba2 100644 --- a/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImpl.qll +++ b/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImpl.qll @@ -400,8 +400,9 @@ module Trees { c instanceof SimpleCompletion or exists(int i, WhenTree branch | branch = this.getBranch(i) | - last(branch.getLastPattern(), pred, c) and + pred = branch and first(this.getBranch(i + 1), succ) and + c.isValidFor(branch) and c.(ConditionalCompletion).getValue() = false ) or @@ -1397,8 +1398,10 @@ module Trees { final override ControlFlowTree getChildElement(int i) { result = this.getMethodName(i) } } - private class WhenTree extends PreOrderTree, WhenClause { - final override predicate propagatesAbnormal(AstNode child) { child = this.getAPattern() } + private class WhenTree extends ControlFlowTree, WhenClause { + final override predicate propagatesAbnormal(AstNode child) { + child = [this.getAPattern(), this.getBody()] + } final Expr getLastPattern() { exists(int i | @@ -1407,8 +1410,11 @@ module Trees { ) } + final override predicate first(AstNode first) { first(this.getPattern(0), first) } + final override predicate last(AstNode last, Completion c) { - last(this.getLastPattern(), last, c) and + last = this and + c.isValidFor(this) and c.(ConditionalCompletion).getValue() = false or last(this.getBody(), last, c) @@ -1416,8 +1422,9 @@ module Trees { final override predicate succ(AstNode pred, AstNode succ, Completion c) { pred = this and - first(this.getPattern(0), succ) and - c instanceof SimpleCompletion + c.isValidFor(this) and + c.(ConditionalCompletion).getValue() = true and + first(this.getBody(), succ) or exists(int i, Expr p, boolean b | p = this.getPattern(i) and @@ -1425,10 +1432,13 @@ module Trees { b = c.(ConditionalCompletion).getValue() | b = true and - first(this.getBody(), succ) + succ = this or b = false and first(this.getPattern(i + 1), succ) + or + not exists(this.getPattern(i + 1)) and + succ = this ) } } diff --git a/ruby/ql/lib/codeql/ruby/controlflow/internal/Splitting.qll b/ruby/ql/lib/codeql/ruby/controlflow/internal/Splitting.qll index 9581b45a95e1..a048e2d4044b 100644 --- a/ruby/ql/lib/codeql/ruby/controlflow/internal/Splitting.qll +++ b/ruby/ql/lib/codeql/ruby/controlflow/internal/Splitting.qll @@ -86,6 +86,10 @@ private module ConditionalCompletionSplitting { last(succ.(ConditionalExpr).getBranch(_), pred, c) and completion = c ) + or + succ(pred, succ, c) and + succ instanceof WhenClause and + completion = c } override predicate hasEntryScope(CfgScope scope, AstNode succ) { none() } diff --git a/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll b/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll index c22aa4ca1cfd..f586c7d74cc2 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll @@ -7,22 +7,53 @@ private import codeql.ruby.controlflow.CfgNodes private import codeql.ruby.dataflow.SSA private import codeql.ruby.ast.internal.Constant private import codeql.ruby.InclusionTests +private import codeql.ruby.ast.internal.Literal -private predicate stringConstCompare(CfgNodes::ExprCfgNode g, CfgNode e, boolean branch) { +cached +private predicate stringConstCompare(CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch) { exists(CfgNodes::ExprNodes::ComparisonOperationCfgNode c | - c = g and + c = guard and exists(CfgNodes::ExprNodes::StringLiteralCfgNode strLitNode | - c.getExpr() instanceof EqExpr and branch = true + // Only consider strings without any interpolations + not strLitNode.getExpr().getComponent(_) instanceof StringInterpolationComponent and + c.getExpr() instanceof EqExpr and + branch = true or c.getExpr() instanceof CaseEqExpr and branch = true or c.getExpr() instanceof NEExpr and branch = false | - c.getLeftOperand() = strLitNode and c.getRightOperand() = e + c.getLeftOperand() = strLitNode and c.getRightOperand() = testedNode or - c.getLeftOperand() = e and c.getRightOperand() = strLitNode + c.getLeftOperand() = testedNode and c.getRightOperand() = strLitNode ) ) + or + stringConstCaseCompare(guard, testedNode, branch) + or + exists(CfgNodes::ExprNodes::BinaryOperationCfgNode g | + g = guard and + stringConstCompareOr(guard, branch) and + stringConstCompare(g.getLeftOperand(), testedNode, _) + ) +} + +/** + * Holds if `guard` is an `or` expression whose operands are string comparison guards. + * For example: + * + * ```rb + * x == "foo" or x == "bar" + * ``` + */ +private predicate stringConstCompareOr( + CfgNodes::ExprNodes::BinaryOperationCfgNode guard, boolean branch +) { + guard.getExpr() instanceof LogicalOrExpr and + branch = true and + forall(CfgNode innerGuard | innerGuard = guard.getAnOperand() | + stringConstCompare(innerGuard, any(Ssa::Definition def).getARead(), branch) + ) } /** @@ -72,10 +103,13 @@ deprecated class StringConstCompare extends DataFlow::BarrierGuard, } } -private predicate stringConstArrayInclusionCall(CfgNodes::ExprCfgNode g, CfgNode e, boolean branch) { +cached +private predicate stringConstArrayInclusionCall( + CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch +) { exists(InclusionTest t | - t.asExpr() = g and - e = t.getContainedNode().asExpr() and + t.asExpr() = guard and + testedNode = t.getContainedNode().asExpr() and branch = t.getPolarity() | exists(ExprNodes::ArrayLiteralCfgNode arr | @@ -132,3 +166,68 @@ deprecated class StringConstArrayInclusionCall extends DataFlow::BarrierGuard, override predicate checks(CfgNode expr, boolean branch) { expr = checkedNode and branch = true } } + +/** + * A validation of a value by comparing with a constant string via a `case` + * expression. For example: + * + * ```rb + * name = params[:user_name] + * case name + * when "alice" + * User.find_by("username = #{name}") + * when *["bob", "charlie"] + * User.find_by("username = #{name}") + * when "dave", "eve" # this is not yet recognised as a barrier guard + * User.find_by("username = #{name}") + * end + * ``` + */ +private predicate stringConstCaseCompare( + CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch +) { + branch = true and + exists(CfgNodes::ExprNodes::CaseExprCfgNode case | + case.getValue() = testedNode and + ( + guard = + any(CfgNodes::ExprNodes::WhenClauseCfgNode branchNode | + branchNode = case.getBranch(_) and + // For simplicity, consider patterns that contain only string literals or arrays of string literals + forall(ExprCfgNode pattern | pattern = branchNode.getPattern(_) | + // when "foo" + // when "foo", "bar" + pattern instanceof ExprNodes::StringLiteralCfgNode + or + pattern = + any(CfgNodes::ExprNodes::SplatExprCfgNode splat | + // when *["foo", "bar"] + forex(ExprCfgNode elem | + elem = splat.getOperand().(ExprNodes::ArrayLiteralCfgNode).getAnArgument() + | + elem instanceof ExprNodes::StringLiteralCfgNode + ) + or + // when *some_var + // when *SOME_CONST + exists(ExprNodes::ArrayLiteralCfgNode arr | + isArrayConstant(splat.getOperand(), arr) and + forall(ExprCfgNode elem | elem = arr.getAnArgument() | + elem instanceof ExprNodes::StringLiteralCfgNode + ) + ) + ) + ) + ) + or + // in "foo" + exists( + CfgNodes::ExprNodes::InClauseCfgNode branchNode, ExprNodes::StringLiteralCfgNode pattern + | + branchNode = case.getBranch(_) and + pattern = branchNode.getPattern() and + guard = pattern + ) + ) + ) +} diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll index 5a6883a5fe47..543e82ce2999 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll @@ -434,7 +434,7 @@ class ContentSet extends TContentSet { * For example, the guard `g` might be a call `isSafe(x)` and the expression `e` * the argument `x`. */ -signature predicate guardChecksSig(CfgNodes::ExprCfgNode g, CfgNode e, boolean branch); +signature predicate guardChecksSig(CfgNodes::AstCfgNode g, CfgNode e, boolean branch); /** * Provides a set of barrier nodes for a guard that validates an expression. @@ -444,13 +444,13 @@ signature predicate guardChecksSig(CfgNodes::ExprCfgNode g, CfgNode e, boolean b */ module BarrierGuard { pragma[nomagic] - private predicate guardChecksSsaDef(CfgNodes::ExprCfgNode g, boolean branch, Ssa::Definition def) { + private predicate guardChecksSsaDef(CfgNodes::AstCfgNode g, boolean branch, Ssa::Definition def) { guardChecks(g, def.getARead(), branch) } pragma[nomagic] private predicate guardControlsSsaDef( - CfgNodes::ExprCfgNode g, boolean branch, Ssa::Definition def, Node n + CfgNodes::AstCfgNode g, boolean branch, Ssa::Definition def, Node n ) { def.getARead() = n.asExpr() and guardControlsBlock(g, n.asExpr().getBasicBlock(), branch) @@ -458,7 +458,7 @@ module BarrierGuard { /** Gets a node that is safely guarded by the given guard check. */ Node getABarrierNode() { - exists(CfgNodes::ExprCfgNode g, boolean branch, Ssa::Definition def | + exists(CfgNodes::AstCfgNode g, boolean branch, Ssa::Definition def | guardChecksSsaDef(g, branch, def) and guardControlsSsaDef(g, branch, def, result) ) @@ -488,8 +488,8 @@ module BarrierGuard { } /** Holds if the guard `guard` controls block `bb` upon evaluating to `branch`. */ -private predicate guardControlsBlock(CfgNodes::ExprCfgNode guard, BasicBlock bb, boolean branch) { - exists(ConditionBlock conditionBlock, SuccessorTypes::BooleanSuccessor s | +private predicate guardControlsBlock(CfgNodes::AstCfgNode guard, BasicBlock bb, boolean branch) { + exists(ConditionBlock conditionBlock, SuccessorTypes::ConditionalSuccessor s | guard = conditionBlock.getLastNode() and s.getValue() = branch and conditionBlock.controls(bb, s) diff --git a/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSCustomizations.qll b/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSCustomizations.qll index 8c05642fc838..c2f27992ff83 100644 --- a/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSCustomizations.qll +++ b/ruby/ql/lib/codeql/ruby/security/regexp/PolynomialReDoSCustomizations.qll @@ -127,7 +127,7 @@ module PolynomialReDoS { override DataFlow::Node getHighlight() { result = matchNode } } - private predicate lengthGuard(CfgNodes::ExprCfgNode g, CfgNode node, boolean branch) { + private predicate lengthGuard(CfgNodes::AstCfgNode g, CfgNode node, boolean branch) { exists(DataFlow::Node input, DataFlow::CallNode length, DataFlow::ExprNode operand | length.asExpr().getExpr().(Ast::MethodCall).getMethodName() = "length" and length.getReceiver() = input and diff --git a/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected b/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected index 9c26785029ea..9b60a403a301 100644 --- a/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected +++ b/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected @@ -526,17 +526,20 @@ case.rb: #-----| -> exit if_in_case (normal) # 2| call to x1 -#-----| -> when ... +#-----| -> 1 # 2| self #-----| -> call to x1 -# 3| when ... -#-----| -> 1 +# 3| [match] when ... +#-----| match -> self + +# 3| [no-match] when ... +#-----| no-match -> 2 # 3| 1 -#-----| match -> self -#-----| no-match -> when ... +#-----| match -> [match] when ... +#-----| no-match -> [no-match] when ... # 3| then ... #-----| -> case ... @@ -569,12 +572,15 @@ case.rb: # 3| x2 #-----| -> "x2" -# 4| when ... -#-----| -> 2 +# 4| [match] when ... +#-----| match -> self -# 4| 2 +# 4| [no-match] when ... #-----| no-match -> case ... -#-----| match -> self + +# 4| 2 +#-----| match -> [match] when ... +#-----| no-match -> [no-match] when ... # 4| then ... #-----| -> case ... @@ -1826,17 +1832,20 @@ cfg.rb: #-----| -> call to puts # 41| case ... -#-----| -> when ... +#-----| -> b # 41| 10 -#-----| -> when ... - -# 42| when ... #-----| -> 1 -# 42| 1 +# 42| [match] when ... #-----| match -> self -#-----| no-match -> when ... + +# 42| [no-match] when ... +#-----| no-match -> 2 + +# 42| 1 +#-----| match -> [match] when ... +#-----| no-match -> [no-match] when ... # 42| then ... #-----| -> case ... @@ -1853,20 +1862,23 @@ cfg.rb: # 42| one #-----| -> "one" -# 43| when ... -#-----| -> 2 +# 43| [match] when ... +#-----| match -> self + +# 43| [no-match] when ... +#-----| no-match -> self # 43| 2 +#-----| match -> [match] when ... #-----| no-match -> 3 -#-----| match -> self # 43| 3 +#-----| match -> [match] when ... #-----| no-match -> 4 -#-----| match -> self # 43| 4 -#-----| match -> self -#-----| no-match -> self +#-----| match -> [match] when ... +#-----| no-match -> [no-match] when ... # 43| then ... #-----| -> case ... @@ -1901,15 +1913,18 @@ cfg.rb: # 47| case ... #-----| -> chained -# 48| when ... -#-----| -> b +# 48| [false] when ... +#-----| false -> b + +# 48| [true] when ... +#-----| true -> self # 48| b #-----| -> 1 # 48| ... == ... -#-----| true -> self -#-----| false -> when ... +#-----| false -> [false] when ... +#-----| true -> [true] when ... # 48| 1 #-----| -> ... == ... @@ -1929,15 +1944,18 @@ cfg.rb: # 48| one #-----| -> "one" -# 49| when ... -#-----| -> b +# 49| [false] when ... +#-----| false -> case ... + +# 49| [true] when ... +#-----| true -> self # 49| b #-----| -> 0 # 49| ... == ... +#-----| true -> [true] when ... #-----| false -> b -#-----| true -> self # 49| 0 #-----| -> ... == ... @@ -1946,8 +1964,8 @@ cfg.rb: #-----| -> 1 # 49| ... > ... -#-----| false -> case ... -#-----| true -> self +#-----| false -> [false] when ... +#-----| true -> [true] when ... # 49| 1 #-----| -> ... > ... diff --git a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.expected b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.expected index a50542e8df36..c308ce9d8200 100644 --- a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.expected +++ b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.expected @@ -1,4 +1,5 @@ -WARNING: Type BarrierGuard has been deprecated and may be removed in future (barrier-guards.ql:9,3-15) +WARNING: Type BarrierGuard has been deprecated and may be removed in future (barrier-guards.ql:10,3-15) +failures oldStyleBarrierGuards | barrier-guards.rb:3:4:3:15 | ... == ... | barrier-guards.rb:4:5:4:7 | foo | barrier-guards.rb:3:4:3:6 | foo | true | | barrier-guards.rb:9:4:9:24 | call to include? | barrier-guards.rb:10:5:10:7 | foo | barrier-guards.rb:9:21:9:23 | foo | true | @@ -9,6 +10,15 @@ oldStyleBarrierGuards | barrier-guards.rb:43:4:43:15 | ... == ... | barrier-guards.rb:45:9:45:11 | foo | barrier-guards.rb:43:4:43:6 | foo | true | | barrier-guards.rb:70:4:70:21 | call to include? | barrier-guards.rb:71:5:71:7 | foo | barrier-guards.rb:70:18:70:20 | foo | true | | barrier-guards.rb:82:4:82:25 | ... != ... | barrier-guards.rb:83:5:83:7 | foo | barrier-guards.rb:82:15:82:17 | foo | true | +| barrier-guards.rb:207:4:207:15 | ... == ... | barrier-guards.rb:208:5:208:7 | foo | barrier-guards.rb:207:4:207:6 | foo | true | +| barrier-guards.rb:211:10:211:21 | ... == ... | barrier-guards.rb:212:5:212:7 | foo | barrier-guards.rb:211:10:211:12 | foo | true | +| barrier-guards.rb:215:16:215:27 | ... == ... | barrier-guards.rb:216:5:216:7 | foo | barrier-guards.rb:215:16:215:18 | foo | true | +| barrier-guards.rb:219:4:219:15 | ... == ... | barrier-guards.rb:219:21:219:23 | foo | barrier-guards.rb:219:4:219:6 | foo | true | +| barrier-guards.rb:219:4:219:15 | ... == ... | barrier-guards.rb:220:5:220:7 | foo | barrier-guards.rb:219:4:219:6 | foo | true | +| barrier-guards.rb:219:21:219:32 | ... == ... | barrier-guards.rb:220:5:220:7 | foo | barrier-guards.rb:219:21:219:23 | foo | true | +| barrier-guards.rb:232:6:232:17 | ... == ... | barrier-guards.rb:233:5:233:7 | foo | barrier-guards.rb:232:6:232:8 | foo | true | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:237:24:237:26 | foo | barrier-guards.rb:237:6:237:8 | foo | true | +| barrier-guards.rb:268:1:268:12 | ... == ... | barrier-guards.rb:268:17:268:19 | foo | barrier-guards.rb:268:1:268:3 | foo | true | newStyleBarrierGuards | barrier-guards.rb:4:5:4:7 | foo | | barrier-guards.rb:10:5:10:7 | foo | @@ -20,6 +30,26 @@ newStyleBarrierGuards | barrier-guards.rb:71:5:71:7 | foo | | barrier-guards.rb:83:5:83:7 | foo | | barrier-guards.rb:91:5:91:7 | foo | +| barrier-guards.rb:126:5:126:7 | foo | +| barrier-guards.rb:133:5:133:7 | foo | +| barrier-guards.rb:135:5:135:7 | foo | +| barrier-guards.rb:140:5:140:7 | foo | +| barrier-guards.rb:142:5:142:7 | foo | +| barrier-guards.rb:149:5:149:7 | foo | +| barrier-guards.rb:154:5:154:7 | foo | +| barrier-guards.rb:159:5:159:7 | foo | +| barrier-guards.rb:164:5:164:7 | foo | +| barrier-guards.rb:192:5:192:7 | foo | +| barrier-guards.rb:196:5:196:7 | foo | +| barrier-guards.rb:208:5:208:7 | foo | +| barrier-guards.rb:212:5:212:7 | foo | +| barrier-guards.rb:216:5:216:7 | foo | +| barrier-guards.rb:219:21:219:23 | foo | +| barrier-guards.rb:220:5:220:7 | foo | +| barrier-guards.rb:233:5:233:7 | foo | +| barrier-guards.rb:237:24:237:26 | foo | +| barrier-guards.rb:244:5:244:7 | foo | +| barrier-guards.rb:268:17:268:19 | foo | controls | barrier-guards.rb:3:4:3:15 | ... == ... | barrier-guards.rb:4:5:4:7 | foo | true | | barrier-guards.rb:3:4:3:15 | ... == ... | barrier-guards.rb:6:5:6:7 | foo | false | @@ -67,3 +97,228 @@ controls | barrier-guards.rb:118:8:118:8 | call to x | barrier-guards.rb:118:4:118:8 | [true] not ... | false | | barrier-guards.rb:118:8:118:8 | call to x | barrier-guards.rb:119:5:119:7 | foo | false | | barrier-guards.rb:118:8:118:8 | call to x | barrier-guards.rb:121:5:121:8 | bars | true | +| barrier-guards.rb:125:1:126:19 | [match] when ... | barrier-guards.rb:126:5:126:7 | foo | match | +| barrier-guards.rb:125:1:126:19 | [no-match] when ... | barrier-guards.rb:128:5:128:7 | foo | no-match | +| barrier-guards.rb:125:6:125:10 | "foo" | barrier-guards.rb:125:1:126:19 | [match] when ... | match | +| barrier-guards.rb:125:6:125:10 | "foo" | barrier-guards.rb:125:1:126:19 | [no-match] when ... | no-match | +| barrier-guards.rb:125:6:125:10 | "foo" | barrier-guards.rb:126:5:126:7 | foo | match | +| barrier-guards.rb:125:6:125:10 | "foo" | barrier-guards.rb:128:5:128:7 | foo | no-match | +| barrier-guards.rb:132:1:133:19 | [match] when ... | barrier-guards.rb:133:5:133:7 | foo | match | +| barrier-guards.rb:132:1:133:19 | [no-match] when ... | barrier-guards.rb:134:1:135:19 | [match] when ... | no-match | +| barrier-guards.rb:132:1:133:19 | [no-match] when ... | barrier-guards.rb:134:1:135:19 | [no-match] when ... | no-match | +| barrier-guards.rb:132:1:133:19 | [no-match] when ... | barrier-guards.rb:134:7:134:9 | bar | no-match | +| barrier-guards.rb:132:1:133:19 | [no-match] when ... | barrier-guards.rb:135:5:135:7 | foo | no-match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:132:1:133:19 | [match] when ... | match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:132:1:133:19 | [no-match] when ... | no-match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:133:5:133:7 | foo | match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:134:1:135:19 | [match] when ... | no-match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:134:1:135:19 | [no-match] when ... | no-match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:134:7:134:9 | bar | no-match | +| barrier-guards.rb:132:6:132:10 | "foo" | barrier-guards.rb:135:5:135:7 | foo | no-match | +| barrier-guards.rb:134:1:135:19 | [match] when ... | barrier-guards.rb:135:5:135:7 | foo | match | +| barrier-guards.rb:134:6:134:10 | "bar" | barrier-guards.rb:134:1:135:19 | [match] when ... | match | +| barrier-guards.rb:134:6:134:10 | "bar" | barrier-guards.rb:134:1:135:19 | [no-match] when ... | no-match | +| barrier-guards.rb:134:6:134:10 | "bar" | barrier-guards.rb:135:5:135:7 | foo | match | +| barrier-guards.rb:139:1:140:19 | [match] when ... | barrier-guards.rb:140:5:140:7 | foo | match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:141:1:142:19 | [match] when ... | no-match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:141:1:142:19 | [no-match] when ... | no-match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:141:7:141:9 | baz | no-match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:141:14:141:17 | quux | no-match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:142:5:142:7 | foo | no-match | +| barrier-guards.rb:139:1:140:19 | [no-match] when ... | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:139:1:140:19 | [no-match] when ... | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:139:14:139:16 | bar | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:141:1:142:19 | [match] when ... | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:141:1:142:19 | [no-match] when ... | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:141:7:141:9 | baz | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:141:14:141:17 | quux | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:142:5:142:7 | foo | no-match | +| barrier-guards.rb:139:6:139:10 | "foo" | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:139:1:140:19 | [no-match] when ... | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:141:1:142:19 | [match] when ... | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:141:1:142:19 | [no-match] when ... | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:141:7:141:9 | baz | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:141:14:141:17 | quux | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:142:5:142:7 | foo | no-match | +| barrier-guards.rb:139:13:139:17 | "bar" | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:141:1:142:19 | [match] when ... | barrier-guards.rb:142:5:142:7 | foo | match | +| barrier-guards.rb:141:1:142:19 | [no-match] when ... | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:141:6:141:10 | "baz" | barrier-guards.rb:141:1:142:19 | [no-match] when ... | no-match | +| barrier-guards.rb:141:6:141:10 | "baz" | barrier-guards.rb:141:14:141:17 | quux | no-match | +| barrier-guards.rb:141:6:141:10 | "baz" | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:141:13:141:18 | "quux" | barrier-guards.rb:141:1:142:19 | [no-match] when ... | no-match | +| barrier-guards.rb:141:13:141:18 | "quux" | barrier-guards.rb:144:5:144:7 | foo | no-match | +| barrier-guards.rb:148:1:149:19 | [match] when ... | barrier-guards.rb:149:5:149:7 | foo | match | +| barrier-guards.rb:148:6:148:20 | * ... | barrier-guards.rb:148:1:149:19 | [match] when ... | match | +| barrier-guards.rb:148:6:148:20 | * ... | barrier-guards.rb:148:1:149:19 | [no-match] when ... | no-match | +| barrier-guards.rb:148:6:148:20 | * ... | barrier-guards.rb:149:5:149:7 | foo | match | +| barrier-guards.rb:153:1:154:19 | [match] when ... | barrier-guards.rb:154:5:154:7 | foo | match | +| barrier-guards.rb:153:6:153:17 | * ... | barrier-guards.rb:153:1:154:19 | [match] when ... | match | +| barrier-guards.rb:153:6:153:17 | * ... | barrier-guards.rb:153:1:154:19 | [no-match] when ... | no-match | +| barrier-guards.rb:153:6:153:17 | * ... | barrier-guards.rb:154:5:154:7 | foo | match | +| barrier-guards.rb:158:1:159:19 | [match] when ... | barrier-guards.rb:159:5:159:7 | foo | match | +| barrier-guards.rb:158:6:158:9 | * ... | barrier-guards.rb:158:1:159:19 | [match] when ... | match | +| barrier-guards.rb:158:6:158:9 | * ... | barrier-guards.rb:158:1:159:19 | [no-match] when ... | no-match | +| barrier-guards.rb:158:6:158:9 | * ... | barrier-guards.rb:159:5:159:7 | foo | match | +| barrier-guards.rb:163:1:164:19 | [match] when ... | barrier-guards.rb:164:5:164:7 | foo | match | +| barrier-guards.rb:163:6:163:10 | * ... | barrier-guards.rb:163:1:164:19 | [match] when ... | match | +| barrier-guards.rb:163:6:163:10 | * ... | barrier-guards.rb:163:1:164:19 | [no-match] when ... | no-match | +| barrier-guards.rb:163:6:163:10 | * ... | barrier-guards.rb:164:5:164:7 | foo | match | +| barrier-guards.rb:168:1:169:7 | [match] when ... | barrier-guards.rb:169:5:169:7 | foo | match | +| barrier-guards.rb:168:6:168:16 | * ... | barrier-guards.rb:168:1:169:7 | [match] when ... | match | +| barrier-guards.rb:168:6:168:16 | * ... | barrier-guards.rb:168:1:169:7 | [no-match] when ... | no-match | +| barrier-guards.rb:168:6:168:16 | * ... | barrier-guards.rb:169:5:169:7 | foo | match | +| barrier-guards.rb:173:1:174:7 | [match] when ... | barrier-guards.rb:174:5:174:7 | foo | match | +| barrier-guards.rb:173:6:173:10 | "foo" | barrier-guards.rb:173:1:174:7 | [no-match] when ... | no-match | +| barrier-guards.rb:173:6:173:10 | "foo" | barrier-guards.rb:173:13:173:13 | self | no-match | +| barrier-guards.rb:173:13:173:13 | call to x | barrier-guards.rb:173:1:174:7 | [no-match] when ... | no-match | +| barrier-guards.rb:180:1:181:7 | [match] when ... | barrier-guards.rb:181:5:181:7 | foo | match | +| barrier-guards.rb:180:6:180:15 | * ... | barrier-guards.rb:180:1:181:7 | [match] when ... | match | +| barrier-guards.rb:180:6:180:15 | * ... | barrier-guards.rb:180:1:181:7 | [no-match] when ... | no-match | +| barrier-guards.rb:180:6:180:15 | * ... | barrier-guards.rb:181:5:181:7 | foo | match | +| barrier-guards.rb:187:1:188:7 | [match] when ... | barrier-guards.rb:188:5:188:7 | foo | match | +| barrier-guards.rb:187:6:187:15 | * ... | barrier-guards.rb:187:1:188:7 | [match] when ... | match | +| barrier-guards.rb:187:6:187:15 | * ... | barrier-guards.rb:187:1:188:7 | [no-match] when ... | no-match | +| barrier-guards.rb:187:6:187:15 | * ... | barrier-guards.rb:188:5:188:7 | foo | match | +| barrier-guards.rb:191:4:191:15 | ... == ... | barrier-guards.rb:191:4:191:31 | [false] ... or ... | false | +| barrier-guards.rb:191:4:191:15 | ... == ... | barrier-guards.rb:191:20:191:22 | foo | false | +| barrier-guards.rb:191:4:191:31 | [true] ... or ... | barrier-guards.rb:192:5:192:7 | foo | true | +| barrier-guards.rb:191:20:191:31 | ... == ... | barrier-guards.rb:191:4:191:31 | [false] ... or ... | false | +| barrier-guards.rb:195:4:195:15 | ... == ... | barrier-guards.rb:195:4:195:31 | [false] ... or ... | false | +| barrier-guards.rb:195:4:195:15 | ... == ... | barrier-guards.rb:195:4:195:47 | [false] ... or ... | false | +| barrier-guards.rb:195:4:195:15 | ... == ... | barrier-guards.rb:195:20:195:22 | foo | false | +| barrier-guards.rb:195:4:195:15 | ... == ... | barrier-guards.rb:195:36:195:38 | foo | false | +| barrier-guards.rb:195:4:195:31 | [false] ... or ... | barrier-guards.rb:195:4:195:47 | [false] ... or ... | false | +| barrier-guards.rb:195:4:195:31 | [false] ... or ... | barrier-guards.rb:195:36:195:38 | foo | false | +| barrier-guards.rb:195:4:195:47 | [true] ... or ... | barrier-guards.rb:196:5:196:7 | foo | true | +| barrier-guards.rb:195:20:195:31 | ... == ... | barrier-guards.rb:195:4:195:31 | [false] ... or ... | false | +| barrier-guards.rb:195:20:195:31 | ... == ... | barrier-guards.rb:195:4:195:47 | [false] ... or ... | false | +| barrier-guards.rb:195:20:195:31 | ... == ... | barrier-guards.rb:195:36:195:38 | foo | false | +| barrier-guards.rb:195:36:195:47 | ... == ... | barrier-guards.rb:195:4:195:47 | [false] ... or ... | false | +| barrier-guards.rb:199:4:199:15 | ... == ... | barrier-guards.rb:199:4:199:31 | [false] ... or ... | false | +| barrier-guards.rb:199:4:199:15 | ... == ... | barrier-guards.rb:199:4:199:43 | [false] ... or ... | false | +| barrier-guards.rb:199:4:199:15 | ... == ... | barrier-guards.rb:199:20:199:22 | foo | false | +| barrier-guards.rb:199:4:199:15 | ... == ... | barrier-guards.rb:199:36:199:38 | foo | false | +| barrier-guards.rb:199:4:199:31 | [false] ... or ... | barrier-guards.rb:199:4:199:43 | [false] ... or ... | false | +| barrier-guards.rb:199:4:199:31 | [false] ... or ... | barrier-guards.rb:199:36:199:38 | foo | false | +| barrier-guards.rb:199:4:199:43 | [true] ... or ... | barrier-guards.rb:200:5:200:7 | foo | true | +| barrier-guards.rb:199:20:199:31 | ... == ... | barrier-guards.rb:199:4:199:31 | [false] ... or ... | false | +| barrier-guards.rb:199:20:199:31 | ... == ... | barrier-guards.rb:199:4:199:43 | [false] ... or ... | false | +| barrier-guards.rb:199:20:199:31 | ... == ... | barrier-guards.rb:199:36:199:38 | foo | false | +| barrier-guards.rb:199:36:199:43 | ... == ... | barrier-guards.rb:199:4:199:43 | [false] ... or ... | false | +| barrier-guards.rb:203:4:203:15 | ... == ... | barrier-guards.rb:203:4:203:31 | [false] ... or ... | false | +| barrier-guards.rb:203:4:203:15 | ... == ... | barrier-guards.rb:203:4:203:47 | [false] ... or ... | false | +| barrier-guards.rb:203:4:203:15 | ... == ... | barrier-guards.rb:203:20:203:22 | self | false | +| barrier-guards.rb:203:4:203:15 | ... == ... | barrier-guards.rb:203:36:203:38 | foo | false | +| barrier-guards.rb:203:4:203:31 | [false] ... or ... | barrier-guards.rb:203:4:203:47 | [false] ... or ... | false | +| barrier-guards.rb:203:4:203:31 | [false] ... or ... | barrier-guards.rb:203:36:203:38 | foo | false | +| barrier-guards.rb:203:4:203:47 | [true] ... or ... | barrier-guards.rb:204:5:204:7 | foo | true | +| barrier-guards.rb:203:20:203:31 | ... == ... | barrier-guards.rb:203:4:203:31 | [false] ... or ... | false | +| barrier-guards.rb:203:20:203:31 | ... == ... | barrier-guards.rb:203:4:203:47 | [false] ... or ... | false | +| barrier-guards.rb:203:20:203:31 | ... == ... | barrier-guards.rb:203:36:203:38 | foo | false | +| barrier-guards.rb:203:36:203:47 | ... == ... | barrier-guards.rb:203:4:203:47 | [false] ... or ... | false | +| barrier-guards.rb:207:4:207:15 | ... == ... | barrier-guards.rb:207:4:207:21 | [true] ... and ... | true | +| barrier-guards.rb:207:4:207:15 | ... == ... | barrier-guards.rb:207:21:207:21 | self | true | +| barrier-guards.rb:207:4:207:15 | ... == ... | barrier-guards.rb:208:5:208:7 | foo | true | +| barrier-guards.rb:207:4:207:21 | [true] ... and ... | barrier-guards.rb:208:5:208:7 | foo | true | +| barrier-guards.rb:207:21:207:21 | call to x | barrier-guards.rb:207:4:207:21 | [true] ... and ... | true | +| barrier-guards.rb:207:21:207:21 | call to x | barrier-guards.rb:208:5:208:7 | foo | true | +| barrier-guards.rb:211:4:211:4 | call to x | barrier-guards.rb:211:4:211:21 | [true] ... and ... | true | +| barrier-guards.rb:211:4:211:4 | call to x | barrier-guards.rb:211:10:211:12 | foo | true | +| barrier-guards.rb:211:4:211:4 | call to x | barrier-guards.rb:212:5:212:7 | foo | true | +| barrier-guards.rb:211:4:211:21 | [true] ... and ... | barrier-guards.rb:212:5:212:7 | foo | true | +| barrier-guards.rb:211:10:211:21 | ... == ... | barrier-guards.rb:211:4:211:21 | [true] ... and ... | true | +| barrier-guards.rb:211:10:211:21 | ... == ... | barrier-guards.rb:212:5:212:7 | foo | true | +| barrier-guards.rb:215:4:215:4 | call to x | barrier-guards.rb:215:4:215:10 | [true] ... and ... | true | +| barrier-guards.rb:215:4:215:4 | call to x | barrier-guards.rb:215:4:215:27 | [true] ... and ... | true | +| barrier-guards.rb:215:4:215:4 | call to x | barrier-guards.rb:215:10:215:10 | self | true | +| barrier-guards.rb:215:4:215:4 | call to x | barrier-guards.rb:215:16:215:18 | foo | true | +| barrier-guards.rb:215:4:215:4 | call to x | barrier-guards.rb:216:5:216:7 | foo | true | +| barrier-guards.rb:215:4:215:10 | [true] ... and ... | barrier-guards.rb:215:4:215:27 | [true] ... and ... | true | +| barrier-guards.rb:215:4:215:10 | [true] ... and ... | barrier-guards.rb:215:16:215:18 | foo | true | +| barrier-guards.rb:215:4:215:10 | [true] ... and ... | barrier-guards.rb:216:5:216:7 | foo | true | +| barrier-guards.rb:215:4:215:27 | [true] ... and ... | barrier-guards.rb:216:5:216:7 | foo | true | +| barrier-guards.rb:215:10:215:10 | call to y | barrier-guards.rb:215:4:215:10 | [true] ... and ... | true | +| barrier-guards.rb:215:10:215:10 | call to y | barrier-guards.rb:215:4:215:27 | [true] ... and ... | true | +| barrier-guards.rb:215:10:215:10 | call to y | barrier-guards.rb:215:16:215:18 | foo | true | +| barrier-guards.rb:215:10:215:10 | call to y | barrier-guards.rb:216:5:216:7 | foo | true | +| barrier-guards.rb:215:16:215:27 | ... == ... | barrier-guards.rb:215:4:215:27 | [true] ... and ... | true | +| barrier-guards.rb:215:16:215:27 | ... == ... | barrier-guards.rb:216:5:216:7 | foo | true | +| barrier-guards.rb:219:4:219:15 | ... == ... | barrier-guards.rb:219:4:219:32 | [true] ... and ... | true | +| barrier-guards.rb:219:4:219:15 | ... == ... | barrier-guards.rb:219:21:219:23 | foo | true | +| barrier-guards.rb:219:4:219:15 | ... == ... | barrier-guards.rb:220:5:220:7 | foo | true | +| barrier-guards.rb:219:4:219:32 | [true] ... and ... | barrier-guards.rb:220:5:220:7 | foo | true | +| barrier-guards.rb:219:21:219:32 | ... == ... | barrier-guards.rb:219:4:219:32 | [true] ... and ... | true | +| barrier-guards.rb:219:21:219:32 | ... == ... | barrier-guards.rb:220:5:220:7 | foo | true | +| barrier-guards.rb:223:4:223:4 | call to x | barrier-guards.rb:223:4:223:10 | [true] ... and ... | true | +| barrier-guards.rb:223:4:223:4 | call to x | barrier-guards.rb:223:10:223:10 | self | true | +| barrier-guards.rb:223:4:223:4 | call to x | barrier-guards.rb:224:5:224:7 | foo | true | +| barrier-guards.rb:223:4:223:10 | [true] ... and ... | barrier-guards.rb:224:5:224:7 | foo | true | +| barrier-guards.rb:223:10:223:10 | call to y | barrier-guards.rb:223:4:223:10 | [true] ... and ... | true | +| barrier-guards.rb:223:10:223:10 | call to y | barrier-guards.rb:224:5:224:7 | foo | true | +| barrier-guards.rb:227:4:227:15 | ... == ... | barrier-guards.rb:227:4:227:21 | [true] ... and ... | true | +| barrier-guards.rb:227:4:227:15 | ... == ... | barrier-guards.rb:227:21:227:21 | self | true | +| barrier-guards.rb:227:4:227:15 | ... == ... | barrier-guards.rb:228:5:228:7 | self | true | +| barrier-guards.rb:227:4:227:21 | [true] ... and ... | barrier-guards.rb:228:5:228:7 | self | true | +| barrier-guards.rb:227:21:227:21 | call to y | barrier-guards.rb:227:4:227:21 | [true] ... and ... | true | +| barrier-guards.rb:227:21:227:21 | call to y | barrier-guards.rb:228:5:228:7 | self | true | +| barrier-guards.rb:232:1:233:19 | [true] when ... | barrier-guards.rb:233:5:233:7 | foo | true | +| barrier-guards.rb:232:6:232:17 | ... == ... | barrier-guards.rb:232:1:233:19 | [false] when ... | false | +| barrier-guards.rb:232:6:232:17 | ... == ... | barrier-guards.rb:232:1:233:19 | [true] when ... | true | +| barrier-guards.rb:232:6:232:17 | ... == ... | barrier-guards.rb:233:5:233:7 | foo | true | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:238:1:238:26 | [false] when ... | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:238:1:238:26 | [true] when ... | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:238:6:238:8 | self | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:238:24:238:26 | foo | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:239:1:239:22 | [false] when ... | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:239:1:239:22 | [true] when ... | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:239:6:239:8 | foo | false | +| barrier-guards.rb:237:1:237:38 | [false] when ... | barrier-guards.rb:239:20:239:22 | foo | false | +| barrier-guards.rb:237:1:237:38 | [true] when ... | barrier-guards.rb:237:24:237:26 | foo | true | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:237:1:237:38 | [false] when ... | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:237:1:237:38 | [true] when ... | true | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:237:24:237:26 | foo | true | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:238:1:238:26 | [false] when ... | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:238:1:238:26 | [true] when ... | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:238:6:238:8 | self | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:238:24:238:26 | foo | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:239:1:239:22 | [false] when ... | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:239:1:239:22 | [true] when ... | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:239:6:239:8 | foo | false | +| barrier-guards.rb:237:6:237:17 | ... == ... | barrier-guards.rb:239:20:239:22 | foo | false | +| barrier-guards.rb:238:1:238:26 | [false] when ... | barrier-guards.rb:239:1:239:22 | [false] when ... | false | +| barrier-guards.rb:238:1:238:26 | [false] when ... | barrier-guards.rb:239:1:239:22 | [true] when ... | false | +| barrier-guards.rb:238:1:238:26 | [false] when ... | barrier-guards.rb:239:6:239:8 | foo | false | +| barrier-guards.rb:238:1:238:26 | [false] when ... | barrier-guards.rb:239:20:239:22 | foo | false | +| barrier-guards.rb:238:1:238:26 | [true] when ... | barrier-guards.rb:238:24:238:26 | foo | true | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:238:1:238:26 | [false] when ... | false | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:238:1:238:26 | [true] when ... | true | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:238:24:238:26 | foo | true | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:239:1:239:22 | [false] when ... | false | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:239:1:239:22 | [true] when ... | false | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:239:6:239:8 | foo | false | +| barrier-guards.rb:238:6:238:17 | ... == ... | barrier-guards.rb:239:20:239:22 | foo | false | +| barrier-guards.rb:239:1:239:22 | [true] when ... | barrier-guards.rb:239:20:239:22 | foo | true | +| barrier-guards.rb:239:6:239:13 | ... == ... | barrier-guards.rb:239:1:239:22 | [false] when ... | false | +| barrier-guards.rb:239:6:239:13 | ... == ... | barrier-guards.rb:239:1:239:22 | [true] when ... | true | +| barrier-guards.rb:239:6:239:13 | ... == ... | barrier-guards.rb:239:20:239:22 | foo | true | +| barrier-guards.rb:243:4:243:8 | "foo" | barrier-guards.rb:244:5:244:7 | foo | match | +| barrier-guards.rb:243:4:243:8 | "foo" | barrier-guards.rb:245:1:246:7 | in ... then ... | no-match | +| barrier-guards.rb:243:4:243:8 | "foo" | barrier-guards.rb:246:5:246:7 | foo | no-match | +| barrier-guards.rb:245:4:245:4 | x | barrier-guards.rb:246:5:246:7 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:251:5:251:7 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:254:1:256:3 | if ... | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:255:5:255:7 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:259:1:261:3 | if ... | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:260:5:260:7 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:264:1:266:3 | if ... | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:265:5:265:7 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:268:1:268:19 | ... && ... | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:268:17:268:19 | foo | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:269:1:269:19 | ... && ... | match | +| barrier-guards.rb:250:4:250:8 | "foo" | barrier-guards.rb:269:8:269:10 | foo | match | +| barrier-guards.rb:254:4:254:28 | ... == ... | barrier-guards.rb:255:5:255:7 | foo | true | +| barrier-guards.rb:259:4:259:16 | ... == ... | barrier-guards.rb:260:5:260:7 | foo | true | +| barrier-guards.rb:264:4:264:16 | ... == ... | barrier-guards.rb:265:5:265:7 | foo | true | +| barrier-guards.rb:268:1:268:12 | ... == ... | barrier-guards.rb:268:17:268:19 | foo | true | +| barrier-guards.rb:269:1:269:3 | foo | barrier-guards.rb:269:8:269:10 | foo | true | diff --git a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.ql b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.ql index 7998164b6da1..ff2f0bc76f48 100644 --- a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.ql +++ b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.ql @@ -4,6 +4,7 @@ import codeql.ruby.controlflow.CfgNodes import codeql.ruby.controlflow.ControlFlowGraph import codeql.ruby.controlflow.BasicBlocks import codeql.ruby.DataFlow +import TestUtilities.InlineExpectationsTest query predicate oldStyleBarrierGuards( BarrierGuard g, DataFlow::Node guardedNode, ExprCfgNode expr, boolean branch @@ -22,3 +23,19 @@ query predicate controls(CfgNode condition, BasicBlock bb, SuccessorTypes::Condi condition = cb.getLastNode() ) } + +class BarrierGuardTest extends InlineExpectationsTest { + BarrierGuardTest() { this = "BarrierGuardTest" } + + override string getARelevantTag() { result = "guarded" } + + override predicate hasActualResult(Location location, string element, string tag, string value) { + tag = "guarded" and + exists(DataFlow::Node n | + newStyleBarrierGuards(n) and + location = n.getLocation() and + element = n.toString() and + value = "" + ) + } +} diff --git a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.rb b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.rb index 5ead7bc04cf2..1946be362754 100644 --- a/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.rb +++ b/ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.rb @@ -1,13 +1,13 @@ foo = "foo" if foo == "foo" - foo + foo # $ guarded else foo end if ["foo"].include?(foo) - foo + foo # $ guarded else foo end @@ -15,17 +15,17 @@ if foo != "foo" foo else - foo + foo # $ guarded end unless foo == "foo" foo else - foo + foo # $ guarded end unless foo != "foo" - foo + foo # $ guarded else foo end @@ -35,14 +35,14 @@ FOO = ["foo"] if FOO.include?(foo) - foo + foo # $ guarded else foo end if foo == "foo" capture { - foo # guarded + foo # $ guarded } end @@ -68,7 +68,7 @@ bars = NotAnArray.new if foos.include?(foo) - foo + foo # $ guarded else foo end @@ -80,7 +80,7 @@ end if foos.index(foo) != nil - foo + foo # $ guarded else foo end @@ -88,7 +88,7 @@ if foos.index(foo) == nil foo else - foo + foo # $ guarded end bars = ["bar"] @@ -120,3 +120,150 @@ else bars end + +case foo +when "foo" + foo # $ guarded +else + foo +end + +case foo +when "foo" + foo # $ guarded +when "bar" + foo # $ guarded +end + +case foo +when "foo", "bar" + foo # $ guarded +when "baz", "quux" + foo # $ guarded +else + foo +end + +case foo +when *["foo", "bar"] + foo # $ guarded +end + +case foo +when *%w[foo bar] + foo # $ guarded +end + +case foo +when *FOO + foo # $ guarded +end + +case foo +when *foos + foo # $ guarded +end + +case foo +when *["foo", x] # not a guard - includes non-constant element `x` + foo +end + +case foo +when "foo", x # not a guard - includes non-constant element `x` + foo +end + +foo_and_x = ["foo", x] + +case foo +when *foo_and_x # not a guard - includes non-constant element `x` + foo +end + +FOO_AND_X = ["foo", x] + +case foo +when *FOO_AND_X # not a guard - includes non-constant element `x` + foo +end + +if foo == "foo" or foo == "bar" + foo # $ guarded +end + +if foo == "foo" or foo == "bar" or foo == "baz" + foo # $ guarded +end + +if foo == "foo" or foo == "bar" or foo == x + foo +end + +if foo == "foo" or bar == "bar" or foo == "baz" + foo +end + +if foo == "foo" and x + foo # $ guarded +end + +if x and foo == "foo" + foo # $ guarded +end + +if x and y and foo == "foo" + foo # $ guarded +end + +if foo == "foo" and foo == "bar" # $ guarded (second `foo` is guarded by the first comparison) + foo # $ guarded +end + +if x and y + foo +end + +if foo == "foo" and y + bar +end + +case +when foo == "foo" + foo # $ guarded +end + +case +when foo == "foo" then foo # $ guarded +when bar == "bar" then foo +when foo == x then foo +end + +case foo +in "foo" + foo # $ guarded +in x + foo +end + +case bar +in "foo" + foo +end + +if foo == "#{some_method()}" + foo +end + +F = "foo" +if foo == "#{F}" + foo # $ MISSING: guarded +end + +f = "foo" +if foo == "#{f}" + foo # $ MISSING: guarded +end + +foo == "foo" && foo # $ guarded +foo && foo == "foo" \ No newline at end of file diff --git a/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.expected b/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.expected index 1d00f293dfd7..dda603763e20 100644 --- a/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.expected +++ b/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.expected @@ -10,13 +10,15 @@ edges | CommandInjection.rb:6:15:6:26 | ...[...] : | CommandInjection.rb:34:39:34:51 | "grep #{...}" | | CommandInjection.rb:46:15:46:20 | call to params : | CommandInjection.rb:46:15:46:26 | ...[...] : | | CommandInjection.rb:46:15:46:26 | ...[...] : | CommandInjection.rb:50:24:50:36 | "echo #{...}" | -| CommandInjection.rb:64:18:64:23 | number : | CommandInjection.rb:65:14:65:29 | "echo #{...}" | -| CommandInjection.rb:72:23:72:33 | blah_number : | CommandInjection.rb:73:14:73:34 | "echo #{...}" | -| CommandInjection.rb:81:20:81:25 | **args : | CommandInjection.rb:82:22:82:25 | args : | -| CommandInjection.rb:82:22:82:25 | args : | CommandInjection.rb:82:22:82:37 | ...[...] : | -| CommandInjection.rb:82:22:82:37 | ...[...] : | CommandInjection.rb:82:14:82:39 | "echo #{...}" | -| CommandInjection.rb:94:16:94:21 | call to params : | CommandInjection.rb:94:16:94:28 | ...[...] : | -| CommandInjection.rb:94:16:94:28 | ...[...] : | CommandInjection.rb:95:16:95:28 | "cat #{...}" | +| CommandInjection.rb:54:13:54:18 | call to params : | CommandInjection.rb:54:13:54:24 | ...[...] : | +| CommandInjection.rb:54:13:54:24 | ...[...] : | CommandInjection.rb:59:14:59:16 | cmd | +| CommandInjection.rb:73:18:73:23 | number : | CommandInjection.rb:74:14:74:29 | "echo #{...}" | +| CommandInjection.rb:81:23:81:33 | blah_number : | CommandInjection.rb:82:14:82:34 | "echo #{...}" | +| CommandInjection.rb:90:20:90:25 | **args : | CommandInjection.rb:91:22:91:25 | args : | +| CommandInjection.rb:91:22:91:25 | args : | CommandInjection.rb:91:22:91:37 | ...[...] : | +| CommandInjection.rb:91:22:91:37 | ...[...] : | CommandInjection.rb:91:14:91:39 | "echo #{...}" | +| CommandInjection.rb:103:16:103:21 | call to params : | CommandInjection.rb:103:16:103:28 | ...[...] : | +| CommandInjection.rb:103:16:103:28 | ...[...] : | CommandInjection.rb:104:16:104:28 | "cat #{...}" | nodes | CommandInjection.rb:6:15:6:20 | call to params : | semmle.label | call to params : | | CommandInjection.rb:6:15:6:26 | ...[...] : | semmle.label | ...[...] : | @@ -31,17 +33,20 @@ nodes | CommandInjection.rb:46:15:46:20 | call to params : | semmle.label | call to params : | | CommandInjection.rb:46:15:46:26 | ...[...] : | semmle.label | ...[...] : | | CommandInjection.rb:50:24:50:36 | "echo #{...}" | semmle.label | "echo #{...}" | -| CommandInjection.rb:64:18:64:23 | number : | semmle.label | number : | -| CommandInjection.rb:65:14:65:29 | "echo #{...}" | semmle.label | "echo #{...}" | -| CommandInjection.rb:72:23:72:33 | blah_number : | semmle.label | blah_number : | -| CommandInjection.rb:73:14:73:34 | "echo #{...}" | semmle.label | "echo #{...}" | -| CommandInjection.rb:81:20:81:25 | **args : | semmle.label | **args : | -| CommandInjection.rb:82:14:82:39 | "echo #{...}" | semmle.label | "echo #{...}" | -| CommandInjection.rb:82:22:82:25 | args : | semmle.label | args : | -| CommandInjection.rb:82:22:82:37 | ...[...] : | semmle.label | ...[...] : | -| CommandInjection.rb:94:16:94:21 | call to params : | semmle.label | call to params : | -| CommandInjection.rb:94:16:94:28 | ...[...] : | semmle.label | ...[...] : | -| CommandInjection.rb:95:16:95:28 | "cat #{...}" | semmle.label | "cat #{...}" | +| CommandInjection.rb:54:13:54:18 | call to params : | semmle.label | call to params : | +| CommandInjection.rb:54:13:54:24 | ...[...] : | semmle.label | ...[...] : | +| CommandInjection.rb:59:14:59:16 | cmd | semmle.label | cmd | +| CommandInjection.rb:73:18:73:23 | number : | semmle.label | number : | +| CommandInjection.rb:74:14:74:29 | "echo #{...}" | semmle.label | "echo #{...}" | +| CommandInjection.rb:81:23:81:33 | blah_number : | semmle.label | blah_number : | +| CommandInjection.rb:82:14:82:34 | "echo #{...}" | semmle.label | "echo #{...}" | +| CommandInjection.rb:90:20:90:25 | **args : | semmle.label | **args : | +| CommandInjection.rb:91:14:91:39 | "echo #{...}" | semmle.label | "echo #{...}" | +| CommandInjection.rb:91:22:91:25 | args : | semmle.label | args : | +| CommandInjection.rb:91:22:91:37 | ...[...] : | semmle.label | ...[...] : | +| CommandInjection.rb:103:16:103:21 | call to params : | semmle.label | call to params : | +| CommandInjection.rb:103:16:103:28 | ...[...] : | semmle.label | ...[...] : | +| CommandInjection.rb:104:16:104:28 | "cat #{...}" | semmle.label | "cat #{...}" | subpaths #select | CommandInjection.rb:7:10:7:15 | #{...} | CommandInjection.rb:6:15:6:20 | call to params : | CommandInjection.rb:7:10:7:15 | #{...} | This command depends on a $@. | CommandInjection.rb:6:15:6:20 | call to params | user-provided value | @@ -53,7 +58,8 @@ subpaths | CommandInjection.rb:33:24:33:36 | "echo #{...}" | CommandInjection.rb:6:15:6:20 | call to params : | CommandInjection.rb:33:24:33:36 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:6:15:6:20 | call to params | user-provided value | | CommandInjection.rb:34:39:34:51 | "grep #{...}" | CommandInjection.rb:6:15:6:20 | call to params : | CommandInjection.rb:34:39:34:51 | "grep #{...}" | This command depends on a $@. | CommandInjection.rb:6:15:6:20 | call to params | user-provided value | | CommandInjection.rb:50:24:50:36 | "echo #{...}" | CommandInjection.rb:46:15:46:20 | call to params : | CommandInjection.rb:50:24:50:36 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:46:15:46:20 | call to params | user-provided value | -| CommandInjection.rb:65:14:65:29 | "echo #{...}" | CommandInjection.rb:64:18:64:23 | number : | CommandInjection.rb:65:14:65:29 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:64:18:64:23 | number | user-provided value | -| CommandInjection.rb:73:14:73:34 | "echo #{...}" | CommandInjection.rb:72:23:72:33 | blah_number : | CommandInjection.rb:73:14:73:34 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:72:23:72:33 | blah_number | user-provided value | -| CommandInjection.rb:82:14:82:39 | "echo #{...}" | CommandInjection.rb:81:20:81:25 | **args : | CommandInjection.rb:82:14:82:39 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:81:20:81:25 | **args | user-provided value | -| CommandInjection.rb:95:16:95:28 | "cat #{...}" | CommandInjection.rb:94:16:94:21 | call to params : | CommandInjection.rb:95:16:95:28 | "cat #{...}" | This command depends on a $@. | CommandInjection.rb:94:16:94:21 | call to params | user-provided value | +| CommandInjection.rb:59:14:59:16 | cmd | CommandInjection.rb:54:13:54:18 | call to params : | CommandInjection.rb:59:14:59:16 | cmd | This command depends on a $@. | CommandInjection.rb:54:13:54:18 | call to params | user-provided value | +| CommandInjection.rb:74:14:74:29 | "echo #{...}" | CommandInjection.rb:73:18:73:23 | number : | CommandInjection.rb:74:14:74:29 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:73:18:73:23 | number | user-provided value | +| CommandInjection.rb:82:14:82:34 | "echo #{...}" | CommandInjection.rb:81:23:81:33 | blah_number : | CommandInjection.rb:82:14:82:34 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:81:23:81:33 | blah_number | user-provided value | +| CommandInjection.rb:91:14:91:39 | "echo #{...}" | CommandInjection.rb:90:20:90:25 | **args : | CommandInjection.rb:91:14:91:39 | "echo #{...}" | This command depends on a $@. | CommandInjection.rb:90:20:90:25 | **args | user-provided value | +| CommandInjection.rb:104:16:104:28 | "cat #{...}" | CommandInjection.rb:103:16:103:21 | call to params : | CommandInjection.rb:104:16:104:28 | "cat #{...}" | This command depends on a $@. | CommandInjection.rb:103:16:103:21 | call to params | user-provided value | diff --git a/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.rb b/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.rb index 75219e2131c8..4be9c95924a0 100644 --- a/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.rb +++ b/ruby/ql/test/query-tests/security/cwe-078/CommandInjection/CommandInjection.rb @@ -49,6 +49,15 @@ def index end Open3.capture2("echo #{cmd}") end + + def update + cmd = params[:key] + case cmd + when "foo" + system(cmd) + end + system(cmd) + end end module Types