Skip to content

Commit f9ece89

Browse files
committed
Remove clippy.swf and update documentation
The `clippy.swf` Flash program is no longer needed and can be deleted. The configuration property is now incorrectly named, but we keep the name and update the documentation. Maybe it could be completely deleted one day, when the clipboard.js solution is known to work and be universally supported.
1 parent 30bf4f3 commit f9ece89

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

releases.moxie

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,20 @@ r34: {
77
date: ${project.buildDate}
88
note: ''
99
From 1.10.0 on Gitblit requires Java 8 as minimum Java version.
10+
11+
Should you have disabled the Flash-based copy-to-clipboard function because it wasn't working anymore
12+
(web.allowFlashCopyToClipboard = false), you may want to rethink this and enable it again. The configuration
13+
property has the same name, but the mechanism was exchanged. Flash is gone, and a modern JavaScript solution
14+
is now used to copy text directly to the clipboard (via clipboard.js).
1015
''
1116
html: ~
1217
text: ~
1318
security: ~
1419
fixes:
1520
- Fix crash in Gitblit Authority when users were deleted from Gitblit but still had entries (certificates) in the Authority.
1621
changes:
17-
- Minimum Java required increased to Java 8
22+
- Minimum Java required increased to Java 8.
23+
- Replaced the Flash-based approach to copy text to the clipboard with a modern JavaScript solution. (issue-1241)
1824
additions: ~
1925
dependencyChanges:
2026
- update to JavaMail 1.5.6 (pr-1217 by @paladox)
@@ -24,6 +30,7 @@ r34: {
2430
- update to Apache commons-io 2.11.0
2531
- update to Apache commons-compress 1.22
2632
- update to libpam4j 1.11
33+
- added clipboard.js, replacing clippy.swf
2734
contributors:
2835
- paladox
2936
}

src/main/distrib/data/defaults.properties

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1076,7 +1076,11 @@ web.allowForking = true
10761076
# SINCE 1.2.0
10771077
web.shortCommitIdLength = 6
10781078

1079-
# Use Clippy (Flash solution) to provide a copy-to-clipboard button.
1079+
# Use a JavaScript browser API to provide a copy-to-clipboard button.
1080+
# The clipboard.js library is used to copy text directly to the browser's
1081+
# clipboard.
1082+
# (This used to be done with a Flash based solution, but has been replaced
1083+
# with a modern JavaScript approach, since Flash support is dying out.)
10801084
# If false, a button with a more primitive JavaScript-based prompt box will
10811085
# offer a 3-step (click, ctrl+c, enter) copy-to-clipboard alternative.
10821086
#

src/main/resources/clippy.swf

-5.25 KB
Binary file not shown.

0 commit comments

Comments
 (0)