Skip to content

Commit 9ab60cd

Browse files
committed
Added secure server flag for https selenium servers
1 parent 8e4cf02 commit 9ab60cd

File tree

4 files changed

+28
-4
lines changed

4 files changed

+28
-4
lines changed

PHPUnit/Extensions/Selenium2TestCase.php

+21-2
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ public function __construct($name = NULL, array $data = array(), $dataName = '')
256256
'browser' => NULL,
257257
'browserName' => NULL,
258258
'desiredCapabilities' => array(),
259-
'seleniumServerRequestsTimeout' => 60
259+
'seleniumServerRequestsTimeout' => 60,
260+
'secure' => FALSE
260261
);
261262

262263
$this->keysHolder = new PHPUnit_Extensions_Selenium2TestCase_KeysHolder();
@@ -377,7 +378,7 @@ protected function runTest()
377378
} catch (Exception $e) {
378379
$thrownException = $e;
379380
}
380-
381+
381382
if ($this->collectCodeCoverageInformation) {
382383
$this->session->cookie()->remove('PHPUNIT_SELENIUM_TEST_ID');
383384
}
@@ -456,6 +457,24 @@ public function getPort()
456457
return $this->parameters['port'];
457458
}
458459

460+
/**
461+
* @param boolean $secure
462+
* @throws InvalidArgumentException
463+
*/
464+
public function setSecure($secure)
465+
{
466+
if(!is_bool($secure)) {
467+
throw InvalidArgumentHelper::factory(1, 'boolean');
468+
}
469+
470+
$this->parameters['secure'] = $secure;
471+
}
472+
473+
public function getSecure()
474+
{
475+
return $this->parameters['secure'];
476+
}
477+
459478
/**
460479
* @param string $browser
461480
* @throws InvalidArgumentException

PHPUnit/Extensions/Selenium2TestCase/SessionStrategy.php

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ interface PHPUnit_Extensions_Selenium2TestCase_SessionStrategy
5858
/**
5959
* @param array $parameters 'host' => Selenium Server machine
6060
'port' => Selenium Server port
61+
'secure' => Selenium Server secure flag
6162
'browser' => a browser name
6263
* 'browserUrl' => base URL to use during the test
6364
*/

PHPUnit/Extensions/Selenium2TestCase/SessionStrategy/Isolated.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class PHPUnit_Extensions_Selenium2TestCase_SessionStrategy_Isolated
5858
{
5959
public function session(array $parameters)
6060
{
61-
$seleniumServerUrl = PHPUnit_Extensions_Selenium2TestCase_URL::fromHostAndPort($parameters['host'], $parameters['port']);
61+
$seleniumServerUrl = PHPUnit_Extensions_Selenium2TestCase_URL::fromHostAndPort($parameters['host'], $parameters['port'], $parameters['secure']);
6262
$driver = new PHPUnit_Extensions_Selenium2TestCase_Driver($seleniumServerUrl, $parameters['seleniumServerRequestsTimeout']);
6363
$capabilities = array_merge($parameters['desiredCapabilities'],
6464
array(

PHPUnit/Extensions/Selenium2TestCase/URL.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,14 @@ public function __construct($value)
7171
/**
7272
* @param string $host
7373
* @param int port
74+
* @param bool secure
7475
* @return PHPUnit_Extensions_Selenium2TestCase_URL
7576
*/
76-
public static function fromHostAndPort($host, $port)
77+
public static function fromHostAndPort($host, $port, $secure)
7778
{
79+
if($secure) {
80+
return new self("https://{$host}:{$port}");
81+
}
7882
return new self("http://{$host}:{$port}");
7983
}
8084

0 commit comments

Comments
 (0)