From b4201fb4f406fd4531e362d8c4b62aaf594c0ff5 Mon Sep 17 00:00:00 2001 From: Markus Unterwaditzer Date: Thu, 2 Jul 2020 15:14:34 +0200 Subject: [PATCH] fix(sessions): Only crash session if the error is unhandled, not if it is fatal --- sentry_sdk/client.py | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/sentry_sdk/client.py b/sentry_sdk/client.py index 9b0492ac82..0164e8a623 100644 --- a/sentry_sdk/client.py +++ b/sentry_sdk/client.py @@ -267,20 +267,14 @@ def _update_session_from_event( errored = False user_agent = None - # Figure out if this counts as an error and if we should mark the - # session as crashed. - level = event.get("level") - if level == "fatal": - crashed = True - if not crashed: - exceptions = (event.get("exception") or {}).get("values") - if exceptions: - errored = True - for error in exceptions: - mechanism = error.get("mechanism") - if mechanism and mechanism.get("handled") is False: - crashed = True - break + exceptions = (event.get("exception") or {}).get("values") + if exceptions: + errored = True + for error in exceptions: + mechanism = error.get("mechanism") + if mechanism and mechanism.get("handled") is False: + crashed = True + break user = event.get("user")