fix(tracing): Get HTTP headers from span rather than transaction if possible #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Feb 26, 2021
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
Please add a docstring to iter_trace_propagation_headers explaining in which situations one would pass in a span object explicitly.
lobsterkatie
deleted the
kmclb-use-correct-parent-span-for-http-headers
branch
alexmv
added a commit
to CAVaccineInventory/vial
that referenced
this pull request
Mar 5, 2021
Interestingly, sentry has just hit 1.0.0! None of the nominally breaking changes[1] look relevant to our minimal usage: > - Feat: Moved auto_session_tracking experimental flag to a proper > option and removed session_mode, hence enabling release health by > default getsentry/sentry-python#994 > > - Fixed Django transaction name by setting the name to > request.path_info rather than request.path > > - Fix for tracing by getting HTTP headers from span rather than > transaction when possible getsentry/sentry-python#1035 > > - Fix for Flask transactions missing request body in non errored > transactions getsentry/sentry-python#1034 > > - Fix for honoring the X-Forwarded-For header getsentry/sentry-python#1037 > > - Fix for worker that logs data dropping of events with level error > getsentry/sentry-python#1032 [1] https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md
This was referenced Mar 8, 2021
Closed
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are situations in which a trace ends up looking not like this (as it should):
but instead looks like this:
This happens because we currently create the outgoing tracing headers based not on the span representing the outgoing request but on whatever span is on the scope, which is most often the transaction itself. There are situations in which this is necessary (if there is no child span to tie to*), but in situations where it's not, we should be correctly associating child transactions with their parent spans, not their ancestor transactions.
*It's a separate question whether, in the one place there isn't a span (here, the
rqintegration), there should be.