Skip to content

Use new untrack utility function when available #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lms24 opened this issue Dec 19, 2023 · 2 comments
Open

Use new untrack utility function when available #9911

Lms24 opened this issue Dec 19, 2023 · 2 comments
Assignees
Labels
Improvement Package: sveltekit Issues related to the Sentry SvelteKit SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Dec 19, 2023

Currently we rely on a hacky way of accessing certain SvelteKit event properties without triggering a route invalidation in our load wrappers.

SvelteKit 2 introduced the long discussed untrack function which should allow us to access the values in a safe and SvelteKit native way without triggering invalidation.

Since we want to maintain 1.x support, we need to implement this backwards-compatible and still rely on our hacky approach until we drop 1.x sometime in the future.

@Lms24 Lms24 added the Package: sveltekit Issues related to the Sentry SvelteKit SDK label Dec 19, 2023
@Lms24 Lms24 assigned Lms24 and unassigned Lms24 Dec 19, 2023
@AbhiPrasad
Copy link
Member

Is this something we can evaluate for v9?

@Lms24
Copy link
Member Author

Lms24 commented Dec 11, 2024

@AbhiPrasad Yes we should! Since we already discussed dropping SvelteKit 1.x support for v9, we could simply use untrack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Package: sveltekit Issues related to the Sentry SvelteKit SDK
Projects
None yet
Development

No branches or pull requests

6 participants