Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic error handler setup for Fastify v5 #15936

Open
andreiborza opened this issue Mar 31, 2025 · 1 comment
Open

Automatic error handler setup for Fastify v5 #15936

andreiborza opened this issue Mar 31, 2025 · 1 comment
Assignees
Labels
getsentry/sentry-javascript Integration: fastify Issues related to Fastify support for the Sentry Node SDK Task

Comments

@andreiborza
Copy link
Member

Description

Fastify v5 introduced diagnostics channels which we could use for automatic setup of the error and request handlers instead of users having to run setupFastifyErrorHandler manually.

While we cannot yet get rid of the handler for <v5, we could simplify the setup for users on v5.

See tracing:fastify.request.handler:start and tracing:fastify.request.handler:error.

@andreiborza andreiborza added the Integration: fastify Issues related to Fastify support for the Sentry Node SDK label Apr 1, 2025
@mydea
Copy link
Member

mydea commented Apr 1, 2025

We should just make sure that nothing breaks if people on fastify 5 also add the handler manually, to avoid confusion there! But def. a good change to do 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getsentry/sentry-javascript Integration: fastify Issues related to Fastify support for the Sentry Node SDK Task
Projects
None yet
Development

No branches or pull requests

4 participants