Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /trpc/:path for every tRPC procedure #15407

Closed
3 tasks done
divmgl opened this issue Feb 13, 2025 · 4 comments
Closed
3 tasks done

GET /trpc/:path for every tRPC procedure #15407

divmgl opened this issue Feb 13, 2025 · 4 comments
Labels
getsentry/sentry-javascript Package: node Issues related to the Sentry Node SDK Stale

Comments

@divmgl
Copy link

divmgl commented Feb 13, 2025

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.54.0

Framework Version

@trpc/server@10.45.2

Link to Sentry event

https://permitflow.sentry.io/traces/?project=4504595707396096&statsPeriod=1h

Reproduction Example/SDK Setup

Image

Steps to Reproduce

import * as Sentry from "@sentry/node"
import { nodeProfilingIntegration } from "@sentry/profiling-node"

const isProduction = process.env.NODE_ENV === "production"
const dsn = process.env.SENTRY_DSN

Sentry.init({
  environment: isProduction ? "prod" : "dev",
  enabled: isProduction,
  debug: false,
  dsn: dsn,
  integrations: [nodeProfilingIntegration(), Sentry.prismaIntegration()],
  tracesSampleRate: 0.01,
  profilesSampleRate: 1.0, // This is relative to tracesSampleRate
  ignoreErrors: [
    "User does not have permission",
    "User is not a member of this workspace",
    /BAD_REQUEST|TOO_MANY_REQUESTS|UNAUTHORIZED|FORBIDDEN|NOT_FOUND/,
  ],
  // https://github.com/getsentry/sentry-javascript/issues/14846#issuecomment-2619573310
  registerEsmLoaderHooks: {
    onlyIncludeInstrumentedModules: true,
  },
})

Add to a Fastify/tRPC instance.

Expected Result

We can see the procedure names.

Actual Result

GET /trpc/:path

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Feb 13, 2025
@github-actions github-actions bot added the Package: node Issues related to the Sentry Node SDK label Feb 13, 2025
@divmgl divmgl changed the title tRPC procedure names are no longer showing GET /trpc/:path for every tRPC procedure Feb 13, 2025
@divmgl
Copy link
Author

divmgl commented Feb 13, 2025

Now that I'm looking closer at the traces, this is likely happening because we batch our requests. Still, it'd be nice to see the batched URL.

@Lms24
Copy link
Member

Lms24 commented Feb 14, 2025

Hi @divmgl thanks for writing in! just to confirm: are you using our TRCP middleware?

Also cc @lforst, you probably have more context with TRPC

@lforst
Copy link
Member

lforst commented Feb 14, 2025

Expected Result
We can see the procedure names.

It seems to me like you can already successfully do so. Is the search field with a query like *trpc/* insufficient?

@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 3 Mar 3, 2025
@getsantry
Copy link

getsantry bot commented Mar 25, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Mar 25, 2025
@getsantry getsantry bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getsentry/sentry-javascript Package: node Issues related to the Sentry Node SDK Stale
Projects
Archived in project
Development

No branches or pull requests

3 participants