Skip to content

Standalone http.client spans #11562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks done
cleptric opened this issue Apr 11, 2024 · 2 comments
Open
5 tasks done

Standalone http.client spans #11562

cleptric opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
Feature: Tracing Feature Package: browser Issues related to the Sentry Browser SDK

Comments

@cleptric
Copy link
Member

cleptric commented Apr 11, 2024

Many users have been confused and frustrated by the fact that after the automatically created page load transaction is finished, XMLHttpRequest and fetch requests are only automatically instrumented with the user explicitly wrapping these requests in a transaction.

For v8, we want to change this by utilizing single-span ingestion. By default, each request will be traced and sent to Sentry as a segment span (span.isSegment: true,). The user can turn off the behaviour with a new Sentry.browserTracingIntegration() option.

Tasks

Preview Give feedback
  1. Lms24
  2. Lms24
@cleptric cleptric added Type: Feature Package: core Issues related to the Sentry Core SDK Feature: Tracing labels Apr 11, 2024
@Lms24
Copy link
Member

Lms24 commented Apr 18, 2024

http.client spans count as segment spans and they need to have the following properties:

segmentId = spanId
isSegment: true

In contrast, INP spans don't need to set segment properties because we don't care about them not showing up in the trace view.

@Lms24
Copy link
Member

Lms24 commented May 23, 2024

Closing this at the moment as this is officially on hold until further notice. The experimental standalone option still exists but XHR and fetch request spans are still only created if there's a parent segment/root span. The PRs to send standalone fetch and XHR spans were reverted.

@Lms24 Lms24 closed this as completed May 23, 2024
@mydea mydea reopened this Sep 12, 2024
@mydea mydea changed the title [v8] HTTP client spans Standalone http.client spans Sep 12, 2024
@Lms24 Lms24 added Package: browser Issues related to the Sentry Browser SDK and removed Package: core Issues related to the Sentry Core SDK labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Tracing Feature Package: browser Issues related to the Sentry Browser SDK
Projects
None yet
Development

No branches or pull requests

5 participants