Skip to content

Doublecheck GRPC Status to Span Status mapping #11195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lforst opened this issue Mar 19, 2024 · 1 comment
Open

Doublecheck GRPC Status to Span Status mapping #11195

lforst opened this issue Mar 19, 2024 · 1 comment

Comments

@lforst
Copy link
Member

lforst commented Mar 19, 2024

Followup to #11169

In the logic where we set a span status based on HTTP_STATUS_CODE or RPC_GRPC_STATUS code, there are two inconsistencies with the spec (https://opentelemetry.io/docs/specs/semconv/rpc/grpc/):

  • We assume the GRPC status codes are stored as string, while the spec says the GRPC status codes are stored as int.
  • We set the status to ERROR for all of the status codes, while the spec says we should set the status to ERROR or UNSET based on whether the span is a client or a server span.
@AbhiPrasad AbhiPrasad added this to the 8.0.0 milestone Apr 24, 2024
@AbhiPrasad AbhiPrasad modified the milestones: 8.0.0, 9.0.0 Jun 4, 2024
@lforst lforst removed this from the 9.0.0 milestone Nov 8, 2024
@lforst
Copy link
Member Author

lforst commented Nov 8, 2024

Removed from v9 milestone because I don't think this is breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants