Skip to content

Commit a764dac

Browse files
committed
feat: Set synthetic true
Disable default fingerprinting
1 parent 1e7a426 commit a764dac

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

packages/browser/src/backend.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,10 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
9393
event = eventFromPlainObject(objectException, hint.syntheticException);
9494
addExceptionTypeValue(event, 'Custom Object', undefined, {
9595
handled: true,
96-
synthetic: false, // TODO: Make true
96+
synthetic: true,
9797
type: 'generic',
9898
});
99+
event.level = Severity.Error;
99100
return SyncPromise.resolve(this._buildEvent(event, hint));
100101
}
101102

@@ -109,9 +110,10 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
109110
return this.eventFromMessage(stringException, undefined, hint).then(messageEvent => {
110111
addExceptionTypeValue(messageEvent, `${stringException}`, undefined, {
111112
handled: true,
112-
synthetic: false, // TODO: Make true
113+
synthetic: true,
113114
type: 'generic',
114115
});
116+
messageEvent.level = Severity.Error;
115117
return SyncPromise.resolve(this._buildEvent(messageEvent, hint));
116118
});
117119
}

packages/hub/src/scope.ts

-3
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,6 @@ export class Scope implements ScopeInterface {
236236
// If we have something on the scope, then merge it with event
237237
if (this._fingerprint) {
238238
event.fingerprint = event.fingerprint.concat(this._fingerprint);
239-
} else if (event.message) {
240-
// If not, but we have message, use it instead
241-
event.fingerprint = event.fingerprint.concat(event.message);
242239
}
243240

244241
// If we have no data at all, remove empty array default

packages/node/src/backend.ts

+1-7
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { addExceptionTypeValue } from '@sentry/utils/misc';
55
import { normalizeToSize } from '@sentry/utils/object';
66
import { keysToEventMessage } from '@sentry/utils/string';
77
import { SyncPromise } from '@sentry/utils/syncpromise';
8-
import { createHash } from 'crypto';
98
import { extractStackFromError, parseError, parseStack, prepareFramesForEvent } from './parsers';
109
import { HTTPSTransport, HTTPTransport } from './transports';
1110

@@ -90,11 +89,6 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
9089

9190
getCurrentHub().configureScope(scope => {
9291
scope.setExtra('__serialized__', normalizeToSize(exception as {}));
93-
scope.setFingerprint([
94-
createHash('md5')
95-
.update(keys.join(''))
96-
.digest('hex'),
97-
]);
9892
});
9993

10094
ex = (hint && hint.syntheticException) || new Error(message);
@@ -104,7 +98,7 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
10498
// We use synthesized Error here so we can extract a (rough) stack trace.
10599
ex = (hint && hint.syntheticException) || new Error(exception as string);
106100
}
107-
mechanism.synthetic = false; // TODO: Make true
101+
mechanism.synthetic = true;
108102
}
109103

110104
return new SyncPromise<Event>(resolve =>

0 commit comments

Comments
 (0)