File tree 1 file changed +2
-6
lines changed
1 file changed +2
-6
lines changed Original file line number Diff line number Diff line change 2
2
3
3
Make sure to open PRs against ` develop ` branch.
4
4
5
- For feedback in PRs, we use the [ LOGAF scale] ( https://blog.danlew.net/2020/04/15/the-logaf-scale/ ) to specify how
6
- important a comment is:
7
-
8
- - ` l ` : low - nitpick. You may address this comment, but you don't have to.
9
- - ` m ` : medium - normal comment. Worth addressing and fixing.
10
- - ` h ` : high - Very important. We must not merge this PR without addressing this issue.
5
+ For feedback in PRs, we use the [ LOGAF scale] ( https://develop.sentry.dev/engineering-practices/code-review/#logaf-scale ) to specify how
6
+ important a comment is.
11
7
12
8
You only need one approval from a maintainer to be able to merge. For some PRs, asking specific or multiple people for
13
9
review might be adequate. You can either assign SDK team members directly (e.g. if you have some people in mind who are
You can’t perform that action at this time.
0 commit comments