Skip to content

Commit ebf65d4

Browse files
author
Yuanfang Chen
committed
[Verifier] Make error message precise about which variable is being diagnosed.
NFCI.
1 parent fd65d39 commit ebf65d4

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

llvm/lib/IR/Verifier.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -735,8 +735,9 @@ void Verifier::visitGlobalVariable(const GlobalVariable &GV) {
735735
Value *V = Op->stripPointerCasts();
736736
Assert(isa<GlobalVariable>(V) || isa<Function>(V) ||
737737
isa<GlobalAlias>(V),
738-
"invalid llvm.used member", V);
739-
Assert(V->hasName(), "members of llvm.used must be named", V);
738+
Twine("invalid ") + GV.getName() + " member", V);
739+
Assert(V->hasName(),
740+
Twine("members of ") + GV.getName() + " must be named", V);
740741
}
741742
}
742743
}

llvm/test/Verifier/llvm.used-invalid-init2.ll

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
@a = global i8 42
44
@llvm.used = appending global [2 x i8*] [i8* @a, i8* null], section "llvm.metadata"
5+
@llvm.compiler.used = appending global [2 x i8*] [i8* @a, i8* null], section "llvm.metadata"
56

67
; CHECK: invalid llvm.used member
78
; CHECK-NEXT: i8* null
9+
10+
; CHECK: invalid llvm.compiler.used member
11+
; CHECK-NEXT: i8* null

0 commit comments

Comments
 (0)