Skip to content

Commit e88a396

Browse files
author
Chris Bieneman
committed
Raising minimum required CMake version to 2.8.12.2.
llvm-svn: 230062
1 parent 68a7dbf commit e88a396

File tree

5 files changed

+8
-18
lines changed

5 files changed

+8
-18
lines changed

llvm/CMakeLists.txt

+3-13
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,14 @@
11
# See docs/CMake.html for instructions about how to build LLVM with CMake.
22

3-
cmake_minimum_required(VERSION 2.8.8)
3+
cmake_minimum_required(VERSION 2.8.12.2)
44

55
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
66
message(STATUS "No build type selected, default to Debug")
77
set(CMAKE_BUILD_TYPE "Debug")
88
endif()
99

10-
# FIXME: It may be removed when we use 2.8.12.
11-
if(CMAKE_VERSION VERSION_LESS 2.8.12)
12-
# Invalidate a couple of keywords.
13-
set(cmake_2_8_12_INTERFACE)
14-
set(cmake_2_8_12_PRIVATE)
15-
else()
16-
# Use ${cmake_2_8_12_KEYWORD} intead of KEYWORD in target_link_libraries().
17-
set(cmake_2_8_12_INTERFACE INTERFACE)
18-
set(cmake_2_8_12_PRIVATE PRIVATE)
19-
if(POLICY CMP0022)
20-
cmake_policy(SET CMP0022 NEW) # automatic when 2.8.12 is required
21-
endif()
10+
if(POLICY CMP0022)
11+
cmake_policy(SET CMP0022 NEW) # automatic when 2.8.12 is required
2212
endif()
2313

2414
if(CMAKE_VERSION VERSION_LESS 3.1.20141117)

llvm/cmake/modules/LLVM-Config.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ function(explicit_llvm_config executable)
4141
llvm_map_components_to_libnames(LIBRARIES ${link_components})
4242
get_target_property(t ${executable} TYPE)
4343
if("x${t}" STREQUAL "xSTATIC_LIBRARY")
44-
target_link_libraries(${executable} ${cmake_2_8_12_INTERFACE} ${LIBRARIES})
44+
target_link_libraries(${executable} INTERFACE ${LIBRARIES})
4545
elseif("x${t}" STREQUAL "xSHARED_LIBRARY" OR "x${t}" STREQUAL "xMODULE_LIBRARY")
46-
target_link_libraries(${executable} ${cmake_2_8_12_PRIVATE} ${LIBRARIES})
46+
target_link_libraries(${executable} PRIVATE ${LIBRARIES})
4747
else()
4848
# Use plain form for legacy user.
4949
target_link_libraries(${executable} ${LIBRARIES})

llvm/lib/DebugInfo/PDB/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,4 +72,4 @@ add_llvm_library(LLVMDebugInfoPDB
7272
${LIBPDB_ADDITIONAL_HEADER_DIRS}
7373
)
7474

75-
target_link_libraries(LLVMDebugInfoPDB ${cmake_2_8_12_INTERFACE} "${LIBPDB_ADDITIONAL_LIBRARIES}")
75+
target_link_libraries(LLVMDebugInfoPDB INTERFACE "${LIBPDB_ADDITIONAL_LIBRARIES}")

llvm/lib/ExecutionEngine/Interpreter/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ add_llvm_library(LLVMInterpreter
1313
)
1414

1515
if( LLVM_ENABLE_FFI )
16-
target_link_libraries( LLVMInterpreter ${cmake_2_8_12_PRIVATE} ${FFI_LIBRARY_PATH} )
16+
target_link_libraries( LLVMInterpreter PRIVATE ${FFI_LIBRARY_PATH} )
1717
endif()
1818

1919
add_dependencies(LLVMInterpreter intrinsics_gen)

llvm/tools/llvm-shlib/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") # FIXME: It should be "GNU ld for el
9090
set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
9191
endif()
9292

93-
target_link_libraries(LLVM ${cmake_2_8_12_PRIVATE} ${LIB_NAMES})
93+
target_link_libraries(LLVM PRIVATE ${LIB_NAMES})
9494

9595
add_dependencies(LLVM libLLVMExports)
9696

0 commit comments

Comments
 (0)