Skip to content

Commit e32936a

Browse files
committed
[MSVC] Silence -Wnon-virtual-dtor on DIA APIs
Differential Revision: https://reviews.llvm.org/D116313
1 parent a3ab2c9 commit e32936a

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

clang/lib/Driver/ToolChains/MSVCSetupApi.h

+9
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@
2828

2929
#pragma once
3030

31+
#ifdef __clang__
32+
#pragma clang diagnostic push
33+
#pragma clang diagnostic ignored "-Wnon-virtual-dtor"
34+
#endif
35+
3136
// Constants
3237
//
3338
#ifndef E_NOTFOUND
@@ -512,3 +517,7 @@ STDMETHODIMP GetSetupConfiguration(_Out_ ISetupConfiguration **ppConfiguration,
512517
#ifdef __cplusplus
513518
}
514519
#endif
520+
521+
#ifdef __clang__
522+
#pragma clang diagnostic pop
523+
#endif

llvm/lib/DebugInfo/PDB/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ macro(add_pdb_impl_folder group)
44
endmacro()
55

66
if(LLVM_ENABLE_DIA_SDK)
7-
include_directories(${MSVC_DIA_SDK_DIR}/include)
7+
include_directories(SYSTEM ${MSVC_DIA_SDK_DIR}/include)
88
set(LIBPDB_LINK_FOLDERS "${MSVC_DIA_SDK_DIR}\\lib")
99

1010
if ("$ENV{VSCMD_ARG_TGT_ARCH}" STREQUAL "arm64")

0 commit comments

Comments
 (0)