Skip to content

Commit e0f35a5

Browse files
committed
[include-fixer] Fix faulty sort predicate.
Note the == on the last line, this isn't a strict-weak ordering. llvm-svn: 276400
1 parent 5c0ef83 commit e0f35a5

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

clang-tools-extra/include-fixer/IncludeFixerContext.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,8 @@ IncludeFixerContext::IncludeFixerContext(
8686
// triggered at the same position or unidentified symbol multiple times.
8787
std::sort(QuerySymbolInfos.begin(), QuerySymbolInfos.end(),
8888
[&](const QuerySymbolInfo &A, const QuerySymbolInfo &B) {
89-
if (A.Range.getOffset() != B.Range.getOffset())
90-
return A.Range.getOffset() < B.Range.getOffset();
91-
return A.Range.getLength() == B.Range.getLength();
89+
return std::make_pair(A.Range.getOffset(), A.Range.getLength()) <
90+
std::make_pair(B.Range.getOffset(), B.Range.getLength());
9291
});
9392
QuerySymbolInfos.erase(
9493
std::unique(QuerySymbolInfos.begin(), QuerySymbolInfos.end(),

0 commit comments

Comments
 (0)