Revert "[build] normalize components dependencies"

serge-sans-paille · serge-sans-paille · commit 733f7b50840a · 2020-11-18T19:23:11.000+01:00
This reverts commit c6ef6e1. Basically, publicly linked libraries have a different semantic than components, which link libraries privately. Differential Revision: https://reviews.llvm.org/D91461
diff --git a/llvm/lib/ExecutionEngine/CMakeLists.txt b/llvm/lib/ExecutionEngine/CMakeLists.txt
@@ -22,6 +22,10 @@ add_llvm_component_library(LLVMExecutionEngine
   Target
   )
 
+if(BUILD_SHARED_LIBS)
+  target_link_libraries(LLVMExecutionEngine PUBLIC LLVMRuntimeDyld)
+endif()
+
 add_subdirectory(Interpreter)
 add_subdirectory(JITLink)
 add_subdirectory(MCJIT)
diff --git a/llvm/lib/ExecutionEngine/JITLink/CMakeLists.txt b/llvm/lib/ExecutionEngine/JITLink/CMakeLists.txt
@@ -24,3 +24,10 @@ add_llvm_component_library(LLVMJITLink
   OrcTargetProcess
   Support
   )
+ 
+target_link_libraries(LLVMJITLink
+  PRIVATE
+  LLVMObject
+  LLVMOrcTargetProcess
+  LLVMSupport
+)
diff --git a/llvm/lib/ExecutionEngine/Orc/CMakeLists.txt b/llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
@@ -32,9 +32,6 @@ add_llvm_component_library(LLVMOrcJIT
   intrinsics_gen
 
   LINK_COMPONENTS
-  Analysis
-  BitReader
-  BitWriter
   Core
   ExecutionEngine
   JITLink
@@ -51,3 +48,11 @@ add_llvm_component_library(LLVMOrcJIT
 
 add_subdirectory(Shared)
 add_subdirectory(TargetProcess)
+
+target_link_libraries(LLVMOrcJIT
+  PRIVATE
+  LLVMAnalysis
+  LLVMBitReader
+  LLVMBitWriter
+  LLVMPasses
+  )
diff --git a/llvm/lib/FileCheck/CMakeLists.txt b/llvm/lib/FileCheck/CMakeLists.txt
@@ -3,7 +3,6 @@ add_llvm_component_library(LLVMFileCheck
 
   ADDITIONAL_HEADER_DIRS
   "${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck"
-
-  LINK_COMPONENTS
-  Support
 )
+
+target_link_libraries(LLVMFileCheck LLVMSupport)
diff --git a/llvm/lib/Frontend/OpenACC/CMakeLists.txt b/llvm/lib/Frontend/OpenACC/CMakeLists.txt
@@ -12,7 +12,7 @@ add_llvm_component_library(LLVMFrontendOpenACC
   DEPENDS
   acc_gen
   acc_cpp
-
-  LINK_COMPONENTS
-  Support
 )
+
+target_link_libraries(LLVMFrontendOpenACC LLVMSupport)
+

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ add_llvm_component_library(LLVMFileCheck`
`3`	`3`
`4`	`4`	`ADDITIONAL_HEADER_DIRS`
`5`	`5`	`"${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck"`
`6`		`-`
`7`		`- LINK_COMPONENTS`
`8`		`- Support`
`9`	`6`	`)`
	`7`	`+`
	`8`	`+target_link_libraries(LLVMFileCheck LLVMSupport)`