Skip to content

Commit 61b305e

Browse files
author
Quentin Colombet
committedMay 5, 2015
[ShrinkWrap] Add (a simplified version) of shrink-wrapping.
This patch introduces a new pass that computes the safe point to insert the prologue and epilogue of the function. The interest is to find safe points that are cheaper than the entry and exits blocks. As an example and to avoid regressions to be introduce, this patch also implements the required bits to enable the shrink-wrapping pass for AArch64. ** Context ** Currently we insert the prologue and epilogue of the method/function in the entry and exits blocks. Although this is correct, we can do a better job when those are not immediately required and insert them at less frequently executed places. The job of the shrink-wrapping pass is to identify such places. ** Motivating example ** Let us consider the following function that perform a call only in one branch of a if: define i32 @f(i32 %a, i32 %b) { %tmp = alloca i32, align 4 %tmp2 = icmp slt i32 %a, %b br i1 %tmp2, label %true, label %false true: store i32 %a, i32* %tmp, align 4 %tmp4 = call i32 @DoSomething(i32 0, i32* %tmp) br label %false false: %tmp.0 = phi i32 [ %tmp4, %true ], [ %a, %0 ] ret i32 %tmp.0 } On AArch64 this code generates (removing the cfi directives to ease readabilities): _f: ; @f ; BB#0: stp x29, x30, [sp, #-16]! mov x29, sp sub sp, sp, llvm#16 ; =16 cmp w0, w1 b.ge LBB0_2 ; BB#1: ; %true stur w0, [x29, #-4] sub x1, x29, llvm#4 ; =4 mov w0, wzr bl _doSomething LBB0_2: ; %false mov sp, x29 ldp x29, x30, [sp], llvm#16 ret With shrink-wrapping we could generate: _f: ; @f ; BB#0: cmp w0, w1 b.ge LBB0_2 ; BB#1: ; %true stp x29, x30, [sp, #-16]! mov x29, sp sub sp, sp, llvm#16 ; =16 stur w0, [x29, #-4] sub x1, x29, llvm#4 ; =4 mov w0, wzr bl _doSomething add sp, x29, llvm#16 ; =16 ldp x29, x30, [sp], llvm#16 LBB0_2: ; %false ret Therefore, we would pay the overhead of setting up/destroying the frame only if we actually do the call. ** Proposed Solution ** This patch introduces a new machine pass that perform the shrink-wrapping analysis (See the comments at the beginning of ShrinkWrap.cpp for more details). It then stores the safe save and restore point into the MachineFrameInfo attached to the MachineFunction. This information is then used by the PrologEpilogInserter (PEI) to place the related code at the right place. This pass runs right before the PEI. Unlike the original paper of Chow from PLDI’88, this implementation of shrink-wrapping does not use expensive data-flow analysis and does not need hack to properly avoid frequently executed point. Instead, it relies on dominance and loop properties. The pass is off by default and each target can opt-in by setting the EnableShrinkWrap boolean to true in their derived class of TargetPassConfig. This setting can also be overwritten on the command line by using -enable-shrink-wrap. Before you try out the pass for your target, make sure you properly fix your emitProlog/emitEpilog/adjustForXXX method to cope with basic blocks that are not necessarily the entry block. ** Design Decisions ** 1. ShrinkWrap is its own pass right now. It could frankly be merged into PEI but for debugging and clarity I thought it was best to have its own file. 2. Right now, we only support one save point and one restore point. At some point we can expand this to several save point and restore point, the impacted component would then be: - The pass itself: New algorithm needed. - MachineFrameInfo: Hold a list or set of Save/Restore point instead of one pointer. - PEI: Should loop over the save point and restore point. Anyhow, at least for this first iteration, I do not believe this is interesting to support the complex cases. We should revisit that when we motivating examples. Differential Revision: http://reviews.llvm.org/D9210 <rdar://problem/3201744> llvm-svn: 236507
1 parent cd68eba commit 61b305e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+1171
-116
lines changed
 

‎llvm/include/llvm/CodeGen/MachineFrameInfo.h

+17
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,16 @@ class MachineFrameInfo {
246246
/// True if this is a varargs function that contains a musttail call.
247247
bool HasMustTailInVarArgFunc;
248248

249+
/// Not null, if shrink-wrapping found a better place for the prologue.
250+
MachineBasicBlock *Save;
251+
/// Not null, if shrink-wrapping found a better place for the epilogue.
252+
MachineBasicBlock *Restore;
253+
254+
/// Check if it exists a path from \p MBB leading to the basic
255+
/// block with a SavePoint (a.k.a. prologue).
256+
bool isBeforeSavePoint(const MachineFunction &MF,
257+
const MachineBasicBlock &MBB) const;
258+
249259
public:
250260
explicit MachineFrameInfo(unsigned StackAlign, bool isStackRealign,
251261
bool RealignOpt)
@@ -269,6 +279,8 @@ class MachineFrameInfo {
269279
HasInlineAsmWithSPAdjust = false;
270280
HasVAStart = false;
271281
HasMustTailInVarArgFunc = false;
282+
Save = nullptr;
283+
Restore = nullptr;
272284
}
273285

274286
/// hasStackObjects - Return true if there are any stack objects in this
@@ -597,6 +609,11 @@ class MachineFrameInfo {
597609

598610
void setCalleeSavedInfoValid(bool v) { CSIValid = v; }
599611

612+
MachineBasicBlock *getSavePoint() const { return Save; }
613+
void setSavePoint(MachineBasicBlock *NewSave) { Save = NewSave; }
614+
MachineBasicBlock *getRestorePoint() const { return Restore; }
615+
void setRestorePoint(MachineBasicBlock *NewRestore) { Restore = NewRestore; }
616+
600617
/// getPristineRegs - Return a set of physical registers that are pristine on
601618
/// entry to the MBB.
602619
///

‎llvm/include/llvm/CodeGen/Passes.h

+10
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@ class TargetPassConfig : public ImmutablePass {
120120
/// Default setting for -enable-tail-merge on this target.
121121
bool EnableTailMerge;
122122

123+
/// Default setting for -enable-shrink-wrap on this target.
124+
bool EnableShrinkWrap;
125+
123126
public:
124127
TargetPassConfig(TargetMachine *tm, PassManagerBase &pm);
125128
// Dummy constructor.
@@ -179,6 +182,9 @@ class TargetPassConfig : public ImmutablePass {
179182
/// Return true if the optimized regalloc pipeline is enabled.
180183
bool getOptimizeRegAlloc() const;
181184

185+
/// Return true if shrink wrapping is enabled.
186+
bool getEnableShrinkWrap() const;
187+
182188
/// Return true if the default global register allocator is in use and
183189
/// has not be overriden on the command line with '-regalloc=...'
184190
bool usingDefaultRegAlloc() const;
@@ -426,6 +432,10 @@ namespace llvm {
426432
/// basic blocks.
427433
extern char &SpillPlacementID;
428434

435+
/// ShrinkWrap pass. Look for the best place to insert save and restore
436+
// instruction and update the MachineFunctionInfo with that information.
437+
extern char &ShrinkWrapID;
438+
429439
/// VirtRegRewriter pass. Rewrite virtual registers to physical registers as
430440
/// assigned in VirtRegMap.
431441
extern char &VirtRegRewriterID;

0 commit comments

Comments
 (0)
Please sign in to comment.