Skip to content

Commit 30a8976

Browse files
committed
llvm-config: Fix --targets-built, I changed this to use the registry but wasn't
properly initializing the target infos. I decided it wasn't worth linking them in for this, so just switched back to using the Makefile variable for now. We can reconsider later if we ever get pluggable targets. llvm-svn: 146711
1 parent 6688625 commit 30a8976

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

llvm/tools/llvm-config/BuildVariables.inc.in

+1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,5 @@
2323
#define LLVM_LDFLAGS "@LLVM_LDFLAGS@"
2424
#define LLVM_CXXFLAGS "@LLVM_CXXFLAGS@"
2525
#define LLVM_BUILDMODE "@LLVM_BUILDMODE@"
26+
#define LLVM_TARGETS_BUILT "@LLVM_TARGETS_BUILT@"
2627
#define LLVM_SYSTEM_LIBS "@LLVM_SYSTEM_LIBS@"

llvm/tools/llvm-config/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ add_custom_command(OUTPUT ${BUILDVARIABLES_OBJPATH}
2727
COMMAND echo s!@LLVM_LDFLAGS@!${CMAKE_SHARED_LINKER_FLAGS}! >> ${SEDSCRIPT_OBJPATH}
2828
COMMAND echo s!@LLVM_BUILDMODE@!${CMAKE_BUILD_TYPE}! >> ${SEDSCRIPT_OBJPATH}
2929
COMMAND echo s!@LLVM_SYSTEM_LIBS@!${SYSTEM_LIBS}! >> ${SEDSCRIPT_OBJPATH}
30+
COMMAND echo s!@LLVM_TARGETS_BUILT@!${LLVM_TARGETS_TO_BUILD}! >> ${SEDSCRIPT_OBJPATH}
3031
COMMAND sed -f ${SEDSCRIPT_OBJPATH} < ${BUILDVARIABLES_SRCPATH} > ${BUILDVARIABLES_OBJPATH}
3132
VERBATIM
3233
COMMENT "Building BuildVariables.inc include."

llvm/tools/llvm-config/Makefile

+2
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,7 @@ $(ObjDir)/BuildVariables.inc: $(BUILDVARIABLES_SRCPATH) Makefile $(ObjDir)/.dir
5353
>> temp.sed
5454
$(Verb) $(ECHO) 's/@LLVM_SYSTEM_LIBS@/$(subst /,\/,$(LIBS))/' \
5555
>> temp.sed
56+
$(Verb) $(ECHO) 's/@LLVM_TARGETS_BUILT@/$(subst /,\/,$(TARGETS_TO_BUILD))/' \
57+
>> temp.sed
5658
$(Verb) $(SED) -f temp.sed < $< > $@
5759
$(Verb) $(RM) temp.sed

llvm/tools/llvm-config/llvm-config.cpp

+1-9
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include "llvm/Config/llvm-config.h"
2626
#include "llvm/Support/FileSystem.h"
2727
#include "llvm/Support/Path.h"
28-
#include "llvm/Support/TargetRegistry.h"
2928
#include "llvm/Support/raw_ostream.h"
3029
#include <cstdlib>
3130
#include <set>
@@ -271,14 +270,7 @@ int main(int argc, char **argv) {
271270
}
272271
OS << '\n';
273272
} else if (Arg == "--targets-built") {
274-
bool First = true;
275-
for (TargetRegistry::iterator I = TargetRegistry::begin(),
276-
E = TargetRegistry::end(); I != E; First = false, ++I) {
277-
if (!First)
278-
OS << ' ';
279-
OS << I->getName();
280-
}
281-
OS << '\n';
273+
OS << LLVM_TARGETS_BUILT << '\n';
282274
} else if (Arg == "--host-target") {
283275
OS << LLVM_DEFAULT_TARGET_TRIPLE << '\n';
284276
} else if (Arg == "--build-mode") {

0 commit comments

Comments
 (0)