Skip to content

Commit 1ecf0de

Browse files
authoredOct 27, 2019
Merge pull request knaxus#150 from francismarcus/patch-1
Changed some minor typos in Contributing.md
2 parents 29b1650 + 59a27b4 commit 1ecf0de

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed
 

‎CONTRIBUTING.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
11
# Contribution Guide
22

3-
Thanks for taking interest and I appreciate your efforts towards making this projects even better.
3+
Thanks for taking interest and I appreciate your efforts towards making this project even better.
44

55
## How to setup?
66

7-
This is the most simple project when it comes to contributions, setup, opening issues/pull requests. So et's get started.
7+
This is the most simple project when it comes to contributions, setup, opening issues/pull requests. So let's get started.
88

99
- Clone the repo using the command `git clone git@github.com:knaxus/problem-solving-javascript.git`<sup>1</sup>
10-
- Install the packages to get suport for linter using `npm install`
10+
- Install the packages to get support for linter using `npm install`
1111

1212
1: If you do not have **ssh** setup for github, while cloning go with **https**
1313

1414
### Before you start, keep the following things in mind:
1515
- We use ESLint for code linting
1616
- The linter follows [Airbnb JavaScript Style Guide](https://github.com/airbnb/javascript)
17-
- Go though the folder structure carefully and follow the same
18-
- Go though the format and file convenetions used while adding tests (both test case and test files)
17+
- Go through the folder structure carefully and follow the same
18+
- Go through the format and file convenetions used while adding tests (both test case and test files)
1919

2020
## Adding your code
2121

22-
- When adding a new problem with solution
22+
- When adding a new problem with a solution
2323
- Take care of the filename convention (Very Important)
24-
- Problem statement should be there and support it with some examples
25-
- Make sure you've add the **Run Time Complexity** of your solution
24+
- A problem statement should be there and support it with some examples
25+
- Make sure you've added the **Run Time Complexity** of your solution
2626
- Please take care of the segregation of the Problems as per the given Folder Structure
2727
- It's great if you can add the Unit Tests to verify your solutions as well
2828

2929
- When adding a Unit Test
3030
- Take care of the file name convention
3131
- Make sure CI (Travis) is passing
32-
- Expanding the test suite until (close to) 100 percent code coverage is achieved
32+
- Expanding the test suite until (close to) 100 percentage code coverage is achieved
3333

3434
### Notes
3535

0 commit comments

Comments
 (0)