Skip to content

Commit 7a0673a

Browse files
theseersebastianbergmann
theseer
authored and
sebastianbergmann
committed
make percent value consistent (no %, 0 on empty)
1 parent fb74bad commit 7a0673a

File tree

7 files changed

+50
-50
lines changed

7 files changed

+50
-50
lines changed

‎src/Report/Xml/Totals.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function setNumLines($loc, $cloc, $ncloc, $executable, $executed)
9595
$this->linesNode->setAttribute('executed', $executed);
9696
$this->linesNode->setAttribute(
9797
'percent',
98-
Util::percent($executed, $executable, true)
98+
$executable === 0 ? 0 : sprintf('%01.2F', Util::percent($executed, $executable, false))
9999
);
100100
}
101101

@@ -105,7 +105,7 @@ public function setNumClasses($count, $tested)
105105
$this->classesNode->setAttribute('tested', $tested);
106106
$this->classesNode->setAttribute(
107107
'percent',
108-
Util::percent($tested, $count, true)
108+
$count === 0 ? 0 : sprintf('%01.2F', Util::percent($tested, $count, false))
109109
);
110110
}
111111

@@ -115,7 +115,7 @@ public function setNumTraits($count, $tested)
115115
$this->traitsNode->setAttribute('tested', $tested);
116116
$this->traitsNode->setAttribute(
117117
'percent',
118-
Util::percent($tested, $count, true)
118+
$count === 0 ? 0 : sprintf('%01.2F', Util::percent($tested, $count, false))
119119
);
120120
}
121121

@@ -125,7 +125,7 @@ public function setNumMethods($count, $tested)
125125
$this->methodsNode->setAttribute('tested', $tested);
126126
$this->methodsNode->setAttribute(
127127
'percent',
128-
Util::percent($tested, $count, true)
128+
$count === 0 ? 0 : sprintf('%01.2F', Util::percent($tested, $count, false))
129129
);
130130
}
131131

@@ -135,7 +135,7 @@ public function setNumFunctions($count, $tested)
135135
$this->functionsNode->setAttribute('tested', $tested);
136136
$this->functionsNode->setAttribute(
137137
'percent',
138-
Util::percent($tested, $count, true)
138+
$count === 0 ? 0 : sprintf('%01.2F', Util::percent($tested, $count, false))
139139
);
140140
}
141141
}

‎tests/_files/Report/XML/CoverageForBankAccount/BankAccount.php.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<phpunit xmlns="http://schema.phpunit.de/coverage/1.0">
33
<file name="BankAccount.php">
44
<totals>
5-
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00%"/>
6-
<methods count="4" tested="3" percent="75.00%"/>
7-
<functions count="0" tested="0" percent=""/>
8-
<classes count="1" tested="0" percent="0.00%"/>
9-
<traits count="0" tested="0" percent=""/>
5+
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00"/>
6+
<methods count="4" tested="3" percent="75.00"/>
7+
<functions count="0" tested="0" percent="0"/>
8+
<classes count="1" tested="0" percent="0.00"/>
9+
<traits count="0" tested="0" percent="0"/>
1010
</totals>
1111
<class name="BankAccount" start="2" executable="10" executed="5" crap="8.12">
1212
<package full="" name="" sub="" category=""/>

‎tests/_files/Report/XML/CoverageForBankAccount/index.xml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@
1212
</tests>
1313
<directory name="%s">
1414
<totals>
15-
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00%"/>
16-
<methods count="4" tested="3" percent="75.00%"/>
17-
<functions count="0" tested="0" percent=""/>
18-
<classes count="1" tested="0" percent="0.00%"/>
19-
<traits count="0" tested="0" percent=""/>
15+
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00"/>
16+
<methods count="4" tested="3" percent="75.00"/>
17+
<functions count="0" tested="0" percent="0"/>
18+
<classes count="1" tested="0" percent="0.00"/>
19+
<traits count="0" tested="0" percent="0"/>
2020
</totals>
2121
<file name="BankAccount.php" href="BankAccount.php.xml">
2222
<totals>
23-
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00%"/>
24-
<methods count="4" tested="3" percent="75.00%"/>
25-
<functions count="0" tested="0" percent=""/>
26-
<classes count="1" tested="0" percent="0.00%"/>
27-
<traits count="0" tested="0" percent=""/>
23+
<lines total="33" comments="0" code="33" executable="10" executed="5" percent="50.00"/>
24+
<methods count="4" tested="3" percent="75.00"/>
25+
<functions count="0" tested="0" percent="0"/>
26+
<classes count="1" tested="0" percent="0.00"/>
27+
<traits count="0" tested="0" percent="0"/>
2828
</totals>
2929
</file>
3030
</directory>

‎tests/_files/Report/XML/CoverageForClassWithAnonymousFunction/index.xml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@
99
</tests>
1010
<directory name="%s">
1111
<totals>
12-
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50%"/>
13-
<methods count="2" tested="1" percent="50.00%"/>
14-
<functions count="0" tested="0" percent=""/>
15-
<classes count="1" tested="0" percent="0.00%"/>
16-
<traits count="0" tested="0" percent=""/>
12+
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50"/>
13+
<methods count="2" tested="1" percent="50.00"/>
14+
<functions count="0" tested="0" percent="0"/>
15+
<classes count="1" tested="0" percent="0.00"/>
16+
<traits count="0" tested="0" percent="0"/>
1717
</totals>
1818
<file name="source_with_class_and_anonymous_function.php" href="source_with_class_and_anonymous_function.php.xml">
1919
<totals>
20-
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50%"/>
21-
<methods count="2" tested="1" percent="50.00%"/>
22-
<functions count="0" tested="0" percent=""/>
23-
<classes count="1" tested="0" percent="0.00%"/>
24-
<traits count="0" tested="0" percent=""/>
20+
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50"/>
21+
<methods count="2" tested="1" percent="50.00"/>
22+
<functions count="0" tested="0" percent="0"/>
23+
<classes count="1" tested="0" percent="0.00"/>
24+
<traits count="0" tested="0" percent="0"/>
2525
</totals>
2626
</file>
2727
</directory>

‎tests/_files/Report/XML/CoverageForClassWithAnonymousFunction/source_with_class_and_anonymous_function.php.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<phpunit xmlns="http://schema.phpunit.de/coverage/1.0">
33
<file name="source_with_class_and_anonymous_function.php">
44
<totals>
5-
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50%"/>
6-
<methods count="2" tested="1" percent="50.00%"/>
7-
<functions count="0" tested="0" percent=""/>
8-
<classes count="1" tested="0" percent="0.00%"/>
9-
<traits count="0" tested="0" percent=""/>
5+
<lines total="19" comments="2" code="17" executable="8" executed="7" percent="87.50"/>
6+
<methods count="2" tested="1" percent="50.00"/>
7+
<functions count="0" tested="0" percent="0"/>
8+
<classes count="1" tested="0" percent="0.00"/>
9+
<traits count="0" tested="0" percent="0"/>
1010
</totals>
1111
<class name="CoveredClassWithAnonymousFunctionInStaticMethod" start="3" executable="8" executed="7" crap="2.01">
1212
<package full="" name="" sub="" category=""/>

‎tests/_files/Report/XML/CoverageForFileWithIgnoredLines/index.xml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@
99
</tests>
1010
<directory name="%s">
1111
<totals>
12-
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00%"/>
13-
<methods count="0" tested="0" percent=""/>
14-
<functions count="1" tested="0" percent="0.00%"/>
15-
<classes count="0" tested="0" percent=""/>
16-
<traits count="0" tested="0" percent=""/>
12+
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00"/>
13+
<methods count="0" tested="0" percent="0"/>
14+
<functions count="1" tested="0" percent="0.00"/>
15+
<classes count="0" tested="0" percent="0"/>
16+
<traits count="0" tested="0" percent="0"/>
1717
</totals>
1818
<file name="source_with_ignore.php" href="source_with_ignore.php.xml">
1919
<totals>
20-
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00%"/>
21-
<methods count="0" tested="0" percent=""/>
22-
<functions count="1" tested="0" percent="0.00%"/>
23-
<classes count="0" tested="0" percent=""/>
24-
<traits count="0" tested="0" percent=""/>
20+
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00"/>
21+
<methods count="0" tested="0" percent="0"/>
22+
<functions count="1" tested="0" percent="0.00"/>
23+
<classes count="0" tested="0" percent="0"/>
24+
<traits count="0" tested="0" percent="0"/>
2525
</totals>
2626
</file>
2727
</directory>

‎tests/_files/Report/XML/CoverageForFileWithIgnoredLines/source_with_ignore.php.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<phpunit xmlns="http://schema.phpunit.de/coverage/1.0">
33
<file name="source_with_ignore.php">
44
<totals>
5-
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00%"/>
6-
<methods count="0" tested="0" percent=""/>
7-
<functions count="1" tested="0" percent="0.00%"/>
8-
<classes count="0" tested="0" percent=""/>
9-
<traits count="0" tested="0" percent=""/>
5+
<lines total="37" comments="12" code="25" executable="2" executed="1" percent="50.00"/>
6+
<methods count="0" tested="0" percent="0"/>
7+
<functions count="1" tested="0" percent="0.00"/>
8+
<classes count="0" tested="0" percent="0"/>
9+
<traits count="0" tested="0" percent="0"/>
1010
</totals>
1111
<class name="Foo" start="11" executable="0" executed="0" crap="1">
1212
<package full="" name="" sub="" category=""/>

0 commit comments

Comments
 (0)