Merge pull request #99 from facebook/master

merging upstream master

Author: joeycozza

.github/stale.yml

@@ -16,8 +16,13 @@ exemptLabels:
   - "issue: bug"
   - "issue: needs investigation"
   - "issue: proposal"
-  - "tag: bug fix"
   - "tag: breaking change"
+  - "tag: bug fix"
+  - "tag: documentation"
+  - "tag: enhancement"
+  - "tag: internal"
+  - "tag: new feature"
+  - "tag: underlying tools"
 
 # Set to true to ignore issues in a project (defaults to false)
 exemptProjects: true

CHANGELOG-2.x.md

@@ -152,7 +152,7 @@ By default git would use `CRLF` line endings which would cause the scripts to fa
 9. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
 10. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration.
 
-Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --canary=next --exact --cd-version patch --npm-tag=next` instead of `npm run publish`.
+Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- prepatch --canary --preid next --dist-tag next --npm-client npm --force-publish` instead of `npm run publish`.
 
 ---
 

CHANGELOG.md

@@ -42,6 +42,12 @@ If you set `SASS_PATH=node_modules:src`, this will allow you to do imports like
 @import 'nprogress/nprogress'; // importing a css file from the nprogress node module
 ```
 
+> **Note:** For windows operating system, use below syntax
+>
+> ```
+> SASS_PATH=./node_modules;./src
+> ```
+
 > **Tip:** You can opt into using this feature with [CSS modules](adding-a-css-modules-stylesheet.md) too!
 
 > **Note:** If you're using Flow, override the [module.file_ext](https://flow.org/en/docs/config/options/#toc-module-file-ext-string) setting in your `.flowconfig` so it'll recognize `.sass` or `.scss` files. You will also need to include the `module.file_ext` default settings for `.js`, `.jsx`, `.mjs` and `.json` files.

CONTRIBUTING.md

@@ -3,7 +3,7 @@ id: adding-bootstrap
 title: Adding Bootstrap
 ---
 
-While you don’t have to use any specific library to integrate Bootstrap with React apps, it's often easier than trying to wrap the Bootstrap jQuery plugins. [React Bootstrap](https://react-bootstrap.netlify.com/) is the most popular option, that strives for complete parity with bootstrap. [reactstrap](https://reactstrap.github.io/) is also a good choice for projects looking for smaller builds at the expense of some features.
+While you don’t have to use any specific library to integrate Bootstrap with React apps, it's often easier than trying to wrap the Bootstrap jQuery plugins. [React Bootstrap](https://react-bootstrap.netlify.com/) is the most popular option that strives for complete parity with Bootstrap. [reactstrap](https://reactstrap.github.io/) is also a good choice for projects looking for smaller builds at the expense of some features.
 
 Each project's respective documentation site has detailed instructions for installing and using them. Both depend on the Bootstrap css file so install that as well:
 

docusaurus/docs/adding-a-sass-stylesheet.md

@@ -0,0 +1,71 @@
+---
+id: adding-css-reset
+title: Adding a CSS Reset
+sidebar_label: Adding CSS Reset
+---
+
+This project setup uses [PostCSS Normalize] for adding a [CSS Reset].
+
+To start using it, add `@import-normalize;` anywhere in your CSS file(s). You only need to include it once and duplicate imports are automatically removed. Since you only need to include it once, a good place to add it is `index.css` or `App.css`.
+
+## `index.css`
+
+```css
+@import-normalize; /* bring in normalize.css styles */
+
+/* rest of app styles */
+```
+
+You can control which parts of [normalize.css] to use via your project's [browserslist].
+
+Results when [browserslist] is `last 3 versions`:
+
+```css
+/**
+ * Add the correct display in IE 9-.
+ */
+
+audio,
+video {
+  display: inline-block;
+}
+
+/**
+ * Remove the border on images inside links in IE 10-.
+ */
+
+img {
+  border-style: none;
+}
+```
+
+Results when [browserslist] is `last 2 versions`:
+
+```css
+/**
+ * Remove the border on images inside links in IE 10-.
+ */
+
+img {
+  border-style: none;
+}
+```
+
+## Browser support
+
+Browser support is dictated by what normalize.css [supports]. As of this writing, it includes:
+
+- Chrome (last 3)
+- Edge (last 3)
+- Firefox (last 3)
+- Firefox ESR
+- Opera (last 3)
+- Safari (last 3)
+- iOS Safari (last 2)
+- Internet Explorer 9+
+
+[browserslist]: http://browserl.ist/
+[css reset]: https://cssreset.com/what-is-a-css-reset/
+[normalize.css]: https://github.com/csstools/normalize.css
+[supports]: https://github.com/csstools/normalize.css#browser-support
+[postcss normalize]: https://github.com/csstools/postcss-normalize

docusaurus/docs/adding-bootstrap.md

@@ -44,7 +44,7 @@ An alternative way of handling static assets is described in the next section.
 
 ## Adding SVGs
 
-> Note: this feature is available with `react-scripts@2.0.0` and higher.
+> Note: this feature is available with `react-scripts@2.0.0` and higher, and `react@16.3.0` and higher.
 
 One way to add SVG files was described in the section above. You can also import SVGs directly as React components. You can use either of the two approaches. In your code it would look like this:
 

docusaurus/docs/adding-css-reset.md

@@ -33,6 +33,9 @@ Type errors will show up in the same console as the build one.
 
 To learn more about TypeScript, check out [its documentation](https://www.typescriptlang.org/).
 
+> **Note:** If your project is not created with TypeScript enabled, npx may be using a cached version of `create-react-app`.
+> Remove previously installed versions with `npm uninstall -g create-react-app` (see [#6119](https://github.com/facebook/create-react-app/issues/6119#issuecomment-451614035)).
+
 > **Note:** You are not required to make a [`tsconfig.json` file](https://www.typescriptlang.org/docs/handbook/tsconfig-json.html), one will be made for you.
 > You are allowed to edit the generated TypeScript configuration.
 

docusaurus/docs/adding-images-fonts-and-files.md

@@ -3,7 +3,9 @@ id: advanced-configuration
 title: Advanced Configuration
 ---
 
-You can adjust various development and production settings by setting environment variables in your shell or with [.env](adding-custom-environment-variables.md#adding-development-environment-variables-in-env).
+You can adjust various development and production settings by setting environment variables in your shell or with [.env](adding-custom-environment-variables.md#adding-development-environment-variables-in-env). 
+
+> Note: You do not need to declare `REACT_APP_` before the below variables as you would with custom environment variables.
 
 | Variable             | Development | Production | Usage                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | :------------------- | :---------: | :--------: | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |