From 4ee22cf93c6e945137facf0ff6bc61d998f87696 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steve=20Schu=CC=88tze?= Date: Thu, 18 Apr 2019 14:26:56 +0200 Subject: [PATCH] update sca tools and integration --- .gitignore | 2 ++ .travis.yml | 4 ++-- README.md | 4 ++-- composer.json | 12 ++++++------ phpunit.xml | 1 - src/Enum.php | 7 +++---- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.gitignore b/.gitignore index 22d0d82..d769eb5 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,3 @@ vendor +.phpunit.result.cache +composer.lock diff --git a/.travis.yml b/.travis.yml index 6ed0c97..76a91fb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,8 +10,8 @@ before_script: - composer install --prefer-source --no-interaction script: - - ./vendor/bin/phpunit.phar -c ./phpunit.xml --debug --verbose + - ./vendor/bin/phpunit.phar -c ./phpunit.xml --testdox - ./vendor/bin/phpmd.phar ./src/ text phpmd.xml - - ./vendor/bin/phpstan.phar analyse -l 7 ./src + - ./vendor/bin/phpstan.phar analyse -l max ./src - ./vendor/bin/phpcs.phar ./src --standard=PSR2 - ./vendor/bin/phpcpd.phar ./src diff --git a/README.md b/README.md index c98747e..7231ea4 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ Run each command in the project root directory. ### Execute PHPUnit tests ``` -./vendor/bin/phpunit.phar -c ./phpunit.xml --debug --verbose +./vendor/bin/phpunit.phar -c ./phpunit.xml --testdox ``` ### Execute PHPMD checks @@ -32,5 +32,5 @@ Run each command in the project root directory. ### Execute PHPSTAN checks ``` -./vendor/bin/phpstan analyse -l 4 src/ +./vendor/bin/phpstan.phar analyse -l max ./src/ ``` diff --git a/composer.json b/composer.json index ac96fdb..8b7365b 100644 --- a/composer.json +++ b/composer.json @@ -18,7 +18,7 @@ } }, "require-dev": { - "tm/tooly-composer-script": "~1.2.6" + "tm/tooly-composer-script": "^1.2" }, "scripts": { "post-install-cmd": "Tooly\\ScriptHandler::installPharTools", @@ -27,23 +27,23 @@ "extra": { "tools": { "phpunit": { - "url": "https://phar.phpunit.de/phpunit-7.1.2.phar", + "url": "https://phar.phpunit.de/phpunit-8.1.2.phar", "force-replace": true }, "phpmd": { - "url": "http://static.phpmd.org/php/2.6.0/phpmd.phar", + "url": "http://static.phpmd.org/php/latest/phpmd.phar", "force-replace": true }, "phpcpd": { - "url": "https://github.com/sebastianbergmann/phpcpd/releases/download/2.0.0/phpcpd.phar", + "url": "https://phar.phpunit.de/phpcpd.phar", "force-replace": true }, "phpcs": { - "url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.2.3/phpcs.phar", + "url": "https://squizlabs.github.io/PHP_CodeSniffer/phpcs.phar", "force-replace": true }, "phpstan": { - "url": "https://github.com/phpstan/phpstan/releases/download/0.9.2/phpstan.phar", + "url": "https://github.com/phpstan/phpstan/releases/download/0.11.5/phpstan.phar", "force-replace": true } } diff --git a/phpunit.xml b/phpunit.xml index fe98ea0..0f7f980 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -8,7 +8,6 @@ convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" - syntaxCheck="false" bootstrap="vendor/autoload.php"> diff --git a/src/Enum.php b/src/Enum.php index 9c5fcfa..ddef7c4 100644 --- a/src/Enum.php +++ b/src/Enum.php @@ -2,6 +2,8 @@ namespace FreshP\PhpEnumeration; +use ReflectionClass; + abstract class Enum { protected $value; @@ -16,7 +18,6 @@ public function __toString(): string return $this->value; } - abstract protected function getDefault(): string; protected function setValue(string $value): void @@ -32,8 +33,6 @@ protected function setValue(string $value): void protected function toArray(): array { - $reflection = new \ReflectionClass($this); - - return $reflection->getConstants(); + return (new ReflectionClass(static::class))->getConstants(); } }