Skip to content

Commit ef35ce4

Browse files
authored
Merge pull request #8 from freshp/feature/update-sca-tools
update sca tools and fix messages
2 parents 1100656 + c23ec3c commit ef35ce4

File tree

5 files changed

+52
-17
lines changed

5 files changed

+52
-17
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ Run each command in the project root directory.
2020
2121
### Execute PHPUnit tests
2222
```
23-
./vendor/bin/phpunit.phar -c ./phpunit.xml --testdox
23+
./vendor/bin/phpunit.phar --testdox
2424
```
2525
26-
### Execute PHPCS-Fixer checks
26+
### Execute fix PHPCS problems
2727
```
28-
./vendor/bin/phpcs-fixer.phar fix ./src -v --diff
28+
./vendor/bin/phpcbf.phar
2929
```
3030
3131
### Execute PHPCS checks
3232
```
33-
./vendor/bin/phpcs.phar ./src --standard=PSR2
33+
./vendor/bin/phpcs.phar
3434
```
3535
3636
### Execute PHPSTAN checks

composer.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,31 +24,31 @@
2424
"post-install-cmd": "Tooly\\ScriptHandler::installPharTools",
2525
"post-update-cmd": "Tooly\\ScriptHandler::installPharTools",
2626
"quickcheck": [
27-
"./vendor/bin/phpunit.phar -c ./phpunit.xml --testdox",
28-
"./vendor/bin/phpstan.phar analyse -l max ./src",
29-
"./vendor/bin/phpcs.phar ./src --standard=PSR2"
27+
"./vendor/bin/phpunit.phar --testdox",
28+
"./vendor/bin/phpstan.phar analyse",
29+
"./vendor/bin/phpcs.phar"
3030
]
3131
},
3232
"extra": {
3333
"tools": {
3434
"phpunit": {
35-
"url": "https://phar.phpunit.de/phpunit-8.5.1.phar",
36-
"sign-url": "https://phar.phpunit.de/phpunit-8.5.1.phar.asc",
35+
"url": "https://phar.phpunit.de/phpunit-9.2.3.phar",
36+
"sign-url": "https://phar.phpunit.de/phpunit-9.2.3.phar.asc",
3737
"force-replace": true
3838
},
3939
"phpcs": {
40-
"url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.3/phpcs.phar",
41-
"sign-url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.3/phpcs.phar.asc",
40+
"url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.5/phpcs.phar",
41+
"sign-url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.5/phpcs.phar.asc",
4242
"force-replace": true
4343
},
44-
"phpcs-fixer": {
45-
"url": "https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.1/php-cs-fixer.phar",
46-
"sign-url": "https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.1/php-cs-fixer.phar.asc",
44+
"phpcbf": {
45+
"url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.5/phpcbf.phar",
46+
"sign-url": "https://github.com/squizlabs/PHP_CodeSniffer/releases/download/3.5.5/phpcbf.phar.asc",
4747
"force-replace": true
4848
},
4949
"phpstan": {
50-
"url": "https://github.com/phpstan/phpstan/releases/download/0.11.19/phpstan.phar",
51-
"sign-url": "https://github.com/phpstan/phpstan/releases/download/0.11.19/phpstan.phar.asc",
50+
"url": "https://github.com/phpstan/phpstan/releases/download/0.12.29/phpstan.phar",
51+
"sign-url": "https://github.com/phpstan/phpstan/releases/download/0.12.29/phpstan.phar.asc",
5252
"force-replace": true
5353
}
5454
}

phpcs.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<?xml version="1.0"?>
2+
<ruleset
3+
name="PHP Coding Standards"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:noNamespaceSchemaLocation="vendor/squizlabs/php_codesniffer/phpcs.xsd">
6+
7+
<!-- set config paths to check-packages -->
8+
<config name="ignore_warnings_on_exit" value="true"/>
9+
<config name="ignore_errors_on_exit" value="true"/>
10+
11+
<!-- set basic phpcs config -->
12+
<arg name="extensions" value="php"/>
13+
<arg name="colors"/>
14+
15+
<!-- Show progress of the run -->
16+
<arg value="p"/>
17+
18+
<!-- set ruleset to use -->
19+
<rule ref="PSR12"/>
20+
21+
<!-- set paths to check -->
22+
<file>src</file>
23+
<file>tests</file>
24+
</ruleset>

phpstan.neon

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
parameters:
2+
level: max
3+
4+
inferPrivatePropertyTypeFromConstructor: true
5+
checkMissingIterableValueType: false
6+
7+
fileExtensions:
8+
- php
9+
10+
paths:
11+
- %currentWorkingDirectory%/src

src/Enum.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ abstract class Enum
1010
{
1111
protected string $value;
1212

13-
public function __construct(string $value = '')
13+
final public function __construct(string $value = '')
1414
{
1515
$this->setValue($value);
1616
}

0 commit comments

Comments
 (0)