Fix warnings from latest version of clippy.

Author: walkie

frame_runtime/src/smcat.rs

@@ -16,7 +16,7 @@ use std::fmt;
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#colors-and-line-width>
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#state-display-names>
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#overriding-the-type-of-a-state>
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct NodeStyle {
     pub active: bool,
     pub class: Option<String>,
@@ -31,37 +31,14 @@ pub struct NodeStyle {
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#classes>
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#colors-and-line-width>
 ///  * <https://github.com/sverweij/state-machine-cat/blob/develop/README.md#internal-and-external-transitions>
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, Default, PartialEq)]
 pub struct EdgeStyle {
     pub class: Option<String>,
     pub color: Option<String>,
     pub etype: Option<String>,
     pub width: Option<f32>,
 }
 
-impl Default for NodeStyle {
-    fn default() -> Self {
-        NodeStyle {
-            active: false,
-            class: None,
-            color: None,
-            label: None,
-            ntype: None,
-        }
-    }
-}
-
-impl Default for EdgeStyle {
-    fn default() -> Self {
-        EdgeStyle {
-            class: None,
-            color: None,
-            etype: None,
-            width: None,
-        }
-    }
-}
-
 impl fmt::Display for NodeStyle {
     fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
         let mut parts = Vec::new();

framec/src/frame_c/ast.rs

@@ -1512,6 +1512,7 @@ impl NodeElement for LiteralExprNode {
 
 #[derive(Clone)]
 pub struct TypeNode {
+    #[allow(dead_code)]
     is_superstring: bool,
     is_reference: bool,
     type_str: String,

framec/src/frame_c/config.rs

@@ -9,7 +9,7 @@ use std::fs;
 use std::path::PathBuf;
 
 /// The root struct of a frame configuration.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct FrameConfig {
     pub codegen: CodeGenConfig,
 }
@@ -48,30 +48,30 @@ impl FrameConfig {
 }
 
 /// Configuration options related to code generation.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CodeGenConfig {
     pub common: CommonConfig,
     pub rust: RustConfig,
     pub smcat: SmcatConfig,
 }
 
 /// Code generation options shared among all backends.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CommonConfig {
     pub features: CommonFeatures,
     pub code: CommonCode,
 }
 
 /// Code generation features shared among all backends.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CommonFeatures {}
 
 /// Naming options for generated code shared among all backends.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CommonCode {}
 
 /// Code generation options specific to the Rust backend.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct RustConfig {
     pub features: RustFeatures,
     pub code: RustCode,
@@ -222,14 +222,14 @@ impl RustRuntime {
 }
 
 /// Code generation options specific to the Smcat backend.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct SmcatConfig {
     pub features: SmcatFeatures,
     pub code: SmcatCode,
 }
 
 /// Code generation features specific to the Smcat backend.
-#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct SmcatFeatures {}
 
 /// Style options for generated code specific to the Smcat backend.
@@ -365,55 +365,6 @@ impl Provider for SystemNode {
 
 // Defaults
 
-impl Default for FrameConfig {
-    fn default() -> Self {
-        FrameConfig {
-            codegen: CodeGenConfig::default(),
-        }
-    }
-}
-
-impl Default for CodeGenConfig {
-    fn default() -> Self {
-        CodeGenConfig {
-            common: CommonConfig::default(),
-            rust: RustConfig::default(),
-            smcat: SmcatConfig::default(),
-        }
-    }
-}
-
-impl Default for CommonConfig {
-    fn default() -> Self {
-        CommonConfig {
-            features: CommonFeatures::default(),
-            code: CommonCode::default(),
-        }
-    }
-}
-
-impl Default for CommonFeatures {
-    fn default() -> Self {
-        CommonFeatures {}
-    }
-}
-
-impl Default for CommonCode {
-    fn default() -> Self {
-        CommonCode {}
-    }
-}
-
-impl Default for RustConfig {
-    fn default() -> Self {
-        RustConfig {
-            features: RustFeatures::default(),
-            code: RustCode::default(),
-            runtime: RustRuntime::default(),
-        }
-    }
-}
-
 impl Default for RustFeatures {
     fn default() -> Self {
         RustFeatures {
@@ -504,21 +455,6 @@ impl Default for RustRuntime {
     }
 }
 
-impl Default for SmcatConfig {
-    fn default() -> Self {
-        SmcatConfig {
-            features: SmcatFeatures::default(),
-            code: SmcatCode::default(),
-        }
-    }
-}
-
-impl Default for SmcatFeatures {
-    fn default() -> Self {
-        SmcatFeatures {}
-    }
-}
-
 impl Default for SmcatCode {
     fn default() -> Self {
         SmcatCode {

framec/src/frame_c/symbol_table.rs

@@ -1146,10 +1146,7 @@ impl Arcanum {
         }
         let system_symbol_rcref = self.system_symbol_opt.as_ref().unwrap();
         let system_symbol = system_symbol_rcref.borrow_mut();
-        system_symbol
-            .events
-            .get(&cannonical_msg)
-            .map(|x| Rc::clone(x))
+        system_symbol.events.get(&cannonical_msg).map(Rc::clone)
     }
 
     // pub fn get_event_ret_opt(&mut self, msg:&str, state_name_opt:&Option<String>) -> Option<TypeNode> {