Convert onIceCandidate to async and introduce a delay #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert onIceCandidate to async and introduce a delay
Contributor
Author
|
This is related to the issues faced in coturn/coturn#814 which were not caused by anything on coturn side, but by this portion of flutter-webrtc-demo code |
Member
|
LGTM |
|
@carlogrisetti I encountered the same problem. I added it according to your method and added a delay, but it didn't work. There is still a one-third probability that the relay fails to establish a connection online. Can you give me some help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a delay (to be web compliant it cannot be done with dart:io but we have to relay to an async declaration) to allow ICE candidates to be processed by the client.
Without this, I often found myself unable to establish a connection (especially in relay, with the network lag that implicitly happens), because the client just "skipped over" to the next candidate almost immediately, without actually waiting for an established connection.
There might be a better solution, but this solves the issue in all the environments \ networks I was testing this on.