Fix jsify on function #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
As explained in the thread in #60, there are 2 issues.
First it says there is no
forEachonInstance of 'RtcStatsReport', which is weird, as that should exists, butstatsis of type dynamic. This is fixed by setting the type ofstatstoRTCStatsReport.When you do that you get
parameter 1 is not of type 'Function'.. That's becausejsifyonly works on primitives, so it converts the function to a generic object. By usingtoJSis converts the function to aJSExportedDartFunction.Also fixes: flutter-webrtc/flutter-webrtc#1781 and flutter-webrtc/flutter-webrtc#1788