clean up another unneeded reducer -> use iterator in the future

Author: bobzhang

jscomp/core/js_fold_basic.ml

@@ -27,10 +27,9 @@
 
 let add_lam_module_ident = Lam_module_ident.Hash_set.add
 let create = Lam_module_ident.Hash_set.create
-class count_hard_dependencies = 
+class count_hard_dependencies hard_dependencies = 
   object(self : 'self_type)
     inherit  Js_fold.fold as super
-    val hard_dependencies =  create 17
     method! module_id vid = 
         add_lam_module_ident  hard_dependencies vid; self
     method! expression x : 'self_type  = 
@@ -42,11 +41,12 @@ class count_hard_dependencies =
               id)
        | _ -> ());
       super#expression x
-    method get_hard_dependencies = hard_dependencies
   end
 
 let calculate_hard_dependencies block = 
-  ((new count_hard_dependencies)#block block) # get_hard_dependencies
+  let hard_dependencies = create 17 in   
+  let _ : Js_fold.fold = (new count_hard_dependencies hard_dependencies)#block block in 
+  hard_dependencies
 
 (*
    Given a set of [variables], count which variables  [lam] will depend on

lib/4.06.1/unstable/js_compiler.ml

@@ -99248,10 +99248,9 @@ end = struct
 
 let add_lam_module_ident = Lam_module_ident.Hash_set.add
 let create = Lam_module_ident.Hash_set.create
-class count_hard_dependencies = 
+class count_hard_dependencies hard_dependencies = 
   object(self : 'self_type)
     inherit  Js_fold.fold as super
-    val hard_dependencies =  create 17
     method! module_id vid = 
         add_lam_module_ident  hard_dependencies vid; self
     method! expression x : 'self_type  = 
@@ -99263,11 +99262,12 @@ class count_hard_dependencies =
               id)
        | _ -> ());
       super#expression x
-    method get_hard_dependencies = hard_dependencies
   end
 
 let calculate_hard_dependencies block = 
-  ((new count_hard_dependencies)#block block) # get_hard_dependencies
+  let hard_dependencies = create 17 in   
+  let _ : Js_fold.fold = (new count_hard_dependencies hard_dependencies)#block block in 
+  hard_dependencies
 
 (*
    Given a set of [variables], count which variables  [lam] will depend on

lib/4.06.1/unstable/js_refmt_compiler.ml

@@ -99248,10 +99248,9 @@ end = struct
 
 let add_lam_module_ident = Lam_module_ident.Hash_set.add
 let create = Lam_module_ident.Hash_set.create
-class count_hard_dependencies = 
+class count_hard_dependencies hard_dependencies = 
   object(self : 'self_type)
     inherit  Js_fold.fold as super
-    val hard_dependencies =  create 17
     method! module_id vid = 
         add_lam_module_ident  hard_dependencies vid; self
     method! expression x : 'self_type  = 
@@ -99263,11 +99262,12 @@ class count_hard_dependencies =
               id)
        | _ -> ());
       super#expression x
-    method get_hard_dependencies = hard_dependencies
   end
 
 let calculate_hard_dependencies block = 
-  ((new count_hard_dependencies)#block block) # get_hard_dependencies
+  let hard_dependencies = create 17 in   
+  let _ : Js_fold.fold = (new count_hard_dependencies hard_dependencies)#block block in 
+  hard_dependencies
 
 (*
    Given a set of [variables], count which variables  [lam] will depend on

lib/4.06.1/whole_compiler.ml

@@ -381730,10 +381730,9 @@ end = struct
 
 let add_lam_module_ident = Lam_module_ident.Hash_set.add
 let create = Lam_module_ident.Hash_set.create
-class count_hard_dependencies = 
+class count_hard_dependencies hard_dependencies = 
   object(self : 'self_type)
     inherit  Js_fold.fold as super
-    val hard_dependencies =  create 17
     method! module_id vid = 
         add_lam_module_ident  hard_dependencies vid; self
     method! expression x : 'self_type  = 
@@ -381745,11 +381744,12 @@ class count_hard_dependencies =
               id)
        | _ -> ());
       super#expression x
-    method get_hard_dependencies = hard_dependencies
   end
 
 let calculate_hard_dependencies block = 
-  ((new count_hard_dependencies)#block block) # get_hard_dependencies
+  let hard_dependencies = create 17 in   
+  let _ : Js_fold.fold = (new count_hard_dependencies hard_dependencies)#block block in 
+  hard_dependencies
 
 (*
    Given a set of [variables], count which variables  [lam] will depend on