add needed runtime support for check exists

TODO: coordination from bsb
1. Adding a flag instead of change existing behavior (-bs-checkcmj)
2. Restat on ninja for build cmj, build cmi alone does not need it

Author: bobzhang

jscomp/compiler.ninja

@@ -330,7 +330,7 @@ build core/js_cmi_datasets.cmx : optc core/js_cmi_datasets.ml | ext/string_map.c
 build core/js_cmi_datasets.cmi : optc core/js_cmi_datasets.mli | ext/string_map.cmi
 build core/js_cmj_datasets.cmx : optc core/js_cmj_datasets.ml | ext/string_map.cmx core/js_cmj_format.cmx core/js_cmj_datasets.cmi
 build core/js_cmj_datasets.cmi : optc core/js_cmj_datasets.mli | ext/string_map.cmi core/js_cmj_format.cmi
-build core/js_cmj_format.cmx : optc core/js_cmj_format.ml | ext/string_map.cmx core/lam_arity.cmx core/lam.cmx core/js_packages_info.cmx ext/ext_string.cmx ext/ext_pervasives.cmx ext/ext_namespace.cmx core/js_cmj_format.cmi
+build core/js_cmj_format.cmx : optc core/js_cmj_format.ml | ext/string_map.cmx core/lam_constant.cmx core/lam_arity.cmx core/lam.cmx core/js_packages_info.cmx ext/ext_string.cmx ext/ext_pervasives.cmx ext/ext_namespace.cmx ext/ext_array.cmx core/js_cmj_format.cmi
 build core/js_cmj_format.cmi : optc core/js_cmj_format.mli | ext/string_map.cmi core/lam_arity.cmi core/lam.cmi core/js_packages_info.cmi ext/ext_namespace.cmi
 build core/js_cmj_load.cmx : optc core/js_cmj_load.ml | core/js_cmj_format.cmx core/config_util.cmx depends/bs_exception.cmx core/js_cmj_load.cmi
 build core/js_cmj_load.cmi : optc core/js_cmj_load.mli | core/js_cmj_format.cmi
@@ -388,7 +388,7 @@ build core/js_op_util.cmx : optc core/js_op_util.ml | core/js_op.cmx core/j.cmx
 build core/js_op_util.cmi : optc core/js_op_util.mli | core/js_op.cmx core/j.cmx
 build core/js_output.cmx : optc core/js_output.ml | core/lam_compile_context.cmx core/js_stmt_make.cmx core/js_exp_make.cmx core/js_dump.cmx core/js_analyzer.cmx core/j.cmx ext/ext_list.cmx core/js_output.cmi
 build core/js_output.cmi : optc core/js_output.mli | core/lam_compile_context.cmi core/j.cmx
-build core/js_packages_info.cmx : optc core/js_packages_info.ml | core/lam_module_ident.cmx ext/ext_sys.cmx ext/ext_string.cmx ext/ext_pervasives.cmx ext/ext_path.cmx ext/ext_namespace.cmx ext/ext_filename.cmx core/config_util.cmx depends/bs_exception.cmx core/js_packages_info.cmi
+build core/js_packages_info.cmx : optc core/js_packages_info.ml | core/lam_module_ident.cmx ext/ext_sys.cmx ext/ext_string.cmx ext/ext_pervasives.cmx ext/ext_path.cmx ext/ext_namespace.cmx ext/ext_list.cmx ext/ext_filename.cmx core/config_util.cmx depends/bs_exception.cmx core/js_packages_info.cmi
 build core/js_packages_info.cmi : optc core/js_packages_info.mli | core/lam_module_ident.cmi ext/ext_namespace.cmi
 build core/js_packages_state.cmx : optc core/js_packages_state.ml | core/js_packages_info.cmx ext/ext_pervasives.cmx ext/ext_namespace.cmx core/js_packages_state.cmi
 build core/js_packages_state.cmi : optc core/js_packages_state.mli | core/js_packages_info.cmi
@@ -411,7 +411,7 @@ build core/lam.cmx : optc core/lam.ml | core/lam_primitive.cmx core/lam_constant
 build core/lam.cmi : optc core/lam.mli | core/lam_primitive.cmi core/lam_constant.cmi core/lam_compat.cmi syntax/external_ffi_types.cmi syntax/external_arg_spec.cmi
 build core/lam_analysis.cmx : optc core/lam_analysis.ml | core/lam_constant.cmx core/lam.cmx ext/ext_list.cmx core/lam_analysis.cmi
 build core/lam_analysis.cmi : optc core/lam_analysis.mli | core/lam.cmi
-build core/lam_arity.cmx : optc core/lam_arity.ml | core/lam_arity.cmi
+build core/lam_arity.cmx : optc core/lam_arity.ml | ext/ext_list.cmx core/lam_arity.cmi
 build core/lam_arity.cmi : optc core/lam_arity.mli | 
 build core/lam_arity_analysis.cmx : optc core/lam_arity_analysis.ml | core/lam_stats.cmx core/lam_compile_env.cmx core/lam_arity.cmx core/lam.cmx ext/ident_hashtbl.cmx ext/ext_list.cmx core/lam_arity_analysis.cmi
 build core/lam_arity_analysis.cmi : optc core/lam_arity_analysis.mli | core/lam_stats.cmi core/lam_arity.cmi core/lam.cmi
@@ -636,7 +636,7 @@ build ext/ext.cmxa : archive ext/ext_array.cmx ext/ext_bytes.cmx ext/ext_char.cm
 build common/common.cmxa : archive common/bs_loc.cmx common/bs_version.cmx common/js_config.cmx common/bs_warnings.cmx common/ext_log.cmx common/lam_methname.cmx common/ml_binary.cmx
 build syntax/syntax.cmxa : archive syntax/bs_syntaxerr.cmx syntax/bs_ast_iterator.cmx syntax/ast_utf8_string.cmx syntax/ast_compatible.cmx syntax/ast_utf8_string_interp.cmx syntax/ast_literal.cmx syntax/ast_comb.cmx syntax/ast_core_type.cmx syntax/bs_ast_invariant.cmx syntax/ast_payload.cmx syntax/ast_attributes.cmx syntax/bs_ast_mapper.cmx syntax/external_arg_spec.cmx syntax/external_ffi_types.cmx syntax/ast_polyvar.cmx syntax/external_process.cmx syntax/ast_pat.cmx syntax/ast_external_mk.cmx syntax/ast_exp.cmx syntax/ast_util.cmx syntax/ast_core_type_class_type.cmx syntax/ast_signature.cmx syntax/ast_structure.cmx syntax/ast_derive.cmx syntax/ast_derive_util.cmx syntax/ast_derive_abstract.cmx syntax/ast_derive_constructor.cmx syntax/ast_derive_dyn.cmx syntax/ast_derive_js_mapper.cmx syntax/ast_derive_projector.cmx syntax/ast_tuple_pattern_flatten.cmx syntax/ast_exp_apply.cmx syntax/ast_exp_extension.cmx syntax/ast_lift.cmx syntax/ast_primitive.cmx syntax/ast_tdcls.cmx syntax/ppx_entry.cmx
 build depends/depends.cmxa : archive depends/bs_exception.cmx depends/ast_extract.cmx depends/binary_ast.cmx
-build core/core.cmxa : archive core/bs_conditional_initial.cmx core/config_util.cmx core/config_whole_compiler.cmx core/lam_tag_info.cmx core/lam_compat.cmx core/js_op.cmx core/js_fun_env.cmx core/js_closure.cmx core/js_call_info.cmx core/j.cmx core/js_fold.cmx core/js_analyzer.cmx core/lam_pointer_info.cmx core/lam_compile_util.cmx core/js_runtime_modules.cmx core/js_op_util.cmx core/js_exp_make.cmx core/js_arr.cmx core/js_stmt_make.cmx core/js_ast_util.cmx core/js_cmi_datasets.cmx core/lam_arity.cmx core/primitive_compat.cmx core/lam_primitive.cmx core/lam_constant.cmx core/lam.cmx core/lam_module_ident.cmx core/js_packages_info.cmx core/js_cmj_format.cmx core/js_cmj_datasets.cmx core/js_cmj_load.cmx core/js_number.cmx core/js_fold_basic.cmx core/js_dump_string.cmx core/js_dump_lit.cmx core/js_dump_property.cmx core/js_dump.cmx core/js_dump_import_export.cmx core/ocaml_types.cmx core/lam_compile_env.cmx core/js_packages_state.cmx core/js_name_of_module_id.cmx core/js_dump_program.cmx core/ocaml_parse.cmx core/lam_id_kind.cmx core/lam_stats.cmx core/lam_print.cmx core/lam_hit.cmx core/lam_analysis.cmx core/lam_util.cmx core/lam_inline_util.cmx core/lam_var_stats.cmx core/lam_closure.cmx core/lam_arity_analysis.cmx core/lam_stats_export.cmx core/js_of_lam_module.cmx core/lam_compile_global.cmx core/lam_bounded_vars.cmx core/lam_beta_reduce_util.cmx core/lam_beta_reduce.cmx core/lam_pass_remove_alias.cmx core/lam_free_variables.cmx core/lam_pass_eliminate_ref.cmx core/lam_pass_count.cmx core/lam_pass_lets_dce.cmx core/lam_subst.cmx core/lam_exit_count.cmx core/lam_pass_exits.cmx core/lam_group.cmx core/lam_pass_deep_flatten.cmx core/lam_pass_collect.cmx core/lam_eta_conversion.cmx core/lam_pass_alpha_conversion.cmx core/lam_scc.cmx core/lam_convert.cmx core/lam_compile_context.cmx core/lam_iter.cmx core/lam_exit_code.cmx core/js_of_lam_tuple.cmx core/js_of_lam_exception.cmx core/js_of_lam_array.cmx core/js_long.cmx core/lam_dispatch_primitive.cmx core/js_of_lam_string.cmx core/js_of_lam_block.cmx core/lam_compile_const.cmx core/js_of_lam_polyvar.cmx core/js_of_lam_variant.cmx core/js_of_lam_option.cmx core/lam_compile_external_call.cmx core/js_of_lam_float_record.cmx core/lam_compile_primitive.cmx core/lam_compile_external_obj.cmx core/js_output.cmx core/js_of_lam_record.cmx core/lam_compile.cmx core/lam_dce.cmx core/lam_coercion.cmx core/lam_check.cmx core/js_shake.cmx core/js_map.cmx core/js_pass_tailcall_inline.cmx core/js_pass_scope.cmx core/js_pass_flatten_and_mark_dead.cmx core/js_pass_flatten.cmx core/js_pass_debug.cmx core/lam_compile_main.cmx core/js_implementation.cmx core/lam_group_pass.cmx core/ocaml_batch_compile.cmx core/ocaml_options.cmx
+build core/core.cmxa : archive core/bs_conditional_initial.cmx core/config_util.cmx core/config_whole_compiler.cmx core/lam_tag_info.cmx core/lam_compat.cmx core/js_op.cmx core/js_fun_env.cmx core/js_closure.cmx core/js_call_info.cmx core/j.cmx core/js_fold.cmx core/js_analyzer.cmx core/lam_pointer_info.cmx core/lam_compile_util.cmx core/js_runtime_modules.cmx core/js_op_util.cmx core/js_exp_make.cmx core/js_arr.cmx core/js_stmt_make.cmx core/js_ast_util.cmx core/js_cmi_datasets.cmx core/lam_constant.cmx core/lam_arity.cmx core/primitive_compat.cmx core/lam_primitive.cmx core/lam.cmx core/lam_module_ident.cmx core/js_packages_info.cmx core/js_cmj_format.cmx core/js_cmj_datasets.cmx core/js_cmj_load.cmx core/js_number.cmx core/js_fold_basic.cmx core/js_dump_string.cmx core/js_dump_lit.cmx core/js_dump_property.cmx core/js_dump.cmx core/js_dump_import_export.cmx core/ocaml_types.cmx core/lam_compile_env.cmx core/js_packages_state.cmx core/js_name_of_module_id.cmx core/js_dump_program.cmx core/ocaml_parse.cmx core/lam_id_kind.cmx core/lam_stats.cmx core/lam_print.cmx core/lam_hit.cmx core/lam_analysis.cmx core/lam_util.cmx core/lam_inline_util.cmx core/lam_var_stats.cmx core/lam_closure.cmx core/lam_arity_analysis.cmx core/lam_stats_export.cmx core/js_of_lam_module.cmx core/lam_compile_global.cmx core/lam_bounded_vars.cmx core/lam_beta_reduce_util.cmx core/lam_beta_reduce.cmx core/lam_pass_remove_alias.cmx core/lam_free_variables.cmx core/lam_pass_eliminate_ref.cmx core/lam_pass_count.cmx core/lam_pass_lets_dce.cmx core/lam_subst.cmx core/lam_exit_count.cmx core/lam_pass_exits.cmx core/lam_group.cmx core/lam_pass_deep_flatten.cmx core/lam_pass_collect.cmx core/lam_eta_conversion.cmx core/lam_pass_alpha_conversion.cmx core/lam_scc.cmx core/lam_convert.cmx core/lam_compile_context.cmx core/lam_iter.cmx core/lam_exit_code.cmx core/js_of_lam_tuple.cmx core/js_of_lam_exception.cmx core/js_of_lam_array.cmx core/js_long.cmx core/lam_dispatch_primitive.cmx core/js_of_lam_string.cmx core/js_of_lam_block.cmx core/lam_compile_const.cmx core/js_of_lam_polyvar.cmx core/js_of_lam_variant.cmx core/js_of_lam_option.cmx core/lam_compile_external_call.cmx core/js_of_lam_float_record.cmx core/lam_compile_primitive.cmx core/lam_compile_external_obj.cmx core/js_output.cmx core/js_of_lam_record.cmx core/lam_compile.cmx core/lam_dce.cmx core/lam_coercion.cmx core/lam_check.cmx core/js_shake.cmx core/js_map.cmx core/js_pass_tailcall_inline.cmx core/js_pass_scope.cmx core/js_pass_flatten_and_mark_dead.cmx core/js_pass_flatten.cmx core/js_pass_debug.cmx core/lam_compile_main.cmx core/js_implementation.cmx core/lam_group_pass.cmx core/ocaml_batch_compile.cmx core/ocaml_options.cmx
 build super_errors/super_errors.cmxa : archive super_errors/super_warnings.cmx super_errors/super_misc.cmx super_errors/super_location.cmx super_errors/super_env.cmx super_errors/super_typetexp.cmx super_errors/super_reason_react.cmx super_errors/super_typemod.cmx super_errors/super_typecore.cmx super_errors/super_pparse.cmx super_errors/super_main.cmx
 build outcome_printer/outcome_printer.cmxa : archive outcome_printer/outcome_printer_ns.cmx outcome_printer/reason_syntax_util.cmx outcome_printer/tweaked_reason_oprint.cmx outcome_printer/reason_outcome_printer_main.cmx
 build bsb/bsb.cmxa : archive bsb/bsb_build_schemas.cmx bsb/bsb_log.cmx bsb/bsb_exception.cmx bsb/bsb_pkg.cmx bsb/bsb_build_util.cmx bsb/bsb_unix.cmx bsb/bsb_dir_index.cmx bsb/bsb_db.cmx bsb/bsb_file_groups.cmx bsb/bsb_config.cmx bsb/bsb_parse_sources.cmx bsb/bsb_clean.cmx bsb/bsb_watcher_gen.cmx bsb/bsb_warning.cmx bsb/bsb_package_specs.cmx bsb/bsb_config_types.cmx bsb/bsb_default.cmx bsb/bsb_config_parse.cmx bsb/bsb_file.cmx bsb/bsb_helper_dep_graph.cmx bsb/bsb_helper_depfile_gen.cmx bsb/bsb_helper_extract.cmx bsb/bsb_helper_linker.cmx bsb/bsb_helper_packer.cmx bsb/bsb_merlin_gen.cmx bsb/bsb_namespace_map_gen.cmx bsb/bsb_ninja_check.cmx bsb/bsb_rule.cmx bsb/bsb_ninja_util.cmx bsb/bsb_ninja_global_vars.cmx bsb/bsb_ninja_file_groups.cmx bsb/bsb_ninja_gen.cmx bsb/bsb_ninja_regen.cmx bsb/bsb_query.cmx bsb/bsb_regex.cmx bsb/oCamlRes.cmx bsb/bsb_templates.cmx bsb/bsb_theme_init.cmx bsb/bsb_world.cmx

jscomp/core/js_cmj_format.ml

@@ -24,7 +24,7 @@
 
 
 
-
+[@@@ocaml.warning "+9"]
 
 
 type arity = 
@@ -96,10 +96,52 @@ let from_string s : t =
       "cmj files have incompatible versions, please rebuilt using the new compiler : %s"
         __LOC__
 
-let to_file name (v : t) = 
-  let oc = open_out_bin name in 
-  output_string oc cmj_magic_number;
-  output_value oc v;
-  close_out oc 
+let rec for_sure_not_changed (name : string) ({npm_package_path ; effect; cmj_case ; values} : t) =   
+  if Sys.file_exists name then 
+    let data = from_file name in 
+    Js_packages_info.equal data.npm_package_path npm_package_path &&
+    for_sure_effect data.effect  effect &&
+    data.cmj_case = cmj_case &&
+    for_sure_equal data.values values
+  else false  
+and for_sure_effect (x : string option) (y : string option) = 
+  match x, y with   
+  | None, None -> true
+  | Some _, Some _ -> true  (* we dont care about what effect it has when making use of cmj*)
+  | None, Some _ -> false
+  | Some _, None -> false
+and for_sure_equal valuesa valuesb = 
+  String_map.equal fore_sure_cmj_value valuesa valuesb 
+and fore_sure_cmj_value (x : cmj_value) {arity; closed_lambda} =   
+  for_sure_arity x.arity arity &&
+  for_sure_eq_optional_lambda x.closed_lambda closed_lambda 
+and for_sure_arity  (x : arity) y = 
+  match x, y with 
+  | Single x0, Single y0 -> Lam_arity.equal x0 y0
+  | Submodule xs, Submodule ys -> 
+    Ext_array.for_all2_no_exn Lam_arity.equal xs ys 
+  | Single _, Submodule _ -> false
+  | Submodule _, Single _ -> false
+and for_sure_eq_optional_lambda 
+  (lama : Lam.t option)  lamb = 
+  match lama,lamb with 
+  | None, None -> true 
+  | None, Some _ 
+  | Some _ , None -> false
+  | Some a, Some b -> for_sure_lam a b 
+and for_sure_lam (a : Lam.t) (b : Lam.t) = 
+  match a, b with     
+  | Lconst a0, Lconst b0 -> 
+    Lam_constant.eq_approx a0 b0
+  | _, _ -> false 
+(* This may cause some build system always rebuild
+  maybe should not be turned on by default
+*) 
+let to_file name ~check_exists (v : t) = 
+  if  not (check_exists && for_sure_not_changed name v) then 
+    let oc = open_out_bin name in 
+    output_string oc cmj_magic_number;
+    output_value oc v;
+    close_out oc 
 
 

jscomp/core/js_cmj_format.mli

@@ -80,5 +80,8 @@ val no_pure_dummy : t
 val from_file : string -> t
 val from_string : string -> t
 
-val to_file : string -> t -> unit
+(* Note writing the file if its content is not chnaged  
+*)
+val to_file : 
+  string -> check_exists:bool -> t -> unit
 

jscomp/core/js_packages_info.ml

@@ -55,6 +55,13 @@ type t =
     name : package_name ;
     module_systems: package_info  list
   }
+[@@@ocaml.warning "+9"]
+let equal (x : t) ({name; module_systems}) = 
+    x.name = name && 
+    Ext_list.for_all2_no_exn
+      x.module_systems module_systems
+      (fun (a0,a1) (b0,b1) -> a0 = b0 && a1 = b1)
+
 (* we don't want force people to use package *) 
 
 (** 
@@ -72,8 +79,8 @@ let from_name name =
     module_systems = [] 
   }
 let is_empty  (x : t) =
-  match x with 
-  | { name = "_" } -> true 
+  match x.name with 
+  | "_"  -> true 
   | _ -> false 
 
 let string_of_module_system (ms : module_system) = 
@@ -143,9 +150,9 @@ let runtime_package_path =
 
 
 let get_js_path module_system 
-    ({module_systems } : t ) = 
+    (x : t ) = 
   match List.find (fun (k,_) -> 
-      compatible k  module_system) module_systems with
+      compatible k  module_system) x.module_systems with
   | (_, path) ->  path
   |  exception _ -> assert false
 

jscomp/core/js_packages_info.mli

@@ -53,7 +53,10 @@ val dump_packages_info :
 val add_npm_package_path : 
   string -> t -> t  
 
-
+(** Note here we compare the package info by order
+  in theory, we can compare it by set semantics
+*)
+val equal : t -> t -> bool 
 
 (**
    generate the mdoule path so that it can be spliced here:

jscomp/core/lam_arity.ml

@@ -33,6 +33,15 @@ type t =
   *)
   | Arity_na
 
+let equal (x : t ) y =     
+  match x with 
+  | Arity_na -> y = Arity_na 
+  | Arity_info (xs,a) -> 
+    begin match y with  
+      | Arity_info (ys,b) -> 
+        a = b && Ext_list.for_all2_no_exn xs ys (fun x y -> x =y)
+      | Arity_na -> false  
+    end
 let pp = Format.fprintf
 
 let print (fmt : Format.formatter) (x : t) = 

jscomp/core/lam_arity.mli

@@ -33,6 +33,7 @@ type t = private
    *)
   | Arity_na 
 
+val equal : t -> t -> bool  
 val print : Format.formatter -> t -> unit   
 
 val print_arities_tbl : 

jscomp/core/lam_compile_main.ml

@@ -277,6 +277,7 @@ let compile  ~filename (output_prefix : string) env _sigs
       in
       (if not @@ !Clflags.dont_write_files then
          Js_cmj_format.to_file 
+          ~check_exists:false
            (output_prefix ^ Literals.suffix_cmj) v);
       {J.program = program ; side_effect = v.effect ; modules = external_module_ids }      
     )