integrate unit tests with ninja build, test the workflow with refactoring of Ext_array.for_all2

Author: bobzhang

jscomp/core/js_cmj_format.ml

@@ -119,7 +119,7 @@ and for_sure_arity  (x : arity) y =
   match x, y with 
   | Single x0, Single y0 -> Lam_arity.equal x0 y0
   | Submodule xs, Submodule ys -> 
-    Ext_array.for_all2_no_exn Lam_arity.equal xs ys 
+    Ext_array.for_all2_no_exn  xs ys Lam_arity.equal
   | Single _, Submodule _ -> false
   | Submodule _, Single _ -> false
 and for_sure_eq_optional_lambda 

jscomp/ext/ext_array.ml

@@ -234,7 +234,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    

jscomp/ext/ext_array.mli

@@ -75,9 +75,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   

jscomp/ext/ext_json.ml

@@ -127,7 +127,7 @@ let rec equal
     begin match y with 
       | Arr {content = content2}
         ->
-        Ext_array.for_all2_no_exn equal content content2
+        Ext_array.for_all2_no_exn content content2 equal
       | _ -> false 
     end
 

jscomp/ext/ext_json_noloc.ml

@@ -82,7 +82,7 @@ let rec equal
     begin match y with 
       | Arr content2
         ->
-        Ext_array.for_all2_no_exn equal content content2
+        Ext_array.for_all2_no_exn content content2 equal 
       | _ -> false 
     end
 

jscomp/ounit_tests/ounit_array_tests.ml

@@ -61,29 +61,29 @@ let suites =
 
     __LOC__ >:: begin fun _ -> 
     OUnit.assert_bool __LOC__ 
-        (Ext_array.for_all2_no_exn
-        (=)
+        (Ext_array.for_all2_no_exn        
         [|1;2;3|]
         [|1;2;3|]
+        (=)
         )
     end;
     __LOC__ >:: begin fun _ -> 
     OUnit.assert_bool __LOC__
     (Ext_array.for_all2_no_exn
-    (=) [||] [||]
+    [||] [||] (=) 
     );
     OUnit.assert_bool __LOC__
     (not @@ Ext_array.for_all2_no_exn
-    (=) [||] [|1|]
+    [||] [|1|] (=) 
     )
     end
     ;
     __LOC__ >:: begin fun _ -> 
     OUnit.assert_bool __LOC__
-    (not (Ext_array.for_all2_no_exn
-        (=)
+    (not (Ext_array.for_all2_no_exn        
         [|1;2;3|]
         [|1;2;33|]
+        (=)
         ))
     end
     ]

lib/bsb.ml

@@ -225,9 +225,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   
@@ -477,7 +477,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    
@@ -2318,7 +2318,7 @@ let rec equal
     begin match y with 
       | Arr {content = content2}
         ->
-        Ext_array.for_all2_no_exn equal content content2
+        Ext_array.for_all2_no_exn content content2 equal
       | _ -> false 
     end
 
@@ -10939,7 +10939,7 @@ let rec equal
     begin match y with 
       | Arr content2
         ->
-        Ext_array.for_all2_no_exn equal content content2
+        Ext_array.for_all2_no_exn content content2 equal 
       | _ -> false 
     end
 

lib/bsb_helper.ml

@@ -262,9 +262,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   
@@ -514,7 +514,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    
@@ -2355,7 +2355,7 @@ let rec equal
     begin match y with 
       | Arr {content = content2}
         ->
-        Ext_array.for_all2_no_exn equal content content2
+        Ext_array.for_all2_no_exn content content2 equal
       | _ -> false 
     end
 

lib/bsdep.ml

@@ -29518,9 +29518,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   
@@ -29770,7 +29770,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    

lib/bsppx.ml

@@ -11456,9 +11456,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   
@@ -11708,7 +11708,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    

lib/whole_compiler.ml

@@ -26379,9 +26379,9 @@ val exists : ('a -> bool) -> 'a array -> bool
 val is_empty : 'a array -> bool 
 
 val for_all2_no_exn : 
-  ('a -> 'b -> bool) -> 
   'a array ->
   'b array -> 
+  ('a -> 'b -> bool) -> 
   bool
 
 val map :   
@@ -26631,7 +26631,7 @@ let rec unsafe_loop index len p xs ys  =
       (Array.unsafe_get ys index) &&
     unsafe_loop (succ index) len p xs ys 
 
-let for_all2_no_exn p xs ys = 
+let for_all2_no_exn xs ys p = 
   let len_xs = Array.length xs in 
   let len_ys = Array.length ys in 
   len_xs = len_ys &&    
@@ -68886,7 +68886,7 @@ and for_sure_arity  (x : arity) y =
   match x, y with 
   | Single x0, Single y0 -> Lam_arity.equal x0 y0
   | Submodule xs, Submodule ys -> 
-    Ext_array.for_all2_no_exn Lam_arity.equal xs ys 
+    Ext_array.for_all2_no_exn  xs ys Lam_arity.equal
   | Single _, Submodule _ -> false
   | Submodule _, Single _ -> false
 and for_sure_eq_optional_lambda 

scripts/tasks.js

@@ -20,7 +20,8 @@ var sourceDirs =
         'others',
         'stdlib-406',
         'runtime',
-        'test'
+        'test',
+        'ounit_tests'
     ]