Skip to content

Commit 62e43ec

Browse files
committed
renaming
1 parent e12e01a commit 62e43ec

7 files changed

+23
-25
lines changed

jscomp/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -295,13 +295,13 @@ BSB_SRCS= bsb_config \
295295
bsb_helper_linker\
296296
bsb_helper_extract\
297297
bsb_rule\
298-
bsb_ninja \
298+
bsb_ninja_util \
299299
bsb_parse_sources\
300300
bsb_default\
301301
bsb_bsdeps\
302302
bsb_watcher_gen\
303303
bsb_merlin_gen\
304-
bsb_gen\
304+
bsb_ninja_gen\
305305
bsb_file\
306306
bsb_config_types\
307307
bsb_config_parse\

jscomp/all.depend

+11-11
Original file line numberDiff line numberDiff line change
@@ -736,11 +736,6 @@ bsb/bsb_dir_index.cmx : bsb/bsb_dir_index.cmi
736736
bsb/bsb_exception.cmx : ext/ext_string.cmx ext/ext_position.cmx \
737737
ext/ext_json.cmx common/bs_version.cmx bsb/bsb_exception.cmi
738738
bsb/bsb_file.cmx : bsb/bsb_file.cmi
739-
bsb/bsb_gen.cmx : ext/string_map.cmx ext/literals.cmx ext/ext_string.cmx \
740-
ext/ext_list.cmx ext/ext_filename.cmx bsb/bsb_rule.cmx \
741-
bsb/bsb_parse_sources.cmx bsb/bsb_ninja.cmx bsb/bsb_dir_index.cmx \
742-
bsb/bsb_config_types.cmx bsb/bsb_config.cmx bsb/bsb_build_util.cmx \
743-
bsb/bsb_build_schemas.cmx common/binary_cache.cmx bsb/bsb_gen.cmi
744739
bsb/bsb_helper_dep_graph.cmx : ext/string_set.cmx ext/string_map.cmx \
745740
ext/string_hashtbl.cmx bsb/bsb_helper_dep_graph.cmi
746741
bsb/bsb_helper_extract.cmx : ext/string_set.cmx ext/ext_string.cmx \
@@ -760,18 +755,23 @@ bsb/bsb_init.cmx : ext/string_hashtbl.cmx bsb/oCamlRes.cmx \
760755
bsb/bsb_log.cmx : bsb/bsb_log.cmi
761756
bsb/bsb_main.cmx : ext/string_hash_set.cmx ext/literals.cmx ext/ext_sys.cmx \
762757
ext/ext_string.cmx ext/ext_filename.cmx ext/ext_color.cmx \
763-
ext/ext_array.cmx bsb/bsb_unix.cmx bsb/bsb_merlin_gen.cmx \
764-
bsb/bsb_init.cmx bsb/bsb_gen.cmx bsb/bsb_file.cmx \
758+
ext/ext_array.cmx bsb/bsb_unix.cmx bsb/bsb_ninja_gen.cmx \
759+
bsb/bsb_merlin_gen.cmx bsb/bsb_init.cmx bsb/bsb_file.cmx \
765760
bsb/bsb_config_types.cmx bsb/bsb_config_parse.cmx bsb/bsb_config.cmx \
766761
bsb/bsb_build_util.cmx bsb/bsb_bsdeps.cmx bsb/bsb_main.cmi
767762
bsb/bsb_merlin_gen.cmx : ext/literals.cmx ext/ext_string.cmx \
768763
ext/ext_filename.cmx bsb/bsb_parse_sources.cmx bsb/bsb_config_types.cmx \
769764
bsb/bsb_config.cmx bsb/bsb_merlin_gen.cmi
770-
bsb/bsb_ninja.cmx : ext/string_set.cmx ext/string_map.cmx \
765+
bsb/bsb_ninja_gen.cmx : ext/string_map.cmx ext/literals.cmx \
766+
ext/ext_string.cmx ext/ext_list.cmx ext/ext_filename.cmx bsb/bsb_rule.cmx \
767+
bsb/bsb_parse_sources.cmx bsb/bsb_ninja_util.cmx bsb/bsb_dir_index.cmx \
768+
bsb/bsb_config_types.cmx bsb/bsb_config.cmx bsb/bsb_build_util.cmx \
769+
bsb/bsb_build_schemas.cmx common/binary_cache.cmx bsb/bsb_ninja_gen.cmi
770+
bsb/bsb_ninja_util.cmx : ext/string_set.cmx ext/string_map.cmx \
771771
ext/string_hash_set.cmx ext/literals.cmx ext/ext_string.cmx \
772772
ext/ext_pervasives.cmx ext/ext_filename.cmx bsb/bsb_rule.cmx \
773773
bsb/bsb_parse_sources.cmx bsb/bsb_dir_index.cmx bsb/bsb_config.cmx \
774-
bsb/bsb_build_schemas.cmx common/binary_cache.cmx bsb/bsb_ninja.cmi
774+
bsb/bsb_build_schemas.cmx common/binary_cache.cmx bsb/bsb_ninja_util.cmi
775775
bsb/bsb_os_dependent.cmx :
776776
bsb/bsb_parse_sources.cmx : ext/string_vec.cmx ext/string_set.cmx \
777777
ext/string_map.cmx ext/ext_string.cmx ext/ext_json_types.cmx \
@@ -798,7 +798,6 @@ bsb/bsb_default.cmi : ext/string_set.cmi bsb/bsb_config_types.cmx
798798
bsb/bsb_dir_index.cmi :
799799
bsb/bsb_exception.cmi : ext/ext_position.cmi ext/ext_json_types.cmx
800800
bsb/bsb_file.cmi :
801-
bsb/bsb_gen.cmi : bsb/bsb_config_types.cmx
802801
bsb/bsb_helper_dep_graph.cmi : ext/string_set.cmi ext/string_map.cmi \
803802
ext/string_hashtbl.cmi
804803
bsb/bsb_helper_extract.cmi : ext/string_set.cmi
@@ -809,7 +808,8 @@ bsb/bsb_init.cmi :
809808
bsb/bsb_log.cmi :
810809
bsb/bsb_main.cmi :
811810
bsb/bsb_merlin_gen.cmi : bsb/bsb_config_types.cmx
812-
bsb/bsb_ninja.cmi : ext/string_map.cmi ext/string_hash_set.cmi \
811+
bsb/bsb_ninja_gen.cmi : bsb/bsb_config_types.cmx
812+
bsb/bsb_ninja_util.cmi : ext/string_map.cmi ext/string_hash_set.cmi \
813813
bsb/bsb_rule.cmi bsb/bsb_parse_sources.cmi bsb/bsb_config.cmi
814814
bsb/bsb_parse_sources.cmi : ext/string_set.cmi ext/ext_json_types.cmx \
815815
ext/ext_file_pp.cmi bsb/bsb_dir_index.cmi common/binary_cache.cmi

jscomp/bsb/bsb_main.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ let regenerate_ninja
190190
begin
191191
Bsb_merlin_gen.merlin_file_gen ~cwd
192192
(bsc_dir // bsppx_exe) config;
193-
Bsb_gen.output_ninja ~cwd ~bsc_dir config ;
193+
Bsb_ninja_gen.output_ninja ~cwd ~bsc_dir config ;
194194
Literals.bsconfig_json :: config.globbed_dirs
195195
|> List.map
196196
(fun x ->

jscomp/bsb/bsb_gen.ml jscomp/bsb/bsb_ninja_gen.ml

+8-8
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ let output_ninja
9696
| Some s ->
9797
"-ppx " ^ s
9898
in
99-
Bsb_ninja.output_kvs
99+
Bsb_ninja_util.output_kvs
100100
[|
101101
"src_root_dir", cwd (* TODO: need check its integrity -- allow relocate or not? *);
102102
"bsc", bsc ;
@@ -133,7 +133,7 @@ let output_ninja
133133
merge_module_info_map acc sources , dir::dirs , (List.map (fun x -> dir // x ) resources) @ acc_resources
134134
) (String_map.empty,[],[]) bs_file_groups in
135135
Binary_cache.write_build_cache (cwd // Bsb_config.lib_bs // Binary_cache.bsbuild_cache) [|bs_groups|] ;
136-
Bsb_ninja.output_kv
136+
Bsb_ninja_util.output_kv
137137
Bsb_build_schemas.bsc_lib_includes (Bsb_build_util.flag_concat dash_i @@
138138
(all_includes source_dirs )) oc ;
139139
static_resources
@@ -150,28 +150,28 @@ let output_ninja
150150
) [] bs_file_groups in
151151
(* Make sure [sources] does not have files in [lib] we have to check later *)
152152
let lib = bs_groups.((Bsb_dir_index.lib_dir_index :> int)) in
153-
Bsb_ninja.output_kv
153+
Bsb_ninja_util.output_kv
154154
Bsb_build_schemas.bsc_lib_includes (Bsb_build_util.flag_concat dash_i @@
155155
(all_includes source_dirs.(0))) oc ;
156156
for i = 1 to number_of_dev_groups do
157157
let c = bs_groups.(i) in
158158
String_map.iter (fun k _ -> if String_map.mem k lib then failwith ("conflict files found:" ^ k)) c ;
159-
Bsb_ninja.output_kv (Bsb_dir_index.(string_of_bsb_dev_include (of_int i)))
159+
Bsb_ninja_util.output_kv (Bsb_dir_index.(string_of_bsb_dev_include (of_int i)))
160160
(Bsb_build_util.flag_concat "-I" @@ source_dirs.(i)) oc
161161
done ;
162162
Binary_cache.write_build_cache (cwd // Bsb_config.lib_bs // Binary_cache.bsbuild_cache) bs_groups ;
163163
static_resources;
164164
in
165165
let all_info =
166-
Bsb_ninja.handle_file_groups oc
166+
Bsb_ninja_util.handle_file_groups oc
167167
~custom_rules
168-
~js_post_build_cmd ~package_specs ~files_to_install bs_file_groups Bsb_ninja.zero in
168+
~js_post_build_cmd ~package_specs ~files_to_install bs_file_groups Bsb_ninja_util.zero in
169169
let () =
170-
List.iter (fun x -> Bsb_ninja.output_build oc
170+
List.iter (fun x -> Bsb_ninja_util.output_build oc
171171
~output:x
172172
~input:(Bsb_config.proj_rel x)
173173
~rule:Bsb_rule.copy_resources) static_resources in
174-
Bsb_ninja.phony oc ~order_only_deps:(static_resources @ all_info.all_config_deps)
174+
Bsb_ninja_util.phony oc ~order_only_deps:(static_resources @ all_info.all_config_deps)
175175
~inputs:[]
176176
~output:Literals.build_ninja ;
177177
close_out oc;
File renamed without changes.
File renamed without changes.

jscomp/bsb/bsb_ninja.mli jscomp/bsb/bsb_ninja_util.mli

+1-3
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ val output_kvs : (string * string) array -> out_channel -> unit
5555

5656
type info = {
5757
all_config_deps : string list ;
58-
(*all_installs : string list *)
58+
5959
}
6060

6161
val zero : info
@@ -69,5 +69,3 @@ val handle_file_groups : out_channel ->
6969
Bsb_parse_sources.file_group list ->
7070
info -> info
7171

72-
(** TODO: need clean up when running across projects process *)
73-
(* val files_to_install : String_hash_set.t *)

0 commit comments

Comments
 (0)