Skip to content

Commit 466b70e

Browse files
bobzhangbobzhang
committed
remove unused code
Note take `length_object` for example, it is unknown, we can remove and inline it
1 parent 4864ecf commit 466b70e

12 files changed

+404
-751
lines changed

Diff for: ‎jscomp/core/js_record_iter.ml

+26-26
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11

2-
open J
3-
let unknown _ _ = ()
4-
let [@inline] option sub self = fun v ->
5-
match v with
6-
| None -> ()
7-
| Some v -> sub self v
8-
let rec list sub self = fun x ->
9-
match x with
10-
| [] -> ()
11-
| x::xs ->
12-
sub self x ;
13-
list sub self xs
2+
open J
3+
let unknown _ _ = ()
4+
let [@inline] option sub self = fun v ->
5+
match v with
6+
| None -> ()
7+
| Some v -> sub self v
8+
let rec list sub self = fun x ->
9+
match x with
10+
| [] -> ()
11+
| x::xs ->
12+
sub self x ;
13+
list sub self xs
1414

15-
type iter = {
16-
ident : ident fn;
15+
type iter = {
16+
ident : ident fn;
1717
module_id : module_id fn;
1818
vident : vident fn;
1919
expression : expression fn;
2020
statement : statement fn;
2121
variable_declaration : variable_declaration fn;
2222
block : block fn;
2323
program : program fn
24-
}
25-
and 'a fn = iter -> 'a -> unit
26-
let label : label fn = unknown
24+
}
25+
and 'a fn = iter -> 'a -> unit
26+
let label : label fn = unknown
2727
let ident : ident fn = unknown
2828
let module_id : module_id fn = fun _self { id = _x0;kind = _x1} -> begin _self.ident _self _x0 end
2929
let required_modules : required_modules fn = fun _self arg -> list _self.module_id _self arg
@@ -129,14 +129,14 @@ let variable_declaration : variable_declaration fn = fun _self { ident = _x0;
129129
let block : block fn = fun _self arg -> list _self.statement _self arg
130130
let program : program fn = fun _self { block = _x0;exports = _x1;export_set = _x2} -> begin _self.block _self _x0 end
131131
let deps_program : deps_program fn = fun _self { program = _x0;modules = _x1;side_effect = _x2} -> begin _self.program _self _x0;required_modules _self _x1 end
132-
let super : iter = {
133-
ident
134-
;module_id
135-
;vident
136-
;expression
137-
;statement
138-
;variable_declaration
139-
;block
140-
;program
132+
let super : iter = {
133+
ident;
134+
module_id;
135+
vident;
136+
expression;
137+
statement;
138+
variable_declaration;
139+
block;
140+
program
141141
}
142142

Diff for: ‎jscomp/core/js_record_map.ml

+54-55
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,43 @@
11

2-
open J
3-
let [@inline] unknown _ x = x
4-
let [@inline] option sub self = fun v ->
5-
match v with
6-
| None -> None
7-
| Some v -> Some (sub self v)
8-
let rec list sub self = fun x ->
9-
match x with
10-
| [] -> []
11-
| x::xs ->
12-
let v = sub self x in
13-
v ::list sub self xs
2+
open J
3+
let [@inline] unknown _ x = x
4+
let [@inline] option sub self = fun v ->
5+
match v with
6+
| None -> None
7+
| Some v -> Some (sub self v)
8+
let rec list sub self = fun x ->
9+
match x with
10+
| [] -> []
11+
| x::xs ->
12+
let v = sub self x in
13+
v :: list sub self xs
1414

15-
type iter = {
16-
ident : ident fn;
15+
type iter = {
16+
ident : ident fn;
1717
module_id : module_id fn;
1818
vident : vident fn;
1919
expression : expression fn;
2020
statement : statement fn;
2121
variable_declaration : variable_declaration fn;
2222
block : block fn;
2323
program : program fn
24-
}
25-
and 'a fn = iter -> 'a -> 'a
26-
let label : label fn = ( unknown )
27-
let ident : ident fn = ( unknown )
28-
let module_id : module_id fn = ( fun _self { id = _x0;kind = _x1} -> begin let _x0 = _self.ident _self _x0 in {id = _x0;kind = _x1} end )
29-
let required_modules : required_modules fn = ( fun _self arg -> list _self.module_id _self arg )
30-
let vident : vident fn = ( fun _self -> function
24+
}
25+
and 'a fn = iter -> 'a -> 'a
26+
let label : label fn = unknown
27+
let ident : ident fn = unknown
28+
let module_id : module_id fn = fun _self { id = _x0;kind = _x1} -> begin let _x0 = _self.ident _self _x0 in {id = _x0;kind = _x1} end
29+
let required_modules : required_modules fn = fun _self arg -> list _self.module_id _self arg
30+
let vident : vident fn = fun _self -> function
3131
| Id ( _x0) ->
3232
begin let _x0 = _self.ident _self _x0 in Id ( _x0) end
3333
|Qualified ( _x0,_x1) ->
34-
begin let _x0 = _self.module_id _self _x0 in Qualified ( _x0,_x1) end )
35-
let exception_ident : exception_ident fn = ( (fun _self arg -> _self.ident _self arg) )
36-
let for_ident : for_ident fn = ( (fun _self arg -> _self.ident _self arg) )
37-
let for_direction : for_direction fn = ( unknown )
38-
let property_map : property_map fn = ( fun _self arg -> list ((fun _self (_x0,_x1) -> begin let _x1 = _self.expression _self _x1 in (_x0,_x1) end)) _self arg )
39-
let length_object : length_object fn = ( unknown )
40-
let expression_desc : expression_desc fn = ( fun _self -> function
34+
begin let _x0 = _self.module_id _self _x0 in Qualified ( _x0,_x1) end
35+
let exception_ident : exception_ident fn = (fun _self arg -> _self.ident _self arg)
36+
let for_ident : for_ident fn = (fun _self arg -> _self.ident _self arg)
37+
let for_direction : for_direction fn = unknown
38+
let property_map : property_map fn = fun _self arg -> list ((fun _self (_x0,_x1) -> begin let _x1 = _self.expression _self _x1 in (_x0,_x1) end)) _self arg
39+
let length_object : length_object fn = unknown
40+
let expression_desc : expression_desc fn = fun _self -> function
4141
| Length ( _x0,_x1) ->
4242
begin let _x0 = _self.expression _self _x0 in
4343
let _x1 = length_object _self _x1 in Length ( _x0,_x1) end
@@ -103,13 +103,13 @@ let _x2 = _self.expression _self _x2 in Caml_block ( _x0,_x1,_x2,_x3) end
103103
|Object ( _x0) ->
104104
begin let _x0 = property_map _self _x0 in Object ( _x0) end
105105
|Undefined as v -> v
106-
|Null as v -> v )
107-
let for_ident_expression : for_ident_expression fn = ( (fun _self arg -> _self.expression _self arg) )
108-
let finish_ident_expression : finish_ident_expression fn = ( (fun _self arg -> _self.expression _self arg) )
109-
let case_clause : case_clause fn = ( fun _self { switch_body = _x0;should_break = _x1;comment = _x2} -> begin let _x0 = _self.block _self _x0 in {switch_body = _x0;should_break = _x1;comment = _x2} end )
110-
let string_clause : string_clause fn = ( (fun _self (_x0,_x1) -> begin let _x1 = case_clause _self _x1 in (_x0,_x1) end) )
111-
let int_clause : int_clause fn = ( (fun _self (_x0,_x1) -> begin let _x1 = case_clause _self _x1 in (_x0,_x1) end) )
112-
let statement_desc : statement_desc fn = ( fun _self -> function
106+
|Null as v -> v
107+
let for_ident_expression : for_ident_expression fn = (fun _self arg -> _self.expression _self arg)
108+
let finish_ident_expression : finish_ident_expression fn = (fun _self arg -> _self.expression _self arg)
109+
let case_clause : case_clause fn = fun _self { switch_body = _x0;should_break = _x1;comment = _x2} -> begin let _x0 = _self.block _self _x0 in {switch_body = _x0;should_break = _x1;comment = _x2} end
110+
let string_clause : string_clause fn = (fun _self (_x0,_x1) -> begin let _x1 = case_clause _self _x1 in (_x0,_x1) end)
111+
let int_clause : int_clause fn = (fun _self (_x0,_x1) -> begin let _x1 = case_clause _self _x1 in (_x0,_x1) end)
112+
let statement_desc : statement_desc fn = fun _self -> function
113113
| Block ( _x0) ->
114114
begin let _x0 = _self.block _self _x0 in Block ( _x0) end
115115
|Variable ( _x0) ->
@@ -149,23 +149,22 @@ let _x2 = option _self.block _self _x2 in String_switch ( _x0,_x1,_x2) end
149149
begin let _x0 = _self.block _self _x0 in
150150
let _x1 = option ((fun _self (_x0,_x1) -> begin let _x0 = exception_ident _self _x0 in let _x1 = _self.block _self _x1 in (_x0,_x1) end)) _self _x1 in
151151
let _x2 = option _self.block _self _x2 in Try ( _x0,_x1,_x2) end
152-
|Debugger as v -> v )
153-
let expression : expression fn = ( fun _self { expression_desc = _x0;comment = _x1} -> begin let _x0 = expression_desc _self _x0 in {expression_desc = _x0;comment = _x1} end )
154-
let statement : statement fn = ( fun _self { statement_desc = _x0;comment = _x1} -> begin let _x0 = statement_desc _self _x0 in {statement_desc = _x0;comment = _x1} end )
155-
let variable_declaration : variable_declaration fn = ( fun _self { ident = _x0;value = _x1;property = _x2;ident_info = _x3} -> begin let _x0 = _self.ident _self _x0 in
156-
let _x1 = option _self.expression _self _x1 in {ident = _x0;value = _x1;property = _x2;ident_info = _x3} end )
157-
let block : block fn = ( fun _self arg -> list _self.statement _self arg )
158-
let program : program fn = ( fun _self { block = _x0;exports = _x1;export_set = _x2} -> begin let _x0 = _self.block _self _x0 in {block = _x0;exports = _x1;export_set = _x2} end )
159-
let deps_program : deps_program fn = ( fun _self { program = _x0;modules = _x1;side_effect = _x2} -> begin let _x0 = _self.program _self _x0 in
160-
let _x1 = required_modules _self _x1 in {program = _x0;modules = _x1;side_effect = _x2} end )
161-
let super : iter = {
162-
ident
163-
;module_id
164-
;vident
165-
;expression
166-
;statement
167-
;variable_declaration
168-
;block
169-
;program
170-
}
171-
152+
|Debugger as v -> v
153+
let expression : expression fn = fun _self { expression_desc = _x0;comment = _x1} -> begin let _x0 = expression_desc _self _x0 in {expression_desc = _x0;comment = _x1} end
154+
let statement : statement fn = fun _self { statement_desc = _x0;comment = _x1} -> begin let _x0 = statement_desc _self _x0 in {statement_desc = _x0;comment = _x1} end
155+
let variable_declaration : variable_declaration fn = fun _self { ident = _x0;value = _x1;property = _x2;ident_info = _x3} -> begin let _x0 = _self.ident _self _x0 in
156+
let _x1 = option _self.expression _self _x1 in {ident = _x0;value = _x1;property = _x2;ident_info = _x3} end
157+
let block : block fn = fun _self arg -> list _self.statement _self arg
158+
let program : program fn = fun _self { block = _x0;exports = _x1;export_set = _x2} -> begin let _x0 = _self.block _self _x0 in {block = _x0;exports = _x1;export_set = _x2} end
159+
let deps_program : deps_program fn = fun _self { program = _x0;modules = _x1;side_effect = _x2} -> begin let _x0 = _self.program _self _x0 in
160+
let _x1 = required_modules _self _x1 in {program = _x0;modules = _x1;side_effect = _x2} end
161+
let super : iter = {
162+
ident;
163+
module_id;
164+
vident;
165+
expression;
166+
statement;
167+
variable_declaration;
168+
block;
169+
program
170+
}

0 commit comments

Comments
 (0)