Skip to content

Commit c58760f

Browse files
committed
Make JFR compile on z/OS
- ->system seems to be replaced by the compiler - = {0} initialization isn't supported by the compiler Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
1 parent 1a808c0 commit c58760f

5 files changed

+22
-22
lines changed

runtime/oti/j9nonbuilder.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,8 @@ typedef struct J9JFRCPULoad {
430430

431431
typedef struct J9JFRThreadCPULoad {
432432
J9JFR_EVENT_COMMON_FIELDS
433-
float user;
434-
float system;
433+
float userCPULoad;
434+
float systemCPULoad;
435435
} J9JFRThreadCPULoad;
436436

437437
typedef struct J9JFRClassLoadingStatistics {

runtime/vm/JFRChunkWriter.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -595,10 +595,10 @@ class VM_JFRChunkWriter {
595595
_bufferWriter->writeLEB128(entry->threadIndex);
596596

597597
/* write user thread CPU load */
598-
_bufferWriter->writeFloat(entry->user);
598+
_bufferWriter->writeFloat(entry->userCPULoad);
599599

600600
/* write system thread CPU load */
601-
_bufferWriter->writeFloat(entry->system);
601+
_bufferWriter->writeFloat(entry->systemCPULoad);
602602

603603
/* write size */
604604
_bufferWriter->writeLEB128PaddedU32(dataStart, _bufferWriter->getCursor() - dataStart);

runtime/vm/JFRConstantPoolTypes.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1130,8 +1130,8 @@ VM_JFRConstantPoolTypes::addThreadCPULoadEntry(J9JFRThreadCPULoad *threadCPULoad
11301130
}
11311131

11321132
entry->ticks = threadCPULoadData->startTicks;
1133-
entry->user = threadCPULoadData->user;
1134-
entry->system = threadCPULoadData->system;
1133+
entry->userCPULoad = threadCPULoadData->userCPULoad;
1134+
entry->systemCPULoad = threadCPULoadData->systemCPULoad;
11351135

11361136
entry->threadIndex = addThreadEntry(threadCPULoadData->vmThread);
11371137
if (isResultNotOKay()) {

runtime/vm/JFRConstantPoolTypes.hpp

+12-12
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ struct CPULoadEntry {
224224
struct ThreadCPULoadEntry {
225225
I_64 ticks;
226226
U_32 threadIndex;
227-
float user;
228-
float system;
227+
float userCPULoad;
228+
float systemCPULoad;
229229
};
230230

231231
struct ClassLoadingStatisticsEntry {
@@ -1268,47 +1268,47 @@ class VM_JFRConstantPoolTypes {
12681268
* zero is NULL threadGroup.
12691269
*/
12701270
_stringUTF8Count += 1;
1271-
_defaultStringUTF8Entry = {0};
1271+
memset(&_defaultStringUTF8Entry, 0, sizeof(_defaultStringUTF8Entry));
12721272
_defaultStringUTF8Entry.string = (J9UTF8*)&nullString;
12731273

12741274
_stringUTF8Count += 1;
1275-
_unknownClassStringUTF8Entry = {0};
1275+
memset(&_unknownClassStringUTF8Entry , 0, sizeof(_unknownClassStringUTF8Entry));
12761276
_unknownClassStringUTF8Entry.string = (J9UTF8*)&unknownClass;
12771277

12781278
_stringUTF8Count += 1;
1279-
_nativeMethodStringUTF8Entry = {0};
1279+
memset(&_nativeMethodStringUTF8Entry, 0, sizeof(_nativeMethodStringUTF8Entry));
12801280
_nativeMethodStringUTF8Entry.string = (J9UTF8*)&nativeMethod;
12811281

12821282
_stringUTF8Count += 1;
1283-
_nativeMethodSignatureStringUTF8Entry = {0};
1283+
memset(&_nativeMethodSignatureStringUTF8Entry, 0, sizeof(_nativeMethodSignatureStringUTF8Entry));
12841284
_nativeMethodSignatureStringUTF8Entry.string = (J9UTF8*)&nativeMethodSignature;
12851285

12861286
_moduleCount += 1;
1287-
_defaultModuleEntry = {0};
1287+
memset(&_defaultModuleEntry, 0, sizeof(_defaultModuleEntry));
12881288
_firstModuleEntry = &_defaultModuleEntry;
12891289
_previousModuleEntry = _firstModuleEntry;
12901290

12911291
_packageCount += 1;
1292-
_defaultPackageEntry = {0};
1292+
memset(&_defaultPackageEntry, 0, sizeof(_defaultPackageEntry));
12931293
_defaultPackageEntry.exported = TRUE;
12941294
_defaultPackageEntry.packageName = J9UTF8_DATA((J9UTF8*) &defaultPackage);
12951295
_defaultPackageEntry.packageNameLength = J9UTF8_LENGTH((J9UTF8*) &defaultPackage);
12961296
_firstPackageEntry = &_defaultPackageEntry;
12971297
_previousPackageEntry = _firstPackageEntry;
12981298

12991299
_threadGroupCount += 1;
1300-
_defaultThreadGroup = {0};
1300+
memset(&_defaultThreadGroup, 0, sizeof(_defaultThreadGroup));
13011301
_firstThreadGroupEntry = &_defaultThreadGroup;
13021302
_previousThreadGroupEntry = _firstThreadGroupEntry;
13031303

13041304
_classCount += 1;
1305-
_defaultClassEntry = {0};
1305+
memset(&_defaultClassEntry, 0, sizeof(_defaultClassEntry));
13061306
_defaultClassEntry.nameStringUTF8Index = (U_32)UnknownClass;
13071307
_firstClassEntry = &_defaultClassEntry;
13081308
_previousClassEntry = _firstClassEntry;
13091309

13101310
_methodCount += 1;
1311-
_defaultMethodEntry = {0};
1311+
memset(&_defaultMethodEntry, 0, sizeof(_defaultMethodEntry));
13121312
_defaultMethodEntry.nameStringUTF8Index = (U_32)NativeMethod;
13131313
_defaultMethodEntry.descriptorStringUTF8Index = (U_32)NativeMethodSignature;
13141314
/* default class */
@@ -1317,7 +1317,7 @@ class VM_JFRConstantPoolTypes {
13171317
_previousMethodEntry = _firstMethodEntry;
13181318

13191319
_stackTraceCount += 1;
1320-
_defaultStackTraceEntry = {0};
1320+
memset(&_defaultStackTraceEntry, 0, sizeof(_defaultStackTraceEntry));
13211321
_firstStackTraceEntry = &_defaultStackTraceEntry;
13221322
_previousStackTraceEntry = _firstStackTraceEntry;
13231323

runtime/vm/jfr.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -939,12 +939,12 @@ jfrThreadCPULoad(J9VMThread *currentThread, J9VMThread *sampleThread)
939939
int64_t currentTime = j9time_nano_time();
940940

941941
if (-1 == jfrState->prevTimestamp) {
942-
jfrEvent->user = 0;
943-
jfrEvent->system = 0;
942+
jfrEvent->userCPULoad = 0;
943+
jfrEvent->systemCPULoad = 0;
944944
} else {
945945
int64_t timeDelta = currentTime - jfrState->prevTimestamp;
946-
jfrEvent->user = OMR_MIN((threadTimes.userTime - jfrState->prevThreadCPUTimes.userTime) / (double)timeDelta, 1.0);
947-
jfrEvent->system = OMR_MIN((threadTimes.sysTime - jfrState->prevThreadCPUTimes.sysTime) / (double)timeDelta, 1.0);
946+
jfrEvent->userCPULoad = OMR_MIN((threadTimes.userTime - jfrState->prevThreadCPUTimes.userTime) / (double)timeDelta, 1.0);
947+
jfrEvent->systemCPULoad = OMR_MIN((threadTimes.sysTime - jfrState->prevThreadCPUTimes.sysTime) / (double)timeDelta, 1.0);
948948
}
949949
jfrState->prevTimestamp = currentTime;
950950
jfrState->prevThreadCPUTimes = threadTimes;

0 commit comments

Comments
 (0)