Skip to content

Commit 3f48ea9

Browse files
thalliumthallium
committed
Add triggerExecutionSample native
- Add JPP flag for JFR - Add com.ibm.oti.vm.VM::triggerExecutionSample that calls jfrExecutionSample on all Java threads - Add test for triggerExecutionSample Related: - ibmruntimes/openj9-openjdk-jdk#817 Depend on: - adoptium/TKG#589 Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
1 parent ab1ec9a commit 3f48ea9

File tree

17 files changed

+2490
-15
lines changed

17 files changed

+2490
-15
lines changed

‎.gitattributes

+5-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
# SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 OR GPL-2.0-only WITH OpenJDK-assembly-exception-1.0
2020

2121
# Binary files
22-
*.jpg git-encoding=BINARY working-tree-encoding=BINARY
23-
*.png git-encoding=BINARY working-tree-encoding=BINARY
24-
*.gif git-encoding=BINARY working-tree-encoding=BINARY
25-
*.zip git-encoding=BINARY working-tree-encoding=BINARY
22+
*.blob binary
23+
*.gif binary
24+
*.jpg binary
25+
*.png binary
26+
*.zip binary

‎jcl/jpp_configuration.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<!-- START SET DEFINITIONS -->
3838
<set
3939
label="newflags"
40-
flags="CRAC_SUPPORT,CRIU_SUPPORT,INLINE-TYPES,OPENJCEPLUS_SUPPORT,OPENJDK_METHODHANDLES"/>
40+
flags="CRAC_SUPPORT,CRIU_SUPPORT,INLINE-TYPES,JFR_SUPPORT,OPENJCEPLUS_SUPPORT,OPENJDK_METHODHANDLES"/>
4141

4242
<set
4343
label="oldflags"

‎jcl/src/java.base/share/classes/com/ibm/oti/vm/VM.java

+7
Original file line numberDiff line numberDiff line change
@@ -637,4 +637,11 @@ public static ConstantPool getConstantPoolFromAnnotationBytes(Class<?> clazz, by
637637
public static Properties internalGetProperties() {
638638
return getVMLangAccess().internalGetProperties();
639639
}
640+
641+
/*[IF JFR_SUPPORT]*/
642+
/**
643+
* Trigger ExecutionSample JFR event on all Java threads.
644+
*/
645+
public static native void triggerExecutionSample();
646+
/*[ENDIF] JFR_SUPPORT */
640647
}

‎jcl/src/java.base/share/classes/java/lang/System.java

+4
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,10 @@ private static void ensureProperties(boolean isInitialization) {
718718
/*[ENDIF] CRAC_SUPPORT */
719719
/*[ENDIF] CRIU_SUPPORT */
720720

721+
/*[IF JFR_SUPPORT]*/
722+
initializedProperties.put("org.eclipse.openj9.jfr.isJFREnabled", "true"); //$NON-NLS-1$ //$NON-NLS-2$
723+
/*[ENDIF] JFR_SUPPORT */
724+
721725
String[] list = getPropertyList();
722726
for (int i = 0; i < list.length; i += 2) {
723727
String key = list[i];

‎runtime/jcl/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ target_sources(jclse
113113
${CMAKE_CURRENT_SOURCE_DIR}/common/bpinit.c
114114
${CMAKE_CURRENT_SOURCE_DIR}/common/clsldr.cpp
115115
${CMAKE_CURRENT_SOURCE_DIR}/common/com_ibm_jvm_Stats.c
116-
${CMAKE_CURRENT_SOURCE_DIR}/common/com_ibm_oti_vm_VM.c
116+
${CMAKE_CURRENT_SOURCE_DIR}/common/com_ibm_oti_vm_VM.cpp
117117
${CMAKE_CURRENT_SOURCE_DIR}/common/compiler.c
118118
${CMAKE_CURRENT_SOURCE_DIR}/common/dump.c
119119
${CMAKE_CURRENT_SOURCE_DIR}/common/exhelp.c

‎runtime/jcl/common/com_ibm_oti_vm_VM.c ‎runtime/jcl/common/com_ibm_oti_vm_VM.cpp

+38-9
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,17 @@
2121
*******************************************************************************/
2222

2323
#include <string.h>
24-
#include "jni.h"
2524
#include "jcl.h"
2625
#include "jclglob.h"
2726
#include "jclprots.h"
28-
#include "jcl_internal.h"
27+
#include "jni.h"
28+
#include "omrlinkedlist.h"
2929
#include "util_api.h"
30+
#include "VMHelpers.hpp"
3031

31-
/* private static native byte[][] getVMArgsImpl(); */
32+
extern "C" {
3233

34+
/* private static native byte[][] getVMArgsImpl(); */
3335
jobjectArray JNICALL
3436
Java_com_ibm_oti_vm_VM_getVMArgsImpl(JNIEnv *env, jobject recv)
3537
{
@@ -53,9 +55,9 @@ Java_com_ibm_oti_vm_VM_getVMArgsImpl(JNIEnv *env, jobject recv)
5355

5456
/* Create the result array and fill it in, including only options that begin with "-" */
5557

56-
byteArrayClass = (*env)->FindClass(env, "[B");
58+
byteArrayClass = env->FindClass("[B");
5759
if (NULL != byteArrayClass) {
58-
result = (*env)->NewObjectArray(env, resultSize, byteArrayClass, NULL);
60+
result = env->NewObjectArray(resultSize, byteArrayClass, NULL);
5961
if (NULL != result) {
6062
jint writeIndex = 0;
6163

@@ -64,15 +66,15 @@ Java_com_ibm_oti_vm_VM_getVMArgsImpl(JNIEnv *env, jobject recv)
6466

6567
if ('-' == optionString[0]) {
6668
jint optionLength = (jint) strlen(optionString);
67-
jbyteArray option = (*env)->NewByteArray(env, optionLength);
69+
jbyteArray option = env->NewByteArray(optionLength);
6870

6971
if (NULL == option) {
7072
/* Don't use break here to avoid triggering the assertion below */
7173
return NULL;
7274
}
73-
(*env)->SetByteArrayRegion(env, option, 0, optionLength, (jbyte*)optionString);
74-
(*env)->SetObjectArrayElement(env, result, writeIndex, option);
75-
(*env)->DeleteLocalRef(env, option);
75+
env->SetByteArrayRegion(option, 0, optionLength, (jbyte*)optionString);
76+
env->SetObjectArrayElement(result, writeIndex, option);
77+
env->DeleteLocalRef(option);
7678
writeIndex += 1;
7779
}
7880
}
@@ -190,3 +192,30 @@ Java_com_ibm_oti_vm_VM_isJVMInSingleThreadedMode(JNIEnv *env, jclass unused)
190192
#endif /* defined(J9VM_OPT_CRIU_SUPPORT) */
191193
return result;
192194
}
195+
196+
#if defined(J9VM_OPT_JFR)
197+
void JNICALL
198+
Java_com_ibm_oti_vm_VM_triggerExecutionSample(JNIEnv *env, jclass unused) {
199+
J9VMThread *currentThread = (J9VMThread *)env;
200+
J9JavaVM *vm = currentThread->javaVM;
201+
J9InternalVMFunctions *vmFuncs = vm->internalVMFunctions;
202+
203+
vmFuncs->internalEnterVMFromJNI(currentThread);
204+
vmFuncs->acquireExclusiveVMAccess(currentThread);
205+
206+
J9VMThread *walkThread = J9_LINKED_LIST_START_DO(vm->mainThread);
207+
while (NULL != walkThread) {
208+
if (VM_VMHelpers::threadCanRunJavaCode(walkThread)
209+
&& (currentThread != walkThread)
210+
) {
211+
vmFuncs->jfrExecutionSample(currentThread, walkThread);
212+
}
213+
walkThread = J9_LINKED_LIST_NEXT_DO(vm->mainThread, walkThread);
214+
}
215+
216+
vmFuncs->releaseExclusiveVMAccess(currentThread);
217+
vmFuncs->internalExitVMToJNI(currentThread);
218+
}
219+
#endif /* defined(J9VM_OPT_JFR) */
220+
221+
} /* extern "C" */

‎runtime/jcl/exports.cmake

+6
Original file line numberDiff line numberDiff line change
@@ -687,6 +687,12 @@ if(J9VM_OPT_CRIU_SUPPORT)
687687
endif()
688688
endif()
689689

690+
if(J9VM_OPT_JFR)
691+
omr_add_exports(jclse
692+
Java_com_ibm_oti_vm_VM_triggerExecutionSample
693+
)
694+
endif()
695+
690696
# Java 19 only
691697
if(JAVA_SPEC_VERSION EQUAL 19)
692698
omr_add_exports(jclse

‎runtime/jcl/module.xml

+4
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex
4444
<xi:include href="uma/se19only_exports.xml"></xi:include>
4545
<xi:include href="uma/se19_exports.xml"></xi:include>
4646
<xi:include href="uma/se20_exports.xml"></xi:include>
47+
<xi:include href="uma/jfr_exports.xml"></xi:include>
4748

4849
<xi:include href="uma/vendor_jcl_exports.xml">
4950
<xi:fallback/>
@@ -140,6 +141,9 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex
140141
<group name="se20">
141142
<include-if condition="spec.java20"/>
142143
</group>
144+
<group name="jfr">
145+
<include-if condition="spec.flags.opt_jfr"/>
146+
</group>
143147
</exports>
144148

145149
<includes>

‎runtime/jcl/uma/jfr_exports.xml

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<!--
2+
Copyright IBM Corp. and others 2024
3+
4+
This program and the accompanying materials are made available under
5+
the terms of the Eclipse Public License 2.0 which accompanies this
6+
distribution and is available at https://www.eclipse.org/legal/epl-2.0/
7+
or the Apache License, Version 2.0 which accompanies this distribution and
8+
is available at https://www.apache.org/licenses/LICENSE-2.0.
9+
10+
This Source Code may also be made available under the following
11+
Secondary Licenses when the conditions for such availability set
12+
forth in the Eclipse Public License, v. 2.0 are satisfied: GNU
13+
General Public License, version 2 with the GNU Classpath
14+
Exception [1] and GNU General Public License, version 2 with the
15+
OpenJDK Assembly Exception [2].
16+
17+
[1] https://www.gnu.org/software/classpath/license.html
18+
[2] https://openjdk.org/legal/assembly-exception.html
19+
20+
SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 OR GPL-2.0-only WITH OpenJDK-assembly-exception-1.0
21+
-->
22+
<exports group="jfr">
23+
<export name="Java_com_ibm_oti_vm_VM_triggerExecutionSample" />
24+
</exports>

‎runtime/oti/j9nonbuilder.h

+3
Original file line numberDiff line numberDiff line change
@@ -5184,6 +5184,9 @@ typedef struct J9InternalVMFunctions {
51845184
#if defined(J9VM_ZOS_3164_INTEROPERABILITY) && (JAVA_SPEC_VERSION >= 17)
51855185
I_32 (*invoke31BitJNI_OnXLoad)(struct J9JavaVM *vm, void *handle, jboolean isOnLoad, void *reserved);
51865186
#endif /* defined(J9VM_ZOS_3164_INTEROPERABILITY) && (JAVA_SPEC_VERSION >= 17) */
5187+
#if defined(J9VM_OPT_JFR)
5188+
void (*jfrExecutionSample)(struct J9VMThread *currentThread, struct J9VMThread *sampleThread);
5189+
#endif /* defined(J9VM_OPT_JFR) */
51875190
} J9InternalVMFunctions;
51885191

51895192
/* Jazz 99339: define a new structure to replace JavaVM so as to pass J9NativeLibrary to JVMTIEnv */

‎runtime/oti/jclprots.h

+5
Original file line numberDiff line numberDiff line change
@@ -1269,6 +1269,11 @@ Java_com_ibm_oti_vm_VM_getJ9ConstantPoolFromJ9Class(JNIEnv *env, jclass unused,
12691269
jboolean JNICALL
12701270
Java_com_ibm_oti_vm_VM_isJVMInSingleThreadedMode(JNIEnv *env, jclass unused);
12711271

1272+
#if defined(J9VM_OPT_JFR)
1273+
void JNICALL
1274+
Java_com_ibm_oti_vm_VM_triggerExecutionSample(JNIEnv *env, jclass unused);
1275+
#endif /* defined(J9VM_OPT_JFR) */
1276+
12721277
#if JAVA_SPEC_VERSION >= 16
12731278
jboolean JNICALL
12741279
Java_java_lang_ref_Reference_refersTo(JNIEnv *env, jobject reference, jobject target);

‎runtime/vm/intfunc.c

+4
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
#include "j9protos.h"
2424
#include "vm_api.h"
25+
#include "vm_internal.h"
2526
#if defined(J9VM_OPT_VM_LOCAL_STORAGE)
2627

2728
#include "j9vmls.h"
@@ -454,4 +455,7 @@ J9InternalVMFunctions J9InternalFunctions = {
454455
#if defined(J9VM_ZOS_3164_INTEROPERABILITY) && (JAVA_SPEC_VERSION >= 17)
455456
invoke31BitJNI_OnXLoad,
456457
#endif /* defined(J9VM_ZOS_3164_INTEROPERABILITY) && (JAVA_SPEC_VERSION >= 17) */
458+
#if defined(J9VM_OPT_JFR)
459+
jfrExecutionSample,
460+
#endif /* defined(J9VM_OPT_JFR) */
457461
};

‎test/functional/cmdLineTests/jfr/build.xml

+87
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
<?xml version="1.0"?>
2+
3+
<!--
4+
Copyright IBM Corp. and others 2024
5+
6+
This program and the accompanying materials are made available under
7+
the terms of the Eclipse Public License 2.0 which accompanies this
8+
distribution and is available at https://www.eclipse.org/legal/epl-2.0/
9+
or the Apache License, Version 2.0 which accompanies this distribution and
10+
is available at https://www.apache.org/licenses/LICENSE-2.0.
11+
12+
This Source Code may also be made available under the following
13+
Secondary Licenses when the conditions for such availability set
14+
forth in the Eclipse Public License, v. 2.0 are satisfied: GNU
15+
General Public License, version 2 with the GNU Classpath
16+
Exception [1] and GNU General Public License, version 2 with the
17+
OpenJDK Assembly Exception [2].
18+
19+
[1] https://www.gnu.org/software/classpath/license.html
20+
[2] https://openjdk.org/legal/assembly-exception.html
21+
22+
SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 OR GPL-2.0-only WITH OpenJDK-assembly-exception-1.0
23+
-->
24+
<project name="jfr" default="build" basedir=".">
25+
<taskdef resource="net/sf/antcontrib/antlib.xml" />
26+
<description>
27+
Build cmdLineTests_jfr
28+
</description>
29+
30+
<import file="${TEST_ROOT}/functional/cmdLineTests/buildTools.xml" />
31+
32+
<!-- set properties for this build -->
33+
<property name="DEST" value="${BUILD_ROOT}/functional/cmdLineTests/jfr" />
34+
<property name="src" location="src" />
35+
<property name="build" location="bin" />
36+
37+
<condition property="jfrEnabled">
38+
<and>
39+
<contains string="${TEST_FLAG}" substring="JFR" />
40+
<!-- For the time being, JFR tests are only limited to JDK17+. -->
41+
<not>
42+
<matches string="${JDK_VERSION}" pattern="^(8|9|1[0-6])$$" />
43+
</not>
44+
</and>
45+
</condition>
46+
47+
<target name="init">
48+
<mkdir dir="${DEST}" />
49+
<mkdir dir="${build}" />
50+
</target>
51+
52+
<target name="compile" depends="init" description="Using java ${JDK_VERSION} to compile the source" if="jfrEnabled">
53+
<echo>Ant version is ${ant.version}</echo>
54+
<echo>============COMPILER SETTINGS============</echo>
55+
<echo>===fork: yes</echo>
56+
<echo>===executable: ${compiler.javac}</echo>
57+
<echo>===debug: on</echo>
58+
<echo>===destdir: ${DEST}</echo>
59+
<javac srcdir="${src}" destdir="${build}" debug="true" fork="true" executable="${compiler.javac}" includeAntRuntime="false" encoding="ISO-8859-1">
60+
<compilerarg line="--add-exports java.base/com.ibm.oti.vm=ALL-UNNAMED" />
61+
<src path="${src}" />
62+
</javac>
63+
</target>
64+
65+
<target name="dist" depends="compile" description="generate the distribution">
66+
<jar jarfile="${DEST}/jfr.jar" filesonly="true">
67+
<fileset dir="${build}" />
68+
<fileset dir="${src}" />
69+
</jar>
70+
<copy todir="${DEST}">
71+
<fileset dir="${src}/../">
72+
<filename name="metadata.blob" />
73+
<filename name="*.mk" />
74+
<filename name="*.xml" />
75+
</fileset>
76+
</copy>
77+
</target>
78+
79+
<target name="clean" depends="dist" description="clean up">
80+
<!-- Delete the ${build} directory trees -->
81+
<delete dir="${build}" />
82+
</target>
83+
84+
<target name="build" depends="buildCmdLineTestTools">
85+
<antcall target="clean" inheritall="true" />
86+
</target>
87+
</project>

‎test/functional/cmdLineTests/jfr/jfr.xml

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
2+
3+
<!--
4+
Copyright IBM Corp. and others 2024
5+
6+
This program and the accompanying materials are made available under
7+
the terms of the Eclipse Public License 2.0 which accompanies this
8+
distribution and is available at https://www.eclipse.org/legal/epl-2.0/
9+
or the Apache License, Version 2.0 which accompanies this distribution and
10+
is available at https://www.apache.org/licenses/LICENSE-2.0.
11+
12+
This Source Code may also be made available under the following
13+
Secondary Licenses when the conditions for such availability set
14+
forth in the Eclipse Public License, v. 2.0 are satisfied: GNU
15+
General Public License, version 2 with the GNU Classpath
16+
Exception [1] and GNU General Public License, version 2 with the
17+
OpenJDK Assembly Exception [2].
18+
19+
[1] https://www.gnu.org/software/classpath/license.html
20+
[2] https://openjdk.org/legal/assembly-exception.html
21+
22+
SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 OR GPL-2.0-only WITH OpenJDK-assembly-exception-1.0
23+
-->
24+
25+
<!DOCTYPE suite SYSTEM "cmdlinetester.dtd">
26+
27+
<suite id="JFR Tests" timeout="300">
28+
<envvar name="OPENJ9_METADATA_BLOB_FILE_PATH" value="$METADATA_BLOB_PATH$" />
29+
<test id="triggerExecutionSample">
30+
<command>$EXE$ -XX:+FlightRecorder --add-exports java.base/com.ibm.oti.vm=ALL-UNNAMED -cp $RESJAR$ org.openj9.test.TriggerExecutionSample</command>
31+
<return type="success" value="0" />
32+
</test>
33+
</suite>

0 commit comments

Comments
 (0)