Skip to content

Commit bf5a4bf

Browse files
identorgaearon
authored andcommitted
Feed correct line number to gvim on launch (#5202)
Clicking Error overlay should feed the correct line number for gvim. Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running. Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM Relates to #2636.
1 parent b103376 commit bf5a4bf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/react-dev-utils/launchEditor.js

+2
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = {
6767
code: 'code',
6868
'code-insiders': 'code-insiders',
6969
emacs: 'emacs',
70+
gvim: 'gvim',
7071
'idea.sh': 'idea',
7172
'phpstorm.sh': 'phpstorm',
7273
'pycharm.sh': 'pycharm',
@@ -136,6 +137,7 @@ function getArgumentsForLineNumber(
136137
case 'vim':
137138
case 'mvim':
138139
case 'joe':
140+
case 'gvim':
139141
return ['+' + lineNumber, fileName];
140142
case 'emacs':
141143
case 'emacsclient':

0 commit comments

Comments
 (0)