Skip to content

Commit bc9edfa

Browse files
committed
Hide --internal-testing-template (former --template) CLI option
1 parent c5805c2 commit bc9edfa

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

packages/create-react-app/index.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ if (currentNodeVersion.split('.')[0] < 4) {
5252
process.exit(1);
5353
}
5454

55+
var commander = require('commander');
5556
var fs = require('fs-extra');
5657
var path = require('path');
5758
var execSync = require('child_process').execSync;
@@ -60,7 +61,7 @@ var semver = require('semver');
6061

6162
var projectName;
6263

63-
var program = require('commander')
64+
var program = commander
6465
.version(require('./package.json').version)
6566
.arguments('<project-directory>')
6667
.usage(chalk.green('<project-directory>') + ' [options]')
@@ -69,7 +70,7 @@ var program = require('commander')
6970
})
7071
.option('--verbose', 'print additional logs')
7172
.option('--scripts-version <alternative-package>', 'use a non-standard version of react-scripts')
72-
.option('--template <path-to-template>', 'use a non-standard application template')
73+
.allowUnknownOption()
7374
.on('--help', function () {
7475
console.log(' Only ' + chalk.green('<project-directory>') + ' is required.');
7576
console.log();
@@ -96,7 +97,12 @@ if (typeof projectName === 'undefined') {
9697
process.exit(1);
9798
}
9899

99-
createApp(projectName, program.verbose, program.scriptsVersion, program.template);
100+
var hiddenProgram = new commander.Command()
101+
.option('--internal-testing-template <path-to-template>', '(internal usage only, DO NOT RELY ON THIS) ' +
102+
'use a non-standard application template')
103+
.parse(process.argv)
104+
105+
createApp(projectName, program.verbose, program.scriptsVersion, hiddenProgram.internalTestingTemplate);
100106

101107
function createApp(name, verbose, version, template) {
102108
var root = path.resolve(name);

tasks/e2e-kitchensink.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ npm install $cli_path
113113

114114
# Install the app in a temporary location
115115
cd $temp_app_path
116-
create_react_app --scripts-version=$scripts_path --template=$root_path/packages/react-scripts/fixtures/kitchensink test-kitchensink
116+
create_react_app --scripts-version=$scripts_path --internal-testing-template=$root_path/packages/react-scripts/fixtures/kitchensink test-kitchensink
117117

118118
# ******************************************************************************
119119
# Now that we used create-react-app to create an app depending on react-scripts,

0 commit comments

Comments
 (0)