Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: facchinm/arduino-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: use_cached_objs_long_commandlines
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 8 files changed
  • 2 contributors

Commits on Dec 20, 2023

  1. Reuse archiveCompiledFiles helper for long commandline shrink 

    Since archiveCompiledFiles already handles hot cache correctly, this avoids objs.a being rebuilt even if files don't change.

Would be ideal if PathList could expose a generic Filter API (to get rid of the "duplicated" filter)
    @facchinm @cmaglie
    facchinm authored and cmaglie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c2b4d5c View commit details
    Browse the repository at this point in the history

  2. Upgrade go-paths / remove duplicate filter function

    @cmaglie
    cmaglie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7af3197 View commit details
    Browse the repository at this point in the history

  3. Consider existing archives during the build

    @cmaglie
    cmaglie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    06e3e7f View commit details
    Browse the repository at this point in the history

  4. Simplified archiveCompiledFiles function signature 

    It doesn't make sense anymore to keep path and filename separated.
    @cmaglie
    cmaglie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    916e795 View commit details
    Browse the repository at this point in the history

  5. Added integration test

    @cmaglie
    cmaglie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    373e871 View commit details
    Browse the repository at this point in the history
Loading