JAVA-1871: Change LOCAL_SERIAL.isDCLocal() to return true (apache#1070)

Author: tolbertam

changelog/README.md

@@ -11,6 +11,7 @@
 - [bug] JAVA-1924: StatementWrapper setters should return the wrapping statement.
 - [new feature] JAVA-1532: Add Codec support for Java 8's LocalDateTime and ZoneId.
 - [improvement] JAVA-1786: Use Google code formatter.
+- [bug] JAVA-1871: Change LOCAL\_SERIAL.isDCLocal() to return true.
 
 Merged from 3.5.x:
 

driver-core/src/main/java/com/datastax/driver/core/ConsistencyLevel.java

@@ -57,10 +57,11 @@ static ConsistencyLevel fromCode(int code) {
   /**
    * Whether or not this consistency level applies to the local data-center only.
    *
-   * @return whether this consistency level is {@code LOCAL_ONE} or {@code LOCAL_QUORUM}.
+   * @return whether this consistency level is {@code LOCAL_ONE}, {@code LOCAL_QUORUM}, or {@code
+   *     LOCAL_SERIAL}.
    */
   public boolean isDCLocal() {
-    return this == LOCAL_ONE || this == LOCAL_QUORUM;
+    return this == LOCAL_ONE || this == LOCAL_QUORUM || this == LOCAL_SERIAL;
   }
 
   /**

upgrade_guide/README.md

@@ -3,6 +3,13 @@
 The purpose of this guide is to detail changes made by successive
 versions of the Java driver.
 
+### 3.6.0
+
+1.  `ConsistencyLevel.LOCAL_SERIAL.isDCLocal()` now returns true. In driver
+    code, `isDCLocal()` is only used when evaluating a Statement's
+    ConsistencyLevel (which does not include Serial CLs), but as a matter of
+    correctness this was updated.
+
 ### 3.5.0
 
 1.  The `DowngradingConsistencyRetryPolicy` is now deprecated, see [JAVA-1752].