From 6f3d596684d83079ce9527634a356e910e8216ed Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Mon, 19 Feb 2024 21:51:58 -0300 Subject: [PATCH 1/3] Fix: adds RMT new function to io_pin_remap list --- cores/esp32/io_pin_remap.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cores/esp32/io_pin_remap.h b/cores/esp32/io_pin_remap.h index 63fb16cefd0..e7f6fd37d66 100644 --- a/cores/esp32/io_pin_remap.h +++ b/cores/esp32/io_pin_remap.h @@ -76,6 +76,7 @@ int8_t gpioNumberToDigitalPin(int8_t gpioNumber); // cores/esp32/esp32-hal-rmt.h #define rmtInit(pin, channel_direction, memsize, frequency_Hz) rmtInit(digitalPinToGPIONumber(pin), channel_direction, memsize, frequency_Hz) +#define rmtSetEOT(int pin, EOT_Level) rmtSetEOT(digitalPinToGPIONumber(pin), EOT_Level) #define rmtWrite(pin, data, num_rmt_symbols, timeout_ms) rmtWrite(digitalPinToGPIONumber(pin), data, num_rmt_symbols, timeout_ms) #define rmtWriteAsync(pin, data, num_rmt_symbols) rmtWriteAsync(digitalPinToGPIONumber(pin), data, num_rmt_symbols) #define rmtWriteLooping(pin, data, num_rmt_symbols) rmtWriteLooping(digitalPinToGPIONumber(pin), data, num_rmt_symbols) From 4b5be1952161e9b118f89113723de587878171b2 Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Mon, 19 Feb 2024 21:55:03 -0300 Subject: [PATCH 2/3] Fix: adds rmtSetEOT(int pin, uint8_t EOT_Level) to the new API list --- docs/en/migration_guides/2.x_to_3.0.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/en/migration_guides/2.x_to_3.0.rst b/docs/en/migration_guides/2.x_to_3.0.rst index 3ccbfba5ffb..452a7fb21b4 100644 --- a/docs/en/migration_guides/2.x_to_3.0.rst +++ b/docs/en/migration_guides/2.x_to_3.0.rst @@ -90,6 +90,7 @@ Removed APIs New APIs ******** +* ``rmtSetEOT`` * ``rmtWriteAsync`` * ``rmtTransmitCompleted`` * ``rmtSetRxMinThreshold`` From e00ac1def66f8b3d05a3d0071b16ecd39c25e31a Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Mon, 19 Feb 2024 21:57:59 -0300 Subject: [PATCH 3/3] Fix: error in macro definition - left over from function signature --- cores/esp32/io_pin_remap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cores/esp32/io_pin_remap.h b/cores/esp32/io_pin_remap.h index e7f6fd37d66..9f09e2b8de2 100644 --- a/cores/esp32/io_pin_remap.h +++ b/cores/esp32/io_pin_remap.h @@ -76,7 +76,7 @@ int8_t gpioNumberToDigitalPin(int8_t gpioNumber); // cores/esp32/esp32-hal-rmt.h #define rmtInit(pin, channel_direction, memsize, frequency_Hz) rmtInit(digitalPinToGPIONumber(pin), channel_direction, memsize, frequency_Hz) -#define rmtSetEOT(int pin, EOT_Level) rmtSetEOT(digitalPinToGPIONumber(pin), EOT_Level) +#define rmtSetEOT(pin, EOT_Level) rmtSetEOT(digitalPinToGPIONumber(pin), EOT_Level) #define rmtWrite(pin, data, num_rmt_symbols, timeout_ms) rmtWrite(digitalPinToGPIONumber(pin), data, num_rmt_symbols, timeout_ms) #define rmtWriteAsync(pin, data, num_rmt_symbols) rmtWriteAsync(digitalPinToGPIONumber(pin), data, num_rmt_symbols) #define rmtWriteLooping(pin, data, num_rmt_symbols) rmtWriteLooping(digitalPinToGPIONumber(pin), data, num_rmt_symbols)