Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is still a typo in camera_index.h OV2460 -> OV2640 #10906

Closed
beta-tester opened this issue Jan 26, 2025 · 1 comment · Fixed by #11145
Closed

there is still a typo in camera_index.h OV2460 -> OV2640 #10906

beta-tester opened this issue Jan 26, 2025 · 1 comment · Fixed by #11145

Comments

@beta-tester
Copy link

beta-tester commented Jan 26, 2025 •
edited
Loading

like described in issue #7461, there is still a typo in the file.
but that issue was closed, because of its age (#10838), with comment - to feel free to re-open the issue, if the issue still exist. but i don't have the possibility to re-open that issue.

the current master of camera_index.h still shows this wrong title. so the typo still exist.

to verify,

  1. copy the content (comma separated hex-values) between the curled brackets of 
    const unsigned char index_ov2640_html_gz[] = {
  ...
};
  2. and paste it to the input field of the CyberChef page with recipe: From Hex, Gunzip
    and see the output: 
    <!doctype html>
<html>
    <head>
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width,initial-scale=1">
        <title>ESP32 OV2460</title>

the correct title sould be <title>ESP32 OV2640</title> for the OV2640 sensor.

(to reverse, from html to hex-values again, your can also use the CyberChef page with recipe: Gzip, To Hex, To Upper case, Find / Replace )
@lucasssvaz lucasssvaz mentioned this issue Mar 19, 2025
Merged
@beta-tester
Copy link
Author

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(camera_webserver): Fix typo in OV2640 definition lucasssvaz/arduino-esp32
1 participant
@beta-tester